Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Al Viro <viro@zeniv.linux.org.uk>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Richard Weinberger <richard@nod.at>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Jeff Layton <jlayton@kernel.org>,
        Anna Schumaker <anna@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Ian Kent <raven@themaw.net>,
        "chris.chilvers@appsbroker.com" <chris.chilvers@appsbroker.com>,
        "david.young@appsbroker.com" <david.young@appsbroker.com>,
        "luis.turcitu@appsbroker.com" <luis.turcitu@appsbroker.com>,
        "david@sigma-star.at" <david@sigma-star.at>,
        "benmaynard@google.com" <benmaynard@google.com>
Subject: Re: [PATCH 2/3] namei: Allow follow_down() to uncover auto mounts
Thread-Topic: [PATCH 2/3] namei: Allow follow_down() to uncover auto mounts
Thread-Index: AQHZH46KYwHmQVZSuUOnI7kKQrlJBw==
Date:   Tue, 3 Jan 2023 16:15:04 +0000
Message-ID: <EAE9AF79-93B8-4366-8672-20D407694E7E@oracle.com>
References: <20221207084309.8499-1-richard@nod.at>
 <20221207084309.8499-3-richard@nod.at>
In-Reply-To: <20221207084309.8499-3-richard@nod.at>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BsmZCzYy3puqtxlzgfom6J6hAbuhaX4PuOo1+LN/A2yI5S3eWqFY8j95pX7j?=
 =?us-ascii?Q?c7dla6F8KABX1V/zpbFk+WGFCZm6e3XsNKymbk5lWQwy8Ypbo5JmeqLTz1mF?=
 =?us-ascii?Q?HWoGfr0aA9kHd0EGBiKQHB5wkFf0mjuR20Ch4pB/T+97b7CeqTUKggHkf4b5?=
 =?us-ascii?Q?geB3c/bnpkLZyNh4Vbvm6EE1d/D1oUKZiJpXVNxmU9Yxf6tDwpOm1Ew94ejL?=
 =?us-ascii?Q?FLHusfrogru9HMzFin+7Ay/jpW+kzk6QkC7ua1c3d1IPhWveNviUrnhAh2Wa?=
 =?us-ascii?Q?XQNIC5lhdrTRVtrKorz0L6AJPkl8ENl82cGBbMeqvfyyxS7qeMTEayrekR9N?=
 =?us-ascii?Q?aSB6qa/Q4IUSAELlcCjLJXYmx4ISByHfHwn0yPzxicbWPokYDDAgcMXa/Qfs?=
 =?us-ascii?Q?TMOFeOzw0x3WHpxuNZQSjYG4dBmRNlpkff0oJ91MQK9NLQDyeKiquVa/wKG/?=
 =?us-ascii?Q?VigQDT7pJu0Xl4T7/WEmp+ScjE6mnB3I1J8eDO0lDvqpxa9gPuntsNaaRnax?=
 =?us-ascii?Q?k6EDKZHo/riAn87QOpkBV5EM8R2UQQJmCYLM2+zam32OtCLrAeQw/SGvDI6A?=
 =?us-ascii?Q?Js77CoD3g67TVuJlPYzGX9Ut5fLDuKMwyrxqaZyNP6NcINZfQATk6m5G+Ecn?=
 =?us-ascii?Q?EdEhrQTMVcXBbTRWs0qdtoAY+Oyv/UWZGH5dwDO+8AHg0IBNcIMb9EdoOiEF?=
 =?us-ascii?Q?KKl0EATRmpLk8P7C4IP06F9eZGbECtVShBbC+Ew7YJO/RyWjSyi0V3nK+vzK?=
 =?us-ascii?Q?E5QPO2CMGRgasg0w/A9K9isn1HHWUciEnJfWeElz7ntAlnDFGVtOnT+JUaU3?=
 =?us-ascii?Q?3/1bZyHapE2zhauWSmjtQpsNPQqcGidISFuXuewyPPmioEVjuRZ/yCvQyVcf?=
 =?us-ascii?Q?XoAzfP7iEqbwQ5wYkF/wYGrA53ojgwmciMyoVVwvp9JUklpnZwcRkitggwzk?=
 =?us-ascii?Q?2n/lOMYYFkI8erTtcwkcC76ZhQDmGOMha0921qn2oVpoi+DRoCDhmt6dB33i?=
 =?us-ascii?Q?EaoJtm1dVa3jKzS7RougpUfaJujpbLUDwHd31zH/LalRclsvBhQZPvZPDXh6?=
 =?us-ascii?Q?iBUnJ/2316BJsXMb92OGfFNoirKGS+NFGyklVryMzKamAW1n3BCTEtT/a2xn?=
 =?us-ascii?Q?6sZtoX0DSjYuntmrAPENJeev/xyMWEogN8S/7VTuLGiHb/wu15a4ZWjBmbnL?=
 =?us-ascii?Q?5zYpq+4NoHC/dRL75F2QWRsDKi+rYOFbdbgxe+kT9RfjunHdsNSRjZ97/IBd?=
 =?us-ascii?Q?YtDZIRMPrtunB7ii7sDGotm5FWLlUc35Cz1eGSeoxR8bjT+mynrqO4oAOra3?=
 =?us-ascii?Q?Kjnqqet8/zC5wKZnB8OByJdOyEN8KWaj4yxzENU937utJxbBsU5nUXD87G3h?=
 =?us-ascii?Q?LcY5xud/0nYxP/dgxeI5eWDo9VbVpdRr+lk6z8LmfIoWo9ekHMpJjYpbwbfV?=
 =?us-ascii?Q?cvEyuwCa7mfOL+z8+xrQyhyiHexQ7FJZIm7fvtKGxUGYAu4mlEwF9Hew8gU2?=
 =?us-ascii?Q?NwllHLSX93PP5LkZA3h4ZxEUjxbvHF0QUfy6K4aAD5kZ3s8C+x694hX+3LUA?=
 =?us-ascii?Q?J7/pMRV9fURbDI6ysZNIOuvS1ly/iuEDjBxiDkWOEjv56kSN2dc+ZYVWg9N8?=
 =?us-ascii?Q?jg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D73C89D0004DE24AAAEA34BEE0AAD936@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?aLD5+lX+AoanqxgByryeVQMQku2DqVuZbGF50aagJhAZNXr1FkH2pw91aFYL?=
 =?us-ascii?Q?c1nvkaRcrkIBv23sWthpSGr8fsvl+QBVcxIs5K1Fapw9nVm2/2VYe7swqLfo?=
 =?us-ascii?Q?f3ZTNX9YoflBfOjDPyUcPdd8YeVkbgJvIhNpTFYlWROf/fxezCG3m5HcD6a5?=
 =?us-ascii?Q?5OE226A8gDKBWeB4plGVSelMiOzxP4wR3Vs87qcHPRvDWt0gay6prjqIMwEy?=
 =?us-ascii?Q?3MqxLwYutp7poydzRdE2TIfBliVIDfw2bGKnuNvTPU9Eh9zHK3iyO8pdPAfg?=
 =?us-ascii?Q?dsd5qSHbA+DV+t+pN0iGBu6BrorJuNf5MU9UfXyy09Lb95TNDRfYKNWa+otX?=
 =?us-ascii?Q?gxRl7nXJXIOK4AbWMNlSXQUFmpWGj06prnPOPnIS3G/o3+AHXvoRvrmx1Mnz?=
 =?us-ascii?Q?sSIrqIPvObiYkCSufnzuSaNyKQFJjLm7e9Bc6AkJnFldgfq/zBLIw53ScwUr?=
 =?us-ascii?Q?0xabvK6YBFlWcEBChztYaRAcOyn3jbIj0MrmCGs+dfRz1DZ7EmEQ1uwgdNUH?=
 =?us-ascii?Q?gXsZbP+HPjjrBNA25NenkoEWyme3VELLE3j89AbOJV+WMWWdIzIPQTnGDrs9?=
 =?us-ascii?Q?obfu7rdUNhdN62cBZg3UgCd3wQu+tv3Vn1vBk5DJ8x5QDpGNtoxE++DeCKDZ?=
 =?us-ascii?Q?LVgYvt+tk+ZmTIcE1PeTx5LbByhGyWnxO9MvPqYe3OlI7S/wbRZEXLbcvZrY?=
 =?us-ascii?Q?Ud9M+zyWlh7+14iiMEvjFy4rkWmjwMZ80C2T/jgyzHi6edc7DSrFJg0NtRQ3?=
 =?us-ascii?Q?H0PhgvvxzTW3YsCZPe8IoJ6wBn/6/+Rxw+4CEzVkT1cVhmZNJkYOyahneHvK?=
 =?us-ascii?Q?Zu/8JOcVbWH0E0Yoj+g5URiD3vI5LPYj92CWdB1gNAGIvMBMsp6HXCTx0ZbP?=
 =?us-ascii?Q?ddS3g3hOe1YlRmdMAuQzumC0ImF2JCHOfKuqL+YRyGMBUBylwv+gQxp7MFL7?=
 =?us-ascii?Q?tbWEfHIMiAZjFn+OJEx2NxyWwv6HtHgNPUOszXpOy9RaLQxL4q5ActJxDXOT?=
 =?us-ascii?Q?2iZdrWrSLxxY/EJVY8tV2eNe1qTlRYwkPj+h72Q4kFk4mvI3SPxi6NeAbw/e?=
 =?us-ascii?Q?HgaKuS/CRkrS/Z4N/Fa9K/3I65H3WnZGANGKcoXplCPocwpnbv5BLLDmtrDn?=
 =?us-ascii?Q?xSWj7/nOzcEoFQdzagbQwSnKIT3BcJVykDqSipnsAkp/QMsb3kiM/59cFEEL?=
 =?us-ascii?Q?h2NwLMSAiOPFF0NnN0sGVhMcBehSR1jQQf7NhcsWl6L8LyXDlknP/fCBT38?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b7e4a06-ae74-4a54-86db-08daeda5ac80
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2023 16:15:04.5681
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mgVJUcspcFEoANFW3xb0iRsqIgxOemE2ms6FkzKv5bJ8uJ0FP0unSgEJbI0OfSlyxUQVs8B2xc0aGHlKSU4XJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6098
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-03_05,2023-01-03_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 mlxlogscore=988 phishscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301030138
X-Proofpoint-GUID: ZzGk7an_mrEcKcaOD1IZMz6UUrKzHT96
X-Proofpoint-ORIG-GUID: ZzGk7an_mrEcKcaOD1IZMz6UUrKzHT96
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 7, 2022, at 3:43 AM, Richard Weinberger <richard@nod.at> wrote:
>=20
> This function is only used by NFSD to cross mount points.
> If a mount point is of type auto mount, follow_down() will
> not uncover it. Add LOOKUP_AUTOMOUNT to the lookup flags
> to have ->d_automount() called when NFSD walks down the
> mount tree.
>=20
> Signed-off-by: Richard Weinberger <richard@nod.at>

Hello Al, you are top of the maintainers listed for fs/namei.c.
I'd like to take this series for v6.3 via the nfsd tree. Can
I get your Acked-by: for this one?


> ---
> fs/namei.c            | 6 +++---
> fs/nfsd/vfs.c         | 6 +++++-
> include/linux/namei.h | 2 +-
> 3 files changed, 9 insertions(+), 5 deletions(-)
>=20
> diff --git a/fs/namei.c b/fs/namei.c
> index 578c2110df02..a6bb6863bf0c 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -1458,11 +1458,11 @@ EXPORT_SYMBOL(follow_down_one);
>  * point, the filesystem owning that dentry may be queried as to whether =
the
>  * caller is permitted to proceed or not.
>  */
> -int follow_down(struct path *path)
> +int follow_down(struct path *path, unsigned int flags)
> {
> 	struct vfsmount *mnt =3D path->mnt;
> 	bool jumped;
> -	int ret =3D traverse_mounts(path, &jumped, NULL, 0);
> +	int ret =3D traverse_mounts(path, &jumped, NULL, flags);
>=20
> 	if (path->mnt !=3D mnt)
> 		mntput(mnt);
> @@ -2864,7 +2864,7 @@ int path_pts(struct path *path)
>=20
> 	path->dentry =3D child;
> 	dput(parent);
> -	follow_down(path);
> +	follow_down(path, 0);
> 	return 0;
> }
> #endif
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 157f0df0e93a..ced04fc2b947 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -63,9 +63,13 @@ nfsd_cross_mnt(struct svc_rqst *rqstp, struct dentry *=
*dpp,
> 	struct dentry *dentry =3D *dpp;
> 	struct path path =3D {.mnt =3D mntget(exp->ex_path.mnt),
> 			    .dentry =3D dget(dentry)};
> +	unsigned int follow_flags =3D 0;
> 	int err =3D 0;
>=20
> -	err =3D follow_down(&path);
> +	if (exp->ex_flags & NFSEXP_CROSSMOUNT)
> +		follow_flags =3D LOOKUP_AUTOMOUNT;
> +
> +	err =3D follow_down(&path, follow_flags);
> 	if (err < 0)
> 		goto out;
> 	if (path.mnt =3D=3D exp->ex_path.mnt && path.dentry =3D=3D dentry &&
> diff --git a/include/linux/namei.h b/include/linux/namei.h
> index 00fee52df842..6f96db73a70a 100644
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -77,7 +77,7 @@ struct dentry *lookup_one_positive_unlocked(struct user=
_namespace *mnt_userns,
> 					    struct dentry *base, int len);
>=20
> extern int follow_down_one(struct path *);
> -extern int follow_down(struct path *);
> +extern int follow_down(struct path *, unsigned int flags);
> extern int follow_up(struct path *);
>=20
> extern struct dentry *lock_rename(struct dentry *, struct dentry *);
> --=20
> 2.26.2
>=20

--
Chuck Lever