Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Trond Myklebust" <trondmy@kernel.org>
Cc:     "Trond Myklebust" <trondmy@hammerspace.com>,
        "Anna Schumaker" <anna@kernel.org>,
        "Olga Kornievskaia" <aglo@umich.edu>,
        "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: Handle missing attributes in OPEN reply
In-reply-to: <7a98c3e70bae70c44418ce8ac4b84f387b4ff850.camel@kernel.org>
References: <167279203612.13974.15063003557908413815@noble.neil.brown.name>,
 <7a98c3e70bae70c44418ce8ac4b84f387b4ff850.camel@kernel.org>
Date:   Wed, 04 Jan 2023 12:01:33 +1100
Message-id: <167279409373.13974.16504090316814568327@noble.neil.brown.name>
Precedence: bulk

On Wed, 04 Jan 2023, Trond Myklebust wrote:
> 
> 
> If the server starts to reply NFS4ERR_STALE to GETATTR requests, why do
> we care about stateid values? Just mark the inode as stale and drop it
> on the floor.

We have a valid state from the server - we really shouldn't just ignore
it.

Maybe it would be OK to mark the inode stale.  I don't know if various
retry loops abort properly when the inode is stale.

> 
> If the server tries to declare the state as revoked, then it is clearly
> borken, so let NetApp fix their own bug.

That's probably fair.

Thanks,
NeilBrown

> 
> -- 
> Trond Myklebust
> Linux NFS client maintainer, Hammerspace
> trond.myklebust@hammerspace.com
> 
> 
>