Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8719025rwl; Tue, 10 Jan 2023 18:19:46 -0800 (PST) X-Google-Smtp-Source: AMrXdXugzu1XeG3ha3zO+g+5MW/+DVFVTs+QUjvmoux5+Dy4D98qwptbfbrs3BsLfIv0mmMwIlIZ X-Received: by 2002:a17:906:9709:b0:7c0:af5d:c54c with SMTP id k9-20020a170906970900b007c0af5dc54cmr54304528ejx.77.1673403586162; Tue, 10 Jan 2023 18:19:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673403586; cv=none; d=google.com; s=arc-20160816; b=gjs8C4MaSUSJyyHj1l32DVVA1LOGnKS09eK/dbKhrAMJrk9dm8odwfxRjYDyUhuP8P 0A9OlsKBwmpca+MvUb4T0cATlhhHNlvL98ha8CEP5kF3rfV/+52guCcHRpboeWt9YZsG UYl7jwX8P731A221aiLYdxIKrE0AZTrJnIgUdil+ZI45MLeO7U9hfnkjFQ+KSXXlbT19 UrP+PXH9iN/Traa009P0yQqcBfJMo9vRBMZxhO5Qdgz8tX4R2pj3CJhSh/2yCc7LW7Jo h88Fiy2v4MAz+rH2d9dB8ZRQgLmifrQCdYj/05TldavRXJLBmMH7C14UQzD5jZuJ2/uC Jv3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=njrrmruQDIC0in34qwfwYVLn81yNCbta3wj2UCVqMgs=; b=FWYoTNCgtdWGxyP9V3On6fGao9Iom7g7sGJsfKbBlVloU3cDdKv/v/D3HXOrTJqwOB x+Z3XKYAQIVUJCLQRSA0nvnL/x8TrhTKEj3cfPQRyjCOoXsAn88O4gpLpM7Ttnlr1snO NAQAepIgeBNBgjAlqAnT0JdXBUcjTq6PKmhYnGbKCuS6Bm6nb6fYFItGeBq03pcOhBth /oHC+ffeIi0ZlbdXS51h/EdsNCmM/Nl9Hd8SDfeWtyE1TynUQhBDXmjmvtPAPhS5b+3v Db5j5UyH/tVtYwIapDSijvw51b8/N5EVFIwRNl7pyvhlohzOzT24Rc/5Sdw3Y+kUrrTW jbYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=nh0gZtN2; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js12-20020a17090797cc00b0078789399a48si13667552ejc.870.2023.01.10.18.19.18; Tue, 10 Jan 2023 18:19:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=nh0gZtN2; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235551AbjAKCNm (ORCPT + 99 others); Tue, 10 Jan 2023 21:13:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235245AbjAKCNb (ORCPT ); Tue, 10 Jan 2023 21:13:31 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C85F64C7; Tue, 10 Jan 2023 18:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=njrrmruQDIC0in34qwfwYVLn81yNCbta3wj2UCVqMgs=; b=nh0gZtN2mPu3w5awxIzCHyCM0m VL7XTrWSWP/T3pXS1JaWh6hTp9KvW6KHDhtX2kyiA8TwA81F6Pqp6MN5fkdOW8mYBgv4PdAWlhPV5 HO78Fcczxdyq35HLxMLDtwOodiZ2yh6krPSU706FcQ7hzKU0gDz3zzYBXr4hSNnWGOVbwrT1cmA6r h5aEO9JLRpDpneToikJt11IFS/KVgwbXQlCgNlO11DGxO0Y2XrcTxJzCJg+0AhCT1uzgmJS00241D 6QuZTgwjKcGVUzNQkX9fB3CfMoLRZ8ZIWrKz6eEqMFO7wlHlPvRp3Rsm1EAfnwwOVh84wSPT+W1vT xRc2VA1g==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pFQbO-0016Yj-2p; Wed, 11 Jan 2023 02:12:31 +0000 Date: Wed, 11 Jan 2023 02:12:30 +0000 From: Al Viro To: Jeff Layton Cc: Russell King , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Xiubo Li , Ilya Dryomov , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Christine Caulfield , David Teigland , Chuck Lever , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Namjae Jeon , Sergey Senozhatsky , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , "Darrick J. Wong" , Christian Brauner , Christoph Hellwig , Steve French , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2] filelock: move file locking definitions to separate header file Message-ID: References: <20230105211937.1572384-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105211937.1572384-1-jlayton@kernel.org> Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Jan 05, 2023 at 04:19:29PM -0500, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropriate #include directives to the source files that need them. By > doing this we trim down fs.h a bit and limit the amount of rebuilding > that has to be done when we make changes to the file locking APIs. > > Reviewed-by: Xiubo Li > Reviewed-by: Christian Brauner (Microsoft) > Reviewed-by: Christoph Hellwig > Reviewed-by: David Howells > Acked-by: Chuck Lever > Acked-by: Joseph Qi > Acked-by: Steve French > Signed-off-by: Jeff Layton Same question re git tree preferences (and my Acked-by in any case)