Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/4] nfsd: filecache cleanups and optimizations
Thread-Topic: [PATCH 0/4] nfsd: filecache cleanups and optimizations
Thread-Index: AQHZIP9hPEqobn3Ri0O8LyGKP9NIjq6aIzGA
Date:   Thu, 12 Jan 2023 03:04:33 +0000
Message-ID: <47962242-1486-45D8-9179-BB57714F0517@oracle.com>
References: <20230105121512.21484-1-jlayton@kernel.org>
In-Reply-To: <20230105121512.21484-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+94C5OOvqo81FYo/yz2mM+W8GQo2A1mG0NmFfLGgk3SRUGi/+FTE6n8NBlZO?=
 =?us-ascii?Q?PrlhSyB1WHKKcTQaMIcWrInYmPThLMiFst6Ov9X9inNVUiBPnYBUuSRdI8TT?=
 =?us-ascii?Q?1tcNCBFpKM3FQ51bVRopddVjk1EEqQIXXpKeQd1ccfXNKFr4s1/fbH+gJMcq?=
 =?us-ascii?Q?ONX57P46tuxRHdxsRCGmfrj/ZxvdPN/VWPGrKAqLuevys0iP+6lsj15Ioqkf?=
 =?us-ascii?Q?MjMQAQwzKTMWLHc4FfspZMur5Suzja5WMkRHB1uEnbbFEADuTJtQGTwkZ7MW?=
 =?us-ascii?Q?2bli05IP2vFsKTDh7mpvT0sN2ENp3UFc4+LBq2cCELqccSanff17UO6DQIBA?=
 =?us-ascii?Q?e2SYvymmfP8X47s0NZ0Zs22v2+1OHwdqNKviiHS1oysplNdBboK7j9tvLRQ3?=
 =?us-ascii?Q?MOwXN3qPU63xKiB0CZFZI+YznlocXJafiGUnqV0eOYdAgLQLQeJipbpMUxuv?=
 =?us-ascii?Q?UnuzoSSHUiIp1ww7Qnsbwr+qvxL0S40sznV12OKSi/JdXpuaLAGaeNSa/N0c?=
 =?us-ascii?Q?RLfDiEKWw4HA6EL2Ftd4MQOef57hThCD2GIktHpe7QIcdmYQkrtqIRFbawOG?=
 =?us-ascii?Q?eEudG0j45TZUSzKxjbhwN12SoVzrwIrdbetm/4Ag6fcDQbQnxbjfFYSSEKfv?=
 =?us-ascii?Q?AcbEru9kVORkh1JNuO4fhiWKsORwE7ZToAqV8rxLq+1XsP7Ux7fFI2RLA07n?=
 =?us-ascii?Q?mI5/5mjw877FsL5cCwvZSzCDe8ULEmj8MjCeA/5oGY3ENLUSphWqwiUw+afA?=
 =?us-ascii?Q?U1bjFHQQ7by3pb2pViqKFPYBCdtotIIaJ9ORHdodIVieXv5cXSoLesvAAoFl?=
 =?us-ascii?Q?6GJMmTfDDh1Caz1zKLbTgK6vtM8dp+FT2+rQjzgH70TX9wqM4tt/WHJt6b/5?=
 =?us-ascii?Q?XcztMp0m0oiGCNsig7/KgNxbinUz0Nt6Ox2GdVd8m3xFa7I1PrEIkTV9cDQM?=
 =?us-ascii?Q?iBC2MpimMT5RFomb7+d+GlFvI1mPID2DkXzqN1EoVt4c7whHM5nNYA9LFSyY?=
 =?us-ascii?Q?yT97lYKcKOpYebeNJe3Bu2rBxzn43rjYraYLxr2I9deYeRFSILJJ0/3+l/5Z?=
 =?us-ascii?Q?uGfthbECowm/OMrNTQNfMg7WB9oXnj0/OnX960cmuvabzzvwlD0I+5vDV/Ep?=
 =?us-ascii?Q?3yQ8lUN5rl4nx3I3Rm4Vo0/bnRvCf26lwF0091mUv2bF5yonU42b3WqFnsA8?=
 =?us-ascii?Q?WneeMb2lf2tfVdSB5rx1+5vmjPz0HC3Cv0+F+qAqrT7BNaHcF++sjZSzqxvD?=
 =?us-ascii?Q?DdAXCvNWN6PvKqsIrsLfeztGcYO+qgsMGKQlawDcdErafKZbf/urAgl3HRtH?=
 =?us-ascii?Q?aRlAqsBbDsHZ8QB7DkGAVUeitpIzQ4GLvgkXovzWJ8w5i+j2z0CMJDzRESCt?=
 =?us-ascii?Q?XXFKYeF7Pv9U9Zf7ZCdRj6PxrF5YUdTBB/ImMRaTFRDp84WkbjcKcnSMEOb/?=
 =?us-ascii?Q?ChRCGNgFjiZG8SmghGIbIM84iF0j2e0spHOBEuOr1cU8eKJW8/BJ4oMRJpUV?=
 =?us-ascii?Q?0vOlwqBoNk1PbwBCvoDA0EaiHXMrN8IOJA/FKEuWTCwGOLkUHlmgX9lfgN/B?=
 =?us-ascii?Q?VYgueaWp0gVIgixMACWpuEv5UDA3aSZtsAMgR4MKUlzSBBiEoxBDLDTIAduP?=
 =?us-ascii?Q?CA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8ED427F7F2617E48814A793294A16F46@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: S8NFsB4SU7WIWGy6eZHfLFEu51qK+yo6T8FC8gvPPB7BpqsjFemn2mNNV2PhQIYV5HV/Dnm7/fUBlDD7c/hp2QLsyUNmZBxxQhwrf5VGJecBdvNzUTAH01s78oUdZ+gR2LtNzWgnJ31iWnB0ay6oNHtcwbtKUa7z4aYtCtpHMD9wq1/YvO6DxPdxt2OiRbNmaJkU23O0Umv6w+tCp5waqxutfW7U1li0DW+BulY5I4KhwbbIUtn5Hzf+7tNDjkRvy6FdE7rnw3fL1YCJdmSiRo/xeGzWJIcPLw2J/it225DeFLNEcAcNkxUP8akrMI9X1ylUWpLydTVHtB9AnScwSPG8zwgY0OuSKMDLlAMi05s30SG1/sujkFMi4zv8LtODJtU8HBFmcGwIFvZJQjY1bfWfwNLKQAnrz68a5f/vZGUn6VaaQrVEPMfh2EQrJMCaad/jpAkQZDk85Htt7qVd9j8EOgE6ZT8RT6Y/Id+CC7GC1Jwz0i8orr5uA6eokV0Bbhc56orHgTDVr23fdXKpx4GgBBd2qawtWOIHdB0Jaz0yLK+UpN9a2o/mtSTwcbhFBiuRaMByM5LRmx1clL0ky4fJvcVCeSyA7aydF2GCECy++j79yCSiNmsbnUMvQ2ohpXu2a38AYLjp/tbDxbAjAAexdakT7sVd7H9z3thac9Hn6gvukyDrevWF5P+OYeE/ByV7E/a4HPRqas9DIYL54GjnyDHA5Z1u9sDUOHC7Q47239bp0QS0QQCl17h4j5gKUuNG/DecatposLFjQHkqItjoncFRl2KBGPNwisd/QlE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c43f996-cded-4b8e-8502-08daf449bb5d
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 03:04:33.9291
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l1cWeuSEC0eFcpXURh9uB0onDLtUE3vBdGW6u0kzH/uUHsVF4FYl47wYFKyXpaWteP20ZutSeB2WhMoOEdOXsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4856
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-11_10,2023-01-11_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=914 mlxscore=0 spamscore=0
 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301120018
X-Proofpoint-GUID: gekCayApToSMJBkkOuszVkSKxbeQumD2
X-Proofpoint-ORIG-GUID: gekCayApToSMJBkkOuszVkSKxbeQumD2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jan 5, 2023, at 7:15 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> This is just a small set of filecache fixes and cleanups that I put
> together while going over this code. None of these fix critical
> problems, so these are probably v6.3 material.
>=20
> Jeff Layton (4):
>  nfsd: don't open-code clear_and_wake_up_bit
>  nfsd: NFSD_FILE_KEY_INODE only needs to find GC'ed entries
>  nfsd: don't kill nfsd_files because of lease break error
>  nfsd: add some comments to nfsd_file_do_acquire
>=20
> fs/nfsd/filecache.c | 52 ++++++++++++++++++++++++++-------------------
> 1 file changed, 30 insertions(+), 22 deletions(-)
>=20
> --=20
> 2.39.0
>=20

These have been applied to nfsd's for-next. Thanks!


--
Chuck Lever