Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp1065040rwb; Fri, 13 Jan 2023 07:32:06 -0800 (PST) X-Google-Smtp-Source: AMrXdXuK4fs3SQukDWMPcXx7jedoRAKNoXWhUIX5rfE5xmY3YXMjHMvReaQAyiuL75PTlPQ4WQCF X-Received: by 2002:a05:6402:12da:b0:49b:7416:e3ff with SMTP id k26-20020a05640212da00b0049b7416e3ffmr4865523edx.5.1673623925737; Fri, 13 Jan 2023 07:32:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673623925; cv=none; d=google.com; s=arc-20160816; b=iVRgVJt2aYFnOr7wdrfYF+1uhHlZ3rj65ZOvya1lK5mBT5pC0O6wyE3yRloVQBuRGk 4xhrdpHLAcLLi//ccgjJY9EBXEF8nygBgkh0d4e58lkYlZEyW3RlHKRUJCCI4EPvb09X oyotco/NBfXxOIYZd3tUkg9IZkgFdB6LkuhEKVtP9wrkugOd0qDEtZwXSfydnSnQQaE7 eb2eT0XxsEE9rhg3It76YqREYtMXIxx+IiClmHny5i/vD7Qt61fuGqU1RISmqqg0knyl hPMD17GegwN8gQnSOxmc7ZsC3cVGLduIQiJgFSWBy41nnl8DeQTtcvICtV2MzrRBT07R GN1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature; bh=DZsg2V/NXnp42jG6uMz1RdOEJPEjNhooiAes7b/Xfcg=; b=PVCAoMPkqwIV3ffuJhrHfbtqrWvetxBQxmoCq2mKqJw/XmB8tqg2G5+rS0W7LSLd/x ObzpTNdkj364ojbwJpegaaJOOs2sGl5TLQxJYbs8XLlojC/dkQeNX5xyGA4JWDVDzNcg R4kup+DI1s9nLWYQ+6xUXgNjdHncIsu0bSmpGtyEKALAy5fTFCY+vUO86KSSIdgll3RW jguOxobQhV0LvbF3HrdPGD0QVpGgB5FEa5yKXGeJ5fLF7RagxQPhAda/ffCoM0+6WzzY 6iOipPm2roCIM6MggNBoRtoC8Q2maR0iHzo2WpylW3cPPRMwOz2JUvsJLqCGOBcrnoFl kgcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sZkK4DpH; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d23-20020aa7ce17000000b0049b471421dasi6528835edv.316.2023.01.13.07.31.41; Fri, 13 Jan 2023 07:32:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sZkK4DpH; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbjAMP3B (ORCPT + 99 others); Fri, 13 Jan 2023 10:29:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbjAMP2V (ORCPT ); Fri, 13 Jan 2023 10:28:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 982F744C43 for ; Fri, 13 Jan 2023 07:22:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 372886216C for ; Fri, 13 Jan 2023 15:22:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65985C433D2; Fri, 13 Jan 2023 15:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673623320; bh=kpUGvzOW39hlMmxADthx96vNAWACrjND/YOYiOTSHks=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=sZkK4DpHe6+3z+O4e0qj13/IOvpwcaWzUT7Tc4GxQ4KFiLEpWs+sO0NzQv2xou1ZK hBBK9QDX6ENWKyS76KEsGLwoHr81xB1RtVC9r6xmboESqv+qTGz/kn+IPic04javOL 4VXUhu8fmLS6fY7r1Gf4s8j1Js/jtpigtp9pSo8G+euo0IyjUqbT3ooRZ7MWvlKknT Hy1J3RxPxxI7daqlV8dizGVs8fKa2OghivSzJ9znkHKdoNT7xIj51nt5omvYorPM5S KvT8CSY1oNV5GacPXLLERxJsxh/JmwsocBuAexQOwyHg8FQseELd/5Iym0vcC3Cjl+ 3uCYcXOI0mGFQ== Subject: [PATCH v1 05/41] SUNRPC: Obscure Kerberos session key From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: dhowells@redhat.com, simo@redhat.com Date: Fri, 13 Jan 2023 10:21:59 -0500 Message-ID: <167362331943.8960.1546242627205639130.stgit@bazille.1015granger.net> In-Reply-To: <167362164696.8960.16701168753472560115.stgit@bazille.1015granger.net> References: <167362164696.8960.16701168753472560115.stgit@bazille.1015granger.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Chuck Lever ctx->Ksess is never used after import has completed. Obscure it immediately so it cannot be re-used or copied. Tested-by: Scott Mayhew Signed-off-by: Chuck Lever --- net/sunrpc/auth_gss/gss_krb5_mech.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/auth_gss/gss_krb5_mech.c b/net/sunrpc/auth_gss/gss_krb5_mech.c index 6d59794c9b69..9b489f7f2720 100644 --- a/net/sunrpc/auth_gss/gss_krb5_mech.c +++ b/net/sunrpc/auth_gss/gss_krb5_mech.c @@ -550,6 +550,7 @@ gss_import_sec_context_kerberos(const void *p, size_t len, ret = gss_import_v1_context(p, end, ctx); else ret = gss_import_v2_context(p, end, ctx, gfp_mask); + memzero_explicit(&ctx->Ksess, sizeof(ctx->Ksess)); if (ret) { kfree(ctx); return ret;