From:   Chuck Lever III <chuck.lever@oracle.com>
To:     David Wysochanski <dwysocha@redhat.com>
CC:     Anna Schumaker <anna.schumaker@netapp.com>,
        Benjamin Coddington <bcodding@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Documentation: Fix sysfs path for the NFSv4 client
 identifier
Thread-Topic: [PATCH] Documentation: Fix sysfs path for the NFSv4 client
 identifier
Thread-Index: AQHY9D/UHAS9TN3bW0a4ulUjeWuAMa42mHuAgHXi6ACAAA+yAA==
Date:   Mon, 23 Jan 2023 14:48:45 +0000
Message-ID: <2817011C-299D-46B4-A8E2-D5EDA9FE1D08@oracle.com>
References: <20221109133306.167037-1-dwysocha@redhat.com>
 <CC98B38C-2E79-40CE-BD9B-6E336BBD6552@oracle.com>
 <CALF+zO=u2p3BuH1nGt7DMekbRiJZGUuZZRF-D7pGULw5VoMo_A@mail.gmail.com>
In-Reply-To: <CALF+zO=u2p3BuH1nGt7DMekbRiJZGUuZZRF-D7pGULw5VoMo_A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pDCiOimkHrNFO+FBOvUiBZIKq5nqN/+BMxv+hN9nFsG5O97RBQ67kw9laocP?=
 =?us-ascii?Q?y1r4A7zvN9l6A3SdFRoyKCroQIE+Dhs+RY8TXHRSgQCFqpA9D0GLzNU73+T5?=
 =?us-ascii?Q?hzy9taj/sYDKYWERUb4zIZS6VYhIXqdw04+s4liibwC7YFgRAxJItWebFRf6?=
 =?us-ascii?Q?UiorI3SVH4PvdkYlvdQfdYOvmhvxoR6SiBz/V4J/G+68MWjdQxXNeknNTr2f?=
 =?us-ascii?Q?hDpH4UCyIF8hkzpNE5Vt4mcMFnh26kMuXClyjBXSgWelkSOYxaD0ofUDoNTT?=
 =?us-ascii?Q?qaJKfAd7Msh2LWHhne8dvBgw0jeB2ZdJkJgw/hlVWtxrQR7THNGfmBP2f7+P?=
 =?us-ascii?Q?R4383yEV3lLY9VAjtNyTeLYWrHHiIQWvE2faXGTHB8LdSwlBhqjp+v8M/kOq?=
 =?us-ascii?Q?N7etRXU3msxMzqoEHM2KA22epQkg+BrZXIjwN6+B2u1bz/Vm7xFLSrttwF4w?=
 =?us-ascii?Q?KAxc8/2ixiEdtMKNWA08vVmieclGuPQsozifUjuLlmcODmT69wVbDpmgdG0x?=
 =?us-ascii?Q?vO8XuycqsBrGVUiLjARXQorSCQzY2ReISrtB5WOCIfWva2hPYLpiZ2W8cozt?=
 =?us-ascii?Q?oN/4j5B5YCeCSg1rj4oqDYrZ5xiL0V/BEfOL9JzyYCOY/7XnzqZWFlGt31pF?=
 =?us-ascii?Q?M4cG7PjhiUFFcja5G/VSWttpwwUGFywTpX+ZjFggvxCfUADFlt5o0zqgTYID?=
 =?us-ascii?Q?0R76zNzvc5EvP1w0bksg+q0vA+xf638D8h6LG/Cgocd2/iZ26nVFuqtdFr89?=
 =?us-ascii?Q?uxQ0fr7iBEp9ieliMA5Rk+nfd2F4UYxSkio7+LZKJqpZct3VXq4OU5aEiTyI?=
 =?us-ascii?Q?HUpZoPUbjmjJem4vQk+rQA+Qbvn0lCVjA2gk8+TOKQEuSYDSyTO7VFaVtClP?=
 =?us-ascii?Q?kpz+R6VJ9XBksIs1ZiruEH3qeJldMh+YhBdk3lkwlYGbnWZ3gQPmDX59vfZg?=
 =?us-ascii?Q?LTCvBdvgksivdcIQ/pDi7++2stNVEFQM86dixrBVxXyP6bg/X5Nxu3A0F022?=
 =?us-ascii?Q?1DTE5Vs8Sj010JvoinU+JhAwsUQGknEQMjBZKNNeBcWKzV9R8wGW9x1/jRDu?=
 =?us-ascii?Q?VE/EdE+JylvceJMmD+tvUSJEu3Y9ts4I9OgM2Rl58WBVvETjdD5FgmVF1J1/?=
 =?us-ascii?Q?/gewWipJMcbV+JV2v1HTuCqyQMPTLHQhVbaPOgpPfQNJwOE+S7Oi/jfT8HGl?=
 =?us-ascii?Q?/gL5ec6xp9mPt+B7r2K/QN3EhJPgoHPlRMiFiHd2J6TmYD+yvB7mwFH2Mlos?=
 =?us-ascii?Q?mvLvjXcUUkkROKt67do63xbhqIKS+CqNwo/Bp1NaydSgnxcnLNN1E5sAcaMa?=
 =?us-ascii?Q?nPmCOQbGSPoc+fmvoLtsaKv3jSEJByDu5UeL7KNyzELHM8YHoGHfoYKTHNtk?=
 =?us-ascii?Q?qvStCPjJ0QZIr7sS3PfOKheYfKv1kDaKKtKjK9Xx/z05AMq+zjhQtt8l7L+Z?=
 =?us-ascii?Q?hUR7gb2U/7fUpUAajZy5JaH8R+Q8yiqr9TFoy0ZoRRp+Vn1pQQHsDgjDUUZL?=
 =?us-ascii?Q?zQ9Y5g6nAPzcowW97A+vPKSK0FjJhli6VvWSsIsPuLAWYd9ObnB1IPuwN3+w?=
 =?us-ascii?Q?VMr8FHWJ321Ew1+63lmOiv7iWibkGCajqSxpcMFgAQ1TU89mOTnO3jHtAsuy?=
 =?us-ascii?Q?1w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E27578D5BC19094891FF44655D4CA4CD@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3NKQ/3cnSMJ/o81iYk8glehB+kxHKoiIS+LGIOTYmcRN7qhMbnGzReeGXnuCrs0xj/hOG1HQRMBSFdDYiJVgRvaaAeCDDYeuwG3780XKMtNJo7m/uiU3HtoX+kSJewdB4pO/G5Sz8lhK7JFAIOUn/BC4mMbbqeedOsylnVuHh4YZuv2E7MoRvq8JKasKnzog4k6vVo209Sa1Lua0oSasL77q03kMQfrc3RJoT4vx0PS4Y/FKOmoUm+XbIZylOZS2HbPoDNkckCnQwl3TfTB5YlPAvOQepF/c88QIQg8Qt0oYQQAkWMpEImC7NOXi4xzqH89kgSeavAcgEhLTuOz+zPIS+AV4JgccFSZSNE2+utAkG2C3epRT6b0R7FbREOPShgNT92LeqJoUJc9xf/P1TNbDMihuuBwgcEjx+BEP88Xi0EmaA9Os7D0Ft0ipD6zABYX4BjV7eOeZFEGiLvIjOpbiChc94AX1KB/1RDdGg7Gmw3X5GXq5pw8tH19sDIOBzXXC59knTZU9SbltZplv+xTylWBB18N7cpUJoKyJpjaLIDDPF67/9RF/qwL+5WZgyTLlZ/cY0Jd1Arj2bEyHcrgxppbPeFPPD13TjQVcUSYuCtnw5dr6xo67iDRvsFQrn4gNrXw+iA4bq8dCZYdb5ZtbIV16ZaVm2MciGtsbmeOM0VM/rTC1GfbwnWKVLa5MmwepbB6LkwljbADyRpNvZf7IS1qbQPVpaswc2D6g760zM8Xp9eI79ILzOvrROZaizGJnIFLSteWUoc82gf5f9vYurqpXhS3+o0OfkPohQg6JzJ286VrKXB+D7caZBzGt
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80307fc5-3cab-4d77-2da0-08dafd50edab
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 14:48:45.2351
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: h07P1jjef3ECF3XwgFk504Slm6FErPpoxFoHfowiHFffm4nkvH+cb3b1mjN4WQbt8tgKGDpqNE9CdmvD5vNAuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4392
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-23_10,2023-01-23_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301230141
X-Proofpoint-GUID: yZIK8z20BtwCWsPXVgtoawftGfgesnfL
X-Proofpoint-ORIG-GUID: yZIK8z20BtwCWsPXVgtoawftGfgesnfL
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi DW -

> On Jan 23, 2023, at 8:52 AM, David Wysochanski <dwysocha@redhat.com> wrot=
e:
>=20
> On Wed, Nov 9, 2022 at 8:58 AM Chuck Lever III <chuck.lever@oracle.com> w=
rote:
>>=20
>>=20
>>=20
>>> On Nov 9, 2022, at 8:33 AM, Dave Wysochanski <dwysocha@redhat.com> wrot=
e:
>>>=20
>>> The sysfs path for the NFS4 client identfier should start with
>>> the path component of 'nfs' for the kset, and then the 'net'
>>> path component for the netns object, followed by the
>>> 'nfs_client' path component for the NFS client kobject,
>>> and ending with 'identifier' for the netns_client_id
>>> kobj_attribute.
>>=20
>> Seems like the redundancy has some purpose and is baked-in to
>> the path. I'd rather leave the sleeping dog as it is, enjoying
>> the morning sun.
>>=20
>> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>>=20
> Hey Chuck,
>=20
> I just realized the patch is still outstanding.  Now when I re-read
> your comment, I'm not sure what it means.  Your comment sounds
> like you feel the patch may not be necessary, but then you have
> a "Reviewed-by".

I was responding to Ben's suggestion elsewhere that the pathname
had redundant components and should be simplified. After reviewing
the code (and your patch) it appears that all the components are
necessary to have, so the document change you proposed is
appropriate.


> I am not sure if you mean this should be applied or not.

Reviewed-by: means "OK to apply". The documentation is incorrect.


> To be clear, the existing sysfs path does not exist, and we got a
> complaint about this documentation inaccuracy, hence my patch.

Can you dig up the complaint bug and suggest a Link: tag to add?


>>> Fixes: a28faaddb2be ("Documentation: Add an explanation of NFSv4 client=
 identifiers")
>>> Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
>>> ---
>>> Documentation/filesystems/nfs/client-identifier.rst | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>=20
>>> diff --git a/Documentation/filesystems/nfs/client-identifier.rst b/Docu=
mentation/filesystems/nfs/client-identifier.rst
>>> index 5147e15815a1..a94c7a9748d7 100644
>>> --- a/Documentation/filesystems/nfs/client-identifier.rst
>>> +++ b/Documentation/filesystems/nfs/client-identifier.rst
>>> @@ -152,7 +152,7 @@ string:
>>>      via the kernel command line, or when the "nfs" module is
>>>      loaded.
>>>=20
>>> -    /sys/fs/nfs/client/net/identifier
>>> +    /sys/fs/nfs/net/nfs_client/identifier
>>>      This virtual file, available since Linux 5.3, is local to the
>>>      network namespace in which it is accessed and so can provide
>>>      distinction between network namespaces (containers) when the
>>> @@ -164,7 +164,7 @@ then that uniquifier can be used. For example, a un=
iquifier might
>>> be formed at boot using the container's internal identifier:
>>>=20
>>>    sha256sum /etc/machine-id | awk '{print $1}' \\
>>> -        > /sys/fs/nfs/client/net/identifier
>>> +        > /sys/fs/nfs/net/nfs_client/identifier
>>>=20
>>> Security considerations
>>> -----------------------
>>> --
>>> 2.31.1
>>>=20
>>=20
>> --
>> Chuck Lever

--
Chuck Lever