From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Nikos Tsironis <ntsironis@arrikto.com>
CC:     linux-stable <stable@vger.kernel.org>,
        Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>
Subject: Re: [PATCH 5.4 0/1] nfsd: Ensure knfsd shuts down when the "nfsd"
 pseudofs is unmounted
Thread-Topic: [PATCH 5.4 0/1] nfsd: Ensure knfsd shuts down when the "nfsd"
 pseudofs is unmounted
Thread-Index: AQHZLz9cSyzG56mAkUSDB/Ggxzvxqa6sJDgA
Date:   Mon, 23 Jan 2023 15:42:55 +0000
Message-ID: <D98E42F0-3329-41DA-940B-4496AFC26340@oracle.com>
References: <20230123152822.868326-1-ntsironis@arrikto.com>
In-Reply-To: <20230123152822.868326-1-ntsironis@arrikto.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PQfZrK+cBblLJjApzboqPSBc1s12uJB+Fcrr41ycOElW4kHkafBMcbvqLpH7?=
 =?us-ascii?Q?kgGDmpWWAohL8Ykqv62y+/on+7W5MnMcQwZlw7284eUgJsoA6YCJvRms0wdB?=
 =?us-ascii?Q?q6JC5iV7J37aXUeh4Wfr8R86gRh51hBe0n9lMXRWpmz9TldjNd+udDC1CI2s?=
 =?us-ascii?Q?6FME/uf3UAmnm1huSdHZz+/reQmnP1j5Eav3EJiWP4pqmcp8YG4vgPgwjtNe?=
 =?us-ascii?Q?DR4TCchxr7MQ9vdDAsgUN3SKHqRzfNKIVlI5GlYxKxukELbHIP+ZCFdjjk/9?=
 =?us-ascii?Q?787gktt3r38+DLlyRimbm6MhOcr6pPmdlLId4sD/rih19Ot9MUsKM9sgza02?=
 =?us-ascii?Q?kxhJqBNsQhf2yVSxSomZTO8BYD3Mf7eQWmLnwMTaxyo+O74VCpar4uHeQk5s?=
 =?us-ascii?Q?G5U7mm0fTCCYjZV5udmw4wEh1wfIT6dwPQDdpZgi1/UBmlH0HS3S2ymaRJLy?=
 =?us-ascii?Q?59fxmvzeHUFBeQYC7+0doI5wsahhh5B4CmCEJsUK2uOxJNCF+Edx+0rqgkV9?=
 =?us-ascii?Q?kESocoq//k0yNm2cPA5gT18tyO7qbayoiO6cvjHGWnxXJCzWknWquwGwhX73?=
 =?us-ascii?Q?H+AgJgX3ImRKme32dnGc+/SbU4kaMn/LuiPgI7XaLDIZtYJZQ50VsmX5hkhb?=
 =?us-ascii?Q?gmnzLAMP7cHhdyNYw710sovQVP/jqdJ3NcEXZ6V0YqS/rnCfFjbvrSC9+C2U?=
 =?us-ascii?Q?vplgzMXwUTpH7nBpIU2DGAnM6QGt2WnHxBKZe80wurLGWyiMfFBvyBIty/L3?=
 =?us-ascii?Q?JGhSzXV5+0HH5/vDIN+8YiUMcHCAMa2rbVM+afEZ6A7zKXN8PmFyE4tKR3Mg?=
 =?us-ascii?Q?Qu/fuu6e4mE+ov+PFEQ+ZMhKQT1miGVcw1BqMD4ktAt2QhJi5elspVNty7iW?=
 =?us-ascii?Q?ZC5cuoHQ47pzmxAkcHHJUlRgb0kgCEZFjxiZ32v+hoYCoV9U2sg0OBhC1vXj?=
 =?us-ascii?Q?i6DGBahlx9OMBV2Oy8sJWILhk6PYg5+/KLqLHsHZ8AkGrAQPgwuqohOvl98C?=
 =?us-ascii?Q?t91IcdtI093jdXNs//inWXjoWLZqqmLu3N+vhT1kJ1+kzrz2bWBF00GvBpbs?=
 =?us-ascii?Q?6FgR9wG6Afu3aijJp4FksTDwpXUmzmqccU03xUU+WoWDILPXPYUnE7m+bh3o?=
 =?us-ascii?Q?yNKfHbxKPihvd5VxFkd5CDRsvCaUAGnvDOaDFzZQWNB+HVhUentaIjvSZfOF?=
 =?us-ascii?Q?jr/jdzWYvx9zk1amv1pSozv8Slu1wKNGsHVkQoog73oDfzbOo6OZc3bsf5WO?=
 =?us-ascii?Q?DG3lDK2MHuRDKA0qcYEX+niTIOOPr3uPbynIEr0KGzyq48gklbBl425O4Orm?=
 =?us-ascii?Q?oc1kKvyvixktbcoRZQhzF1kz4qVKQdBQlHzqX419ZT+kqiwf6qKwXFVgiVXV?=
 =?us-ascii?Q?lJiPm4T/LtFBxKPN3lZ6/NL3rZngTQnvIlVUYzaNXhLx5AkKaG8+lNE2cQB0?=
 =?us-ascii?Q?ZNdttEcmxHJ6Pwz73FEf9jjmCXKmGCg2dFOWG3AZc6TdQ5M1dx3R5yi6ex37?=
 =?us-ascii?Q?Dg66M88u1/g1HOz8UgQMa6zMVtkjJ597q58x6Ow0/U7pGMny3bn95Zce9Ifl?=
 =?us-ascii?Q?ftie8Seq3NQzcBsdjkrIAsQZDXl9nKO1DC97HUHKUc4Pw7cufnhjQdopC9dC?=
 =?us-ascii?Q?JQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28A136AD48B62D4CB03C5A9B0689CDF8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uIqwFBN6BeSRt2Ym+J5CY5w2zFhugoSfG7srCPGVd6XUsuVWklqbaHO+mt5miyGQESO3H4ESlXWDtc/JMbGbQqoILWfLqX+svNDEe83wPshqU9n+DKTq6uoAUf2IwX0JRsnA9XUNC+OV5SqCYobytiTsWlSLA6yuynGyo9Siv1ILEqDUitZ03rHn5WbBmhjhyZHFonK2sXcIy6cQ6cg6wuLexqaO+a4ad3QMEu8jSkqIZrCscYEyq0c/G9tWQ/F1jx7ig038GB0Me3FXlFs3A0vy6hBtsGYzXFhnnmAwfIhm9v8wn61BIVccx8JE61Pwd4OGXjuNr8qbtAzwAcEukZnvjhl/jUIzdNnYQzBDYvWVy0F/I8GhDOz8td9I8+1KDRD2GS2GTtk5jovWZ0nDPwr9Fku5NA23tODSmaTyXauJjwT0JR5AZmw/+TTtYdh/vQQs4oFUBKTQrNwBant7SRW9L+x3cL5lcCQA8EGnlFgsQYEeNvNlNg0eHtPPty1Q3aQn24sWzKh6BTlVLJgUafkDFOjxFd24sQqr7Aq4TOneyNzZ+0cWfvk6hd3mEmhCibhEGTLjrbkuDCM17w0oBBn5uXuhAa4QeMn1ceS5TDZQNeDI/ThNmj7/MhAnxV7qp+DWlj/cdkxN60Xw9heuOJeNK03wxGIaAcmSVXgwQs+pRy2uK/vixDLdASpl3i5qhfhYSDgYGNoOrIxZh7jkpuKAmzoqw2UB6J0W4NSKswqeyOnkopsZ8Wd/YhV3McMCc88Mp4/JQmEGTzNgqkeMlM+qxB8YPhMi8WuOESt7rw9HfkZXKhpvjnlemkbWxLkS8xgrurA99cRkFQayJeOrPDNpLLi8aVXlHtwtMSINxFY9fyH4/EtJM9YSePjb+6O4
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4cf148b-9637-48fe-66d4-08dafd587ebb
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 15:42:55.1506
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KfYuSaGcUNgGJjp9BOBnGbRtxYq/8iHbw1E+8L8A3uF2YAN3qM7b49qJaX1vgP1HJ3EwWTUhR3G+EqwIqE4KIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5706
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-23_11,2023-01-23_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=749
 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301230150
X-Proofpoint-GUID: Jc8DWXFLzmJ7fFdL7WUKmVAPif4S1qat
X-Proofpoint-ORIG-GUID: Jc8DWXFLzmJ7fFdL7WUKmVAPif4S1qat
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jan 23, 2023, at 10:28 AM, Nikos Tsironis <ntsironis@arrikto.com> wrot=
e:
>=20
> The bug that upstream commit c6c7f2a84da45 ("nfsd: Ensure knfsd shuts
> down when the "nfsd" pseudofs is unmounted") fixes in kernel v5.13
> exists in kernel v5.4 too.
>=20
> That is, knfsd threads are left behind once the nfsd pseudofs is
> unmounted, e.g. when the container is killed.
>=20
> I backported the patch to kernel v5.4, and tested it.

Nikos, thanks for taking care of this!


> Trond Myklebust (1):
>  nfsd: Ensure knfsd shuts down when the "nfsd" pseudofs is unmounted
>=20
> fs/nfsd/netns.h     |  6 +++---
> fs/nfsd/nfs4state.c |  8 +-------
> fs/nfsd/nfsctl.c    | 14 ++------------
> fs/nfsd/nfsd.h      |  3 +--
> fs/nfsd/nfssvc.c    | 35 ++++++++++++++++++++++++++++++++++-
> 5 files changed, 41 insertions(+), 25 deletions(-)
>=20
> --=20
> 2.30.2
>=20

--
Chuck Lever