Message-ID: <d1ec3853d8709843e7e8fd70e463db2ee71b0bcd.camel@kernel.org>
Subject: Re: [PATCH 1/1] NFSD: fix leak referent count of
 nfsd4_ssc_umount_item in nfsd4_copy
From:   Jeff Layton <jlayton@kernel.org>
To:     Dai Ngo <dai.ngo@oracle.com>, chuck.lever@oracle.com
Cc:     aglo@umich.edu, linux-nfs@vger.kernel.org
Date:   Tue, 24 Jan 2023 06:48:25 -0500
In-Reply-To: <1674538453-12998-1-git-send-email-dai.ngo@oracle.com>
References: <1674538453-12998-1-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-01-23 at 21:34 -0800, Dai Ngo wrote:
> The reference count of nfsd4_ssc_umount_item is not decremented
> on error conditions. This prevents the laundromat from unmounting
> the vfsmount of the source file.
>=20
> This patch decrements the reference count of nfsd4_ssc_umount_item
> on error.
>=20
> Fixes: f4e44b393389 ("NFSD: delay unmount source's export after inter-ser=
ver copy completed.")
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
>  fs/nfsd/nfs4proc.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>=20
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index b4e7e18e1761..889b603619c3 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1821,13 +1821,17 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_c=
ompound_state *cstate,
>  out:
>  	return status;
>  out_err:
> +	if (nfsd4_ssc_is_inter(copy)) {
> +		/*
> +		 * Source's vfsmount of inter-copy will be unmounted
> +		 * by the laundromat. Use copy instead of async_copy
> +		 * since async_copy->ss_nsui might not be set yet.
> +	 	*/
> +		refcount_dec(&copy->ss_nsui->nsui_refcnt);
> +	}
>  	if (async_copy)
>  		cleanup_async_copy(async_copy);
>  	status =3D nfserrno(-ENOMEM);
> -	/*
> -	 * source's vfsmount of inter-copy will be unmounted
> -	 * by the laundromat
> -	 */
>  	goto out;
>  }
> =20

Looks good.

Reviewed-by: Jeff Layton <jlayton@kernel.org>