From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: update comment over __nfsd_file_cache_purge
Thread-Topic: [PATCH] nfsd: update comment over __nfsd_file_cache_purge
Thread-Index: AQHZMaqd+g0lqDJ3/Ui8X0ffJBLTb66xOAgA
Date:   Thu, 26 Jan 2023 21:32:27 +0000
Message-ID: <BBBAF186-1825-476C-B457-549410E8FC5E@oracle.com>
References: <20230126172116.198443-1-jlayton@kernel.org>
In-Reply-To: <20230126172116.198443-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KvT5fEzi9pC4mEFNgJWEZKI5xphUVcVeyEAiv0B3JRuhMhlX9okZQnGJTF9I?=
 =?us-ascii?Q?Mp5+7LwhhAQwVnC15L4sFA58E99oVf6DkdZlWJg2c0yoPRN1nBNi5gL0Mqlq?=
 =?us-ascii?Q?9KHOcZq4zvw2L79metboqkORmQzsWQ33bMK5m5zFq3MemrV/IhRLp7INRJgF?=
 =?us-ascii?Q?Z02Gy8Fav9XU8DQvD7P73oIygMRki3Wdt9htswZR4opL45MeDddpixhZV15y?=
 =?us-ascii?Q?N2EZWbgSnKOfuUOi9VAgA598SGHzlWVoA03Mw5Y13fvPQ4IdG8aIL9jIZ8eR?=
 =?us-ascii?Q?0N8Hn6p8lvJRFPCxY7KdpIWRyJ3daFjNNfEMUxDyHht+szYc60XT4lvjzLbL?=
 =?us-ascii?Q?+eJArcPJX05atMOiLIW7HnGMGHJHb9P0utkPHrwnpBQWtoWxtUqirJyqvzQe?=
 =?us-ascii?Q?cJQjIL1ZI5uiWCPqRqucTH7pMg2CatL+7UxHYooxwpGbWtkLIO8uxUURzmNF?=
 =?us-ascii?Q?ATTFvv0g/6F86md6f5XFgDEi7DJt8scb3Tih++1gU5coefzx3DD2vdwA59bp?=
 =?us-ascii?Q?a171Wz5wJvAHTim8ygZCO4p/4esPUoW/pZjpiUbeyyNXC59KNcO6iBdAykAJ?=
 =?us-ascii?Q?+BYgyMqXTBXKdUYw/4WfHqJvy7Nd4c91djOunwBlxbBHYfGAwB2hYAnPZZ54?=
 =?us-ascii?Q?SaPfc1pMYuDJs7GI1y/9rnhnepBG1C9rAV06Ukl6yPAFSsYZIaT0nYZ4d4yP?=
 =?us-ascii?Q?uL7lnT6ZU5REvXST0ybdv1UMW01n3/1pFgaPOgfBZd5+K+ZiOzL9sczmN68v?=
 =?us-ascii?Q?N1DFomDkiyIclU8l7vmf5htZU17zY82oB23Mh8FS/DXfmn6SSKas0k82tF+d?=
 =?us-ascii?Q?Q4AvDKEqHR1sSJoteQvCgqMuaCcQtpauApyQo+SHLtqi7NErive0tHnZ3kAe?=
 =?us-ascii?Q?6dVtroSJtNjL3Ra4ATFYWElCHvJcyqS7GmqhJl01fmYL/a/sgo7hgdpedmMx?=
 =?us-ascii?Q?DIa2ZVhQucmJKyW5QAy3flIlkXbeteYSxNmRkr+Yt0fTgfYfJCSzBi1K3RvF?=
 =?us-ascii?Q?WQAV9vZmb9x9DdPsDuCelP0KLB5tBqYly9t9n0msbyOnp4Hfh0TUK1m8544a?=
 =?us-ascii?Q?U8/gUmY9wdw3PfQioOsJV+s2sImmWV5QL8zW6K93aqHZ3BpC52OF8VZ/YQec?=
 =?us-ascii?Q?EzLc6E/Psj/Y0mA/4I6vmyJcPMlqw0JKOefF+2CR2zoA0o6bAl2a3iKunCZn?=
 =?us-ascii?Q?l40qWksAH2iAlWfJkcVsTFwHzSiT+2Dbz+nyrLDOAQfJlOuXQiwGMnT2/Y79?=
 =?us-ascii?Q?oCPPEOoimwPRKVl2ysPfXSETKYE+DWGb/49a+OwetBL0JJXO+xba+5bvjOuN?=
 =?us-ascii?Q?wfHlWPwOQ8ZyHjHbfsb7JwfrlwG0fvD0D6+2hyOWVBL2ZZ+ZfYXNfLLKPZmp?=
 =?us-ascii?Q?SuNu5w9a+bzg4Dt8nyZ/Q/7G9BdZlHw/XR2s7a6bxbyGY5hXf1JVSYxrqvND?=
 =?us-ascii?Q?50ckrgczLewsyqYtSDT+MKRBcowgFylx3nM57HQgg8ToeYL8Lm0GesdzU6fj?=
 =?us-ascii?Q?ee5ycHop8Bdgzcji+09kpjcEvQhRWPnVjklDI7lTQ5sbavgfDcFvRss0Lh6c?=
 =?us-ascii?Q?mCM4RUOzUWZ73JhZdaHCl++Pnqxpfz6ENnd6ds/oS7rC2UEcJz2GmYKM97Ph?=
 =?us-ascii?Q?7A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <567390E1C5865F4F9DF9E3531DFAF3E8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: to2gx2apz0z830fTRAXJasqI3Raba/Xjz0bqE0qZmBKbQqtsSUQjZ4XqNfvwNyLEnVmTie5/ugNJy9arXWCRg73EzdvKOKGI5iV3Y/AM43o03VAqYptqMxMlwdIdFAMrXp6GnYXJ7CQ3K0mBhLFfiiSciUJJWxbIvyihEXkA/1VwQxBmtS6QuVUemunn8otdrIluE87nNWGLmRvfxjNfMb3H6iIAZKunhdbdiJa9K8mrWYdky7LLinoiB1L95/TL+jPZJqOozpO9ahAcGaW1gZP2RGrjq39P03+lCJpKqTcjxbDdQDaNb4zt9SzPvCaNInoOvnelGTcqKITkNKSaecg+t+iMDUvDXr1vByYAtx9TOKz3mZnp4m7UnChepay3kYlb+173EnyWW4vsXvqDbXAuWSrfb07k6HP8VfKH9/L0XuFLgcOSUVPdwErKZodg/C8dYs5AYxnkWGRb4sQVyBQvXXKhqRNRTLozGVAnQ8l3LsOEACb/01jtaCG4bpI4MQ3J0fjRP7vnItH77L5o+i5zYqKOf57DJK9Yb004Rp8vzGx20u+Yr0SRbYFQwsKRjaQ6JaZ9GC3kW2fTpxc/ue0O12fFi1eaLxTbF/RSYT9GB/hlRAZupJhe7Az4XF36xZLJ84EAvA1Qkt96dIjgC/8SiY1pmqxyolRvDI4ka1+5Pn7iE1zDzxQcJWOhneR7ypFQP3izVzG3KYhZGvtXOp2Xbs1h93Cxv9qxnQjxrOr/Uwnr8i1vJlV9yUyYRyJU63DVJd+4tXuqHPaA0ipraoa727cwvz6xVG/o3JvFfTI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca88e64a-9d4f-4360-753a-08daffe4d2ab
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2023 21:32:27.8268
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MtxQbQaLwp3qu17GYciCNXbw7UT/kfPf2XPdRELrKC7LI0mFVIMgnZ6nYZWupro3I6HWg6aiPqYubx98j3MoQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6306
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-26_09,2023-01-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301260201
X-Proofpoint-ORIG-GUID: peYU-iS0IoCY9ZylIEsnq4AGgljGcPHn
X-Proofpoint-GUID: peYU-iS0IoCY9ZylIEsnq4AGgljGcPHn
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jan 26, 2023, at 12:21 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Applied and pushed to topic-filecache-cleanups. Thanks!

That branch now includes nfsd_file_cond_queue(). Can you check
to see that I merged it appropriately?


> ---
> fs/nfsd/filecache.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 348ef543c4dc..e232937fea8e 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -808,7 +808,8 @@ nfsd_file_cache_init(void)
>  * @net: net-namespace to shut down the cache (may be NULL)
>  *
>  * Walk the nfsd_file cache and close out any that match @net. If @net is=
 NULL,
> - * then close out everything. Called when an nfsd instance is being shut=
 down.
> + * then close out everything. Called when an nfsd instance is being shut=
 down,
> + * and when the exports table is flushed.
>  */
> static void
> __nfsd_file_cache_purge(struct net *net)
> --=20
> 2.39.1
>=20

--
Chuck Lever