From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Thomas Graf <tgraf@suug.ch>, netdev <netdev@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC] NFSD: Convert filecache to rhltable
Thread-Topic: [PATCH RFC] NFSD: Convert filecache to rhltable
Thread-Index: AQHZNL6DmnuOVVmZY0WaktzKRiQ+7g==
Date:   Mon, 30 Jan 2023 15:21:23 +0000
Message-ID: <41E7AC96-4570-4379-A998-C4E71977E374@oracle.com>
References: <15afb0215ec76ffb54854eda8916efa4b5b3f6c3.camel@redhat.com>
 <7456FF95-0C16-45C7-8CD9-B4436BE80B71@oracle.com>
 <Y9dfB322nu5d3fB1@gondor.apana.org.au>
In-Reply-To: <Y9dfB322nu5d3fB1@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4gG7wrGmZAwjKd/1ZbGWhYJfC76hXII0f0QSoh2D3tA7TRY2Bt+lbb3Q24JO?=
 =?us-ascii?Q?O64RPEIBEvDq9kg4/BhKci/qGMxApUAf7M3XeG6islJc8b2V7/f/6wFm1t03?=
 =?us-ascii?Q?GwYCSIQvVjb9V9V3yqZxm0MdriPSq9BHGCXmJXFNCx6f/5NwC69/BSJ1+VEO?=
 =?us-ascii?Q?gJG33lc/ekFaKXXAAmIqoMSyw2U/PlzKc1M5YIFTvB6Cw+5tkigDKE3GH3ev?=
 =?us-ascii?Q?mrx8osEOZeZUgfFTVlR8pmjVWwy3a/DXfaFrgOHsnOJqxoH+fDgX/kK5Wsti?=
 =?us-ascii?Q?JBFiXrKS4ftKdosJDhx9yxWF4LrroSNBK9kdtO9hwdn/VGED/JeFOuD7yNaD?=
 =?us-ascii?Q?CHV+0hUkK9RND++YzI/SkIi8tfq25qfXAexD1BgiukbNglertKjlL90O47U2?=
 =?us-ascii?Q?xU3Igr+tgqCLdNTp5Lb5t/x8uz6ulFJGtMpXeAVH7XfSbylNPFWIpZjhXndG?=
 =?us-ascii?Q?dloFI/q9ttliw7Yks79sA6Dfqi1PGxXYfZhfCTZ1yoasf/pkp+MFInzLVoYb?=
 =?us-ascii?Q?+J6xGCoZ9zo+CZ57cwt4RQ337UOCrdhim9y+Nx1NmuyZM6RYbLaXpo/pAZl4?=
 =?us-ascii?Q?ZMDwZBxJ/AVaKd1Ec9vnMHjBO6p0It9r2FqPdlmGJku0Jkv/FarMH9DmmIrq?=
 =?us-ascii?Q?vbzIsv/1xFRUtnkEk9gepyyVmbN50d6ou5NvvUR1AZxOzasZiYr0Xh5g9gBp?=
 =?us-ascii?Q?mxZelY+FOQIcC3S0WAjsWKoWbXoU3gPuA2fThT8qPjY9jS9A8lytGEyda3lY?=
 =?us-ascii?Q?NpKr60SH3f9fT/ue+h3Mjr5wgmNfc6xPXvhFzpBqVpxRs4l61jipwWQ1qDMJ?=
 =?us-ascii?Q?92U+K5+K0Sg1PfafpTRhTxcTDIoc8jk5ql2bkHESL8gXfzpf/qPPoNxti2mZ?=
 =?us-ascii?Q?5ycger0t4eVWkNGKMAH37WAor02kmabr7sIK9rOLQ1Gb7YW4JTB+BA97pfLF?=
 =?us-ascii?Q?vgeOE3pyu0FBFvF2DMWVBlr+yEVoj7H9XxU/8AXS0gbphCR73Wb25IPVIpjy?=
 =?us-ascii?Q?wnlYTeSCmVAEuZ7jYJYEmjoOJmMHcx544tQ4MDoJ/mC0T30g2DrJiElbyZhK?=
 =?us-ascii?Q?uLF2tOweRiIqPj2R3SEkN1QOIAJXD61EG+FQbQtHhhHEe9O/vcFL+FRqylsf?=
 =?us-ascii?Q?kqyACDT6EyDegkX3VqFEiEg2fPMMEZOOW0KDnFY7oCqNWX2KTyGfeiW26fAK?=
 =?us-ascii?Q?XT86BxwuxUiIcx0xTZ7f7EXZqCXI6fkGzUJU2RT+XRNaM9l1tQgkFwbVovje?=
 =?us-ascii?Q?F5CtYJhrzrg4yGZtz0vrPVmU5qoSYf/YIXmv1k+XgCEIVhV+LP+D/TSymdcQ?=
 =?us-ascii?Q?B2vztJ+eY+dTReTmIuYz6p2uOichYBETuBQrKXkTw3EOMM4SXxTXXGQxcnZi?=
 =?us-ascii?Q?tYmdu+0PJXQamBCCQyAuXr7N/dsB2LAxWVUah5AKzs6DTiOu1p6zuvmwzYlF?=
 =?us-ascii?Q?lEetwx4h+oBzmpPq96Z6cWbgP+n1s2CLDCh87KHr0pywTsHmGPhVD1SGYCkp?=
 =?us-ascii?Q?NqWbhSd6rDswyFR0oFBnYBsqrF1QOVrjtlWGSvScpq2WbhzRPrtsGfwZbPAu?=
 =?us-ascii?Q?FSJMo2dNJYIYdpUJeT8bF0dTTPggUi2lriBfeSZHCLaPFBPEn7TSm7M3NKfK?=
 =?us-ascii?Q?iQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3B4C8842F748814CB684612AF34DB948@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: S5k0yjWIxWgYxCtHwDmkzGOZLslevPZ8uBU0g2yboz+v36EIgzdNA1IXOC009E6wnfmmG3S7L5BGZNxlXUuPaEF6BGiUj4fTBiwiesPnJU7dPO6STlOzAdSyzRRXBNL6oVLYzgCnaSXseXpZqkOQ+vbMpp3qdYO6wXXRfHfkZ9tEtFMCFhZ3079jASYweGHryvbM2x3oyEFPuRPQx3vVRhoKqknGRDLly4y0MwYmhbKLX2aqnW48GB653OdIYOl/L4xtG/DevSiD2aIxaTctsnc3VBkcveYF/+fW/MFoatl8xVhBFHTEkjYIvHgOsf4P5epa7g6XLBnsfZlIHBQ+alpKEQ6X1UAv/HOdKWNYC9rAZAeSJ3zJ1PIuz+vDJRUdRMAzcNBgzbXKvahLaAtwK5uycOPb6ipN+HfTgxqk6294iG2fR/IF2AhOGIFQ7OCY6V4/JSIen0MCU41zTxDul6RiopBxyGp8f/J/OXwRT3RLzV1XpKWPHlPTFv2YImE90CF/aA1Kc08pIpkUkXarkZO54K91yUTidfbAOaHp/r/giUGmHSyCdsuZtBwtQgUo56KvUbZDAxxmvZdbMi1SaovcAVJRlnUEElGq/KG92t9RFuo6Tg97lUumAm0G3LmHTAw5RBEAOPTHJiqWqskEp5lhUBTT91MCDK0SFyDTol28lYaDD9xlAh4Wx2e+sbhXZAnX+TzGbycS7LySHD6zhBOB7JRgHkEYLCkzEv/CUNCk+3+kh2muBEn6PAdXog8DreBjB7KzBFpg/iPoCUhgBjFN1dJbL0E4OICm8in+Nv8nV25IAXpbFlTptPgFlpGfACjxrxJW0JcstzdJOyVMtA==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a82ea028-34c0-4844-73e4-08db02d5a5e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 15:21:23.7246
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2CMLnchV3KNFY0xmspba6Kn8Pm2mCwad4et11dJafXuzrpLgarllTLr79956kwJYLes1uk/Zq7Gbc63AOOn6dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7118
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-30_14,2023-01-30_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 suspectscore=0 mlxlogscore=868 mlxscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301300148
X-Proofpoint-GUID: Liud3iVFgxg5lURbolQAzEcoNcKa7xkW
X-Proofpoint-ORIG-GUID: Liud3iVFgxg5lURbolQAzEcoNcKa7xkW
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jan 30, 2023, at 1:09 AM, Herbert Xu <herbert@gondor.apana.org.au> wro=
te:
>=20
> On Tue, Jan 24, 2023 at 02:57:35PM +0000, Chuck Lever III wrote:
>>=20
>>> I could be wrong, but it looks like you're safe to traverse the list
>>> even in the case of removals, assuming the objects themselves are
>>> rcu-freed. AFAICT, the object's ->next pointer is not changed when it's
>>> removed from the table. After all, we're not holding a "real" lock here
>>> so the object could be removed by another task at any time.
>>>=20
>>> It would be nice if this were documented though.
>=20
> Yes this is correct.  As long as rcu_read_lock is still held,
> the list will continue to be valid for walking even if you remove
> entries from it.
>=20
>> Is there a preferred approach for this with rhltable? Can we just
>> hold rcu_read_lock and call rhltable_remove repeatedly without getting
>> a fresh copy of the list these items reside on?
>=20
> Yes you can walk the whole returned list while removing the nodes
> one by one, assuming that you hold the RCU read lock throughout.
> The unhashed nodes are only freed after the RCU grace period so the
> list remains valid after removal.

Thanks for the feedback!


--
Chuck Lever