From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        JianHong Yin <jiyin@redhat.com>
Subject: Re: [PATCH] nfsd: don't destroy global nfs4_file table in per-net
 shutdown
Thread-Topic: [PATCH] nfsd: don't destroy global nfs4_file table in per-net
 shutdown
Thread-Index: AQHZPhdll4oDbTD8z0CNLVRbctrrVK7KM4kA
Date:   Sat, 11 Feb 2023 20:31:47 +0000
Message-ID: <03EDD716-A995-49A4-B9AF-E1AA13AAD16E@oracle.com>
References: <20230211125008.21145-1-jlayton@kernel.org>
In-Reply-To: <20230211125008.21145-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dKoq+KIR1kW6aeBLw9qPIClWwfZbRDDHGWTm2xrFRFxa3ECbF1NOSJ9h7gQv?=
 =?us-ascii?Q?E2oyvc4Lh19sMxrKlTHuGd32RscCoOpgOqVJmr9jWoYh+/LMq62TqRVgaM2K?=
 =?us-ascii?Q?2zNrOaPNMXqqeV7gS4c08tsbKIxLLoN7ElaYpm9G6VCLqOd6lUSJaC01SH+S?=
 =?us-ascii?Q?PGp6JiArIhjhoNn/jfJ+I9IhJSvNVjBmR4Ynn2EyFSX/NyzW+B5enLMaFWTq?=
 =?us-ascii?Q?DoyWykgzjBJ+Px9pFTFpCnzj/7assyGgeufXi/X8WPBU1eLjGqUxHKsvJsPQ?=
 =?us-ascii?Q?sbvkFYsc2c7OUAiXx44CzUjljNfZLUHI4TfRD/J7KdBNQG4YGI7G6lmdTKg4?=
 =?us-ascii?Q?1rnaF0vYNa8l/Yudv8NIR77UXKJ440zO8qDUZbA+G8/6P4vbrxeUD4Ex/qg/?=
 =?us-ascii?Q?oix6LuLQFj+cbELQAviHjyKkJv61t53viv/3mdQn0TRFOo51jx2D2c9f2mGA?=
 =?us-ascii?Q?hnCqIsVXA4h4veiBERS3/xwdcWJfdlgzAPcaXhhxqE7G1iFzI1c69QKyNvTZ?=
 =?us-ascii?Q?qQd82kVtxwUbwnZfuG39k77YwOkbzgJ/EAS1uJsCr0sHaQPTbN2K7mD6Z/jv?=
 =?us-ascii?Q?W4uz9FMRJWpSNEIAR2Zgfs7pUgn4agq5pLNEZ6bstYwGHHA5RMkUIa8gQg1k?=
 =?us-ascii?Q?DJCVXun/jtgZslczgA1+Fbm7If5pM9YpkonVHLWcz+iboyrSFpzB92rSKuNL?=
 =?us-ascii?Q?adCs2ygPYALNId1BjybuVoNVgAosHP7I0Kc8CvwBo9u2nNST+oPlX0XEbwn/?=
 =?us-ascii?Q?DsURnC2EqSZxim+XRSaJlvglBmFrpsXQnlvdyet1raS2/JfQQ4c+K29K20ha?=
 =?us-ascii?Q?wWZ6lppUzW+iouyXLu/eYDCRvgZsw25i0UDb35EbmYA9D5P3IXQPFZwZaBJI?=
 =?us-ascii?Q?gnFBF5z94lUhFX+Lzocu3j+MOARSBBJ6viPZrXG3ftbyh/So9qzcWk5Hc7N6?=
 =?us-ascii?Q?6yWDWN2TqMsxjVr3ybPLWxJzhwRxjNv5pZyHVa7gvBb9hys4ocodKxLcwhdP?=
 =?us-ascii?Q?bQZeg/PGln0eDbcBlzjyA7gpVrxS4enTMs0Tj2wit4aijMwxeW9vpQQpC1i5?=
 =?us-ascii?Q?/sK2qoUpmw06QEuAoor1vLgByrWrQPPP1bEUUFhqRIk8aXzEaXPCQpSHZtC+?=
 =?us-ascii?Q?wDxDYe4Dkwdd8jnpW7c0mw02d9g0Sc3nSADJig+zELU1IZ+LYNjgani/rqOF?=
 =?us-ascii?Q?D3UTLZewubD5VnxR01dkR2YKWxLPzr/zKSSL1O5bjsx/+zx72pFcRW6WjuW4?=
 =?us-ascii?Q?O356dp+NiJIREZnvTR2JtzjZqmTkv0lUjBNkuTZIcZI9Uz1qrz/tka/sjhTm?=
 =?us-ascii?Q?OczPylkkg5ngHKwTDzy7b4dTKAlRBnAuyVlw5+SFw5BGlSoQaPq/kr1yYycT?=
 =?us-ascii?Q?cbAUwaPnUuDv4y213bB3KWWdK91Ebq/WOBPmLLeU9LX88sUSL8aaasc9iMcY?=
 =?us-ascii?Q?xXxL1K1bCX/CU8SCvBcPpg5isIOn6dju0nQ1gNCvcxTAhSx5krtEOoHKSHfv?=
 =?us-ascii?Q?7Ny9odvtHs1msNPvBhD1txybYsi9+uJ1jzpTYj9JFAObbXfWYU67Yf4pjzmx?=
 =?us-ascii?Q?6R9J4LcOSbineJvcxKuQ16G7qaQ1gSbialuWQYnbWF3J5Ag1SyqOtmVjVd7s?=
 =?us-ascii?Q?dg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3948AD282F888E40A3E6186F5E802864@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wMQoHrEJBPxvXKkl7/84QmIWxdrS+5PIXhBtj0JrpRVgD71chjWH2br+npcqdi7XHfm7msuNk5nsJNf1pdBDefoF9cmImnBERbll8bd21Q8Hdiw2r/0K+HH3pexJWhYH2fliYK7x6kI25p2v8ksY7u6UlSCShkf8TmI3bkztig20bqTsD28YslxdVlbUJw+SAS6LPa5n1GIC2lyqpGCHDr+qH1d2aTKFtE7k1wz8/wHex9dcIpCdwmGFdMbhyJCGotKcI2s/dFwucyf8RxZ26iPmjtRKZyNuGK0wiPIy7vRU5XmO6BCZekAQl/KUR6sDnpTf0Oy5QBQLMrYi1do5e/TaVUYqrp9YqRwRrgsMpfX7pfNN42HukAtt9j2xCtmSh8GzWDT8LuRxrOPwAK7a4aiSzVyHFRAKx1ZNUIS0xdLkaBQeDBAH/XVMeqmgTNGrPZqVI6rdV/BhgJwUtLsK86rgLo79iUPcM8CZ694YyEUuzvSNzKtcz0AEUVbowZpTa9BPxNJ/7Mvmu0pOqfcjN+1Gz3i43RBVyrk9prbMKHhRvG96SNftjI8wcGZGEJLXhwwynUu4OiGEE5U1/SeYelhRNTz9pCZkXiTUL+viKbxzr+D+t3t2S3mHaVE8d6AmsmIMYDigpbpEpSacUBtzTLQOAelEIXXMJYJWr7PxXvxXV1eh/vNV3QPUaPm8OZjJsKq/CXyFB5g4bBwm3kijFcHXQIYFV8GKa3AS0klVXb7TEC81TsBxiK6RmbUV3aKTDSB2sz+4p5icQAPI8iLXufLh/QM45RVzfmLceu04tV6fMAhhlNxzsi9foeVCZNkk
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2abb6d62-36a0-45aa-6a70-08db0c6eff6c
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2023 20:31:47.3962
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sYVSoORp/SW4X6B3EZU5jKZNgGfRgAyRiyHf3NVGswaaJLUl1Xh9MWEKW5PVVZ8BLv+8OORyaimKyc+NiNG1UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7120
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-11_13,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302110191
X-Proofpoint-ORIG-GUID: UKDMYpWMG18Jk2tnd6M11eQFzneVriGn
X-Proofpoint-GUID: UKDMYpWMG18Jk2tnd6M11eQFzneVriGn
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 11, 2023, at 7:50 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> The nfs4_file table is global, so shutting it down when a containerized
> nfsd is shut down is wrong and can lead to double-frees. Tear down the
> nfs4_file_rhltable in nfs4_state_shutdown instead of
> nfs4_state_shutdown_net.

D'oh!


> Fixes: d47b295e8d76 (NFSD: Use rhashtable for managing nfs4_file objects)
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=3D2169017
> Reported-by: JianHong Yin <jiyin@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Thanks to you and JianHong. Applied to nfsd-fixes.


> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index af22dfdc6fcc..a202be19f26f 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -8218,7 +8218,6 @@ nfs4_state_shutdown_net(struct net *net)
>=20
> 	nfsd4_client_tracking_exit(net);
> 	nfs4_state_destroy_net(net);
> -	rhltable_destroy(&nfs4_file_rhltable);
> #ifdef CONFIG_NFSD_V4_2_INTER_SSC
> 	nfsd4_ssc_shutdown_umount(nn);
> #endif
> @@ -8228,6 +8227,7 @@ void
> nfs4_state_shutdown(void)
> {
> 	nfsd4_destroy_callback_queue();
> +	rhltable_destroy(&nfs4_file_rhltable);
> }
>=20
> static void
> --=20
> 2.39.1
>=20

--
Chuck Lever