Message-ID: <11ac2dd02431095cb861bc4ea1ad7529fc79d3c5.camel@kernel.org>
Subject: Re: [PATCH] nfsd: don't destroy global nfs4_file table in per-net
 shutdown
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        JianHong Yin <jiyin@redhat.com>
Date:   Sat, 11 Feb 2023 15:47:43 -0500
In-Reply-To: <03EDD716-A995-49A4-B9AF-E1AA13AAD16E@oracle.com>
References: <20230211125008.21145-1-jlayton@kernel.org>
         <03EDD716-A995-49A4-B9AF-E1AA13AAD16E@oracle.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Sat, 2023-02-11 at 20:31 +0000, Chuck Lever III wrote:
>=20
> > On Feb 11, 2023, at 7:50 AM, Jeff Layton <jlayton@kernel.org> wrote:
> >=20
> > The nfs4_file table is global, so shutting it down when a containerized
> > nfsd is shut down is wrong and can lead to double-frees. Tear down the
> > nfs4_file_rhltable in nfs4_state_shutdown instead of
> > nfs4_state_shutdown_net.
>=20
> D'oh!
>=20
>=20
> > Fixes: d47b295e8d76 (NFSD: Use rhashtable for managing nfs4_file object=
s)
> > Link: https://bugzilla.redhat.com/show_bug.cgi?id=3D2169017
> > Reported-by: JianHong Yin <jiyin@redhat.com>
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>=20
> Thanks to you and JianHong. Applied to nfsd-fixes.
>=20

Thanks for grabbing it quickly. It'd be great to get this in before v6.2
ships...

>=20
> > ---
> > fs/nfsd/nfs4state.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> > index af22dfdc6fcc..a202be19f26f 100644
> > --- a/fs/nfsd/nfs4state.c
> > +++ b/fs/nfsd/nfs4state.c
> > @@ -8218,7 +8218,6 @@ nfs4_state_shutdown_net(struct net *net)
> >=20
> > 	nfsd4_client_tracking_exit(net);
> > 	nfs4_state_destroy_net(net);
> > -	rhltable_destroy(&nfs4_file_rhltable);
> > #ifdef CONFIG_NFSD_V4_2_INTER_SSC
> > 	nfsd4_ssc_shutdown_umount(nn);
> > #endif
> > @@ -8228,6 +8227,7 @@ void
> > nfs4_state_shutdown(void)
> > {
> > 	nfsd4_destroy_callback_queue();
> > +	rhltable_destroy(&nfs4_file_rhltable);
> > }
> >=20
> > static void
> > --=20
> > 2.39.1
> >=20
>=20
> --
> Chuck Lever
>=20
>=20
>=20

--=20
Jeff Layton <jlayton@kernel.org>