Date:   Thu, 23 Feb 2023 10:11:32 -0500
To:     Jeff Layton <jlayton@kernel.org>
Cc:     dai.ngo@oracle.com, linux-nfs@vger.kernel.org,
        Frank Filz <ffilzlnx@mindspring.com>
Subject: Re: [pynfs RFC PATCH] nfs4.0/testserver.py: don't return an error
 when tests fail
Message-ID: <20230223151132.GA10456@fieldses.org>
References: <20230222134952.32851-1-jlayton@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230222134952.32851-1-jlayton@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
From:   bfields@fieldses.org (J. Bruce Fields)
Precedence: bulk

I orginally thought I'd continue maintaining pynfs on a volunteer basis,
but I haven't been.  These all look like reasonable changes, but someone
else probably needs to step in to make sure they're handled in a
reasonable amount of time.

--b.

On Wed, Feb 22, 2023 at 08:49:52AM -0500, Jeff Layton wrote:
> This script was originally changed in eb3ba0b60055 ("Have testserver.py
> have non-zero exit code if any tests fail"), but the same change wasn't
> made to the 4.1 testserver.py script.
> 
> There also wasn't much explanation for it, and it makes it difficult to
> tell whether the test harness itself failed, or whether there was a
> failure in a requested test.
> 
> Stop the 4.0 testserver.py from exiting with an error code when a test
> fails, so that a successful return means only that the test harness
> itself worked, not that every requested test passed.
> 
> Cc: Frank Filz <ffilzlnx@mindspring.com>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  nfs4.0/testserver.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> I'm not sure about this one. I've worked around this in kdevops for now,
> but it would really be preferable if it worked this way, imo. If this
> isn't acceptable, maybe we can add a new option that enables this
> behavior?
> 
> Frank, what was the original rationale for eb3ba0b60055 ?
> 
> diff --git a/nfs4.0/testserver.py b/nfs4.0/testserver.py
> index f2c41568e5c7..4f4286daa657 100755
> --- a/nfs4.0/testserver.py
> +++ b/nfs4.0/testserver.py
> @@ -387,8 +387,6 @@ def main():
>  
>      if nfail < 0:
>          sys.exit(3)
> -    if nfail > 0:
> -        sys.exit(2)
>  
>  if __name__ == "__main__":
>      main()
> -- 
> 2.39.2