From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Jeff Layton <jlayton@kernel.org>, Dai Ngo <dai.ngo@oracle.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Calum Mackay <calum.mackay@oracle.com>,
        Frank Filz <ffilzlnx@mindspring.com>
Subject: Re: [pynfs RFC PATCH] testserver.py: special-case the "all" flag
Thread-Topic: [pynfs RFC PATCH] testserver.py: special-case the "all" flag
Thread-Index: AQHZRupqLrsW5tLEk0S66PU5K1PKOq7cpsCAgAARNQA=
Date:   Thu, 23 Feb 2023 16:21:34 +0000
Message-ID: <3B034712-F376-4D71-8A72-703B030140F9@oracle.com>
References: <20230222182043.155712-1-jlayton@kernel.org>
 <20230223151959.GC10456@fieldses.org>
In-Reply-To: <20230223151959.GC10456@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IIUkpA42o2CLD/NNoO/jJ0lDzWTPZmJaTOAxgtk/dlDEIFI6e/nfbruTkYin?=
 =?us-ascii?Q?FecM4aZCJou+nPGT98bMyGeWKT2SDENJHuZ7gljrvUjCzJ6RG9rSn7PWZz9j?=
 =?us-ascii?Q?6XE0vC68zMGZOjgIPm1sTjeDzzThVjvRNYSoC5cLMaczE1WhvrpoRBri1hDW?=
 =?us-ascii?Q?LE4EoU7LdleJ+0J2yPDVVhE2a1Zh29p5i3yJppCUuAevpGm3OVJCDHv67rPm?=
 =?us-ascii?Q?3u1kdhJ5YJiXcdzLEEYx0bclmx4brdE/YQQjzQ+jBuyrK36HWWxWyaygf9sm?=
 =?us-ascii?Q?9TnL+w8axSp1Iq7O46n5XBBnDl8VYd6FD61578mV1cbP13gPYOP+QmGc8f5l?=
 =?us-ascii?Q?R9SCJw3tbRh9N7lf5JBQSxbIJDeRWmS29RUzsCTRTzSVwllL4l/d55rFpzFK?=
 =?us-ascii?Q?nfjwDO35M2KA2vjbsHYhWIy945R6uW9WpW4+wJx79kfxpaFtdMxU4thF5rPU?=
 =?us-ascii?Q?s8G3aqakHYgq2UroYQrb4wH5zaBNJHZMbAPSpenlcfUb3jjDuO5xXNSbMSry?=
 =?us-ascii?Q?965S+qkJz496RYsPLeGgMFOkTKkM9tE9dtWdEcnPDW2zJkT+tjsL/hpZR40I?=
 =?us-ascii?Q?wzq/xl0OjkgfjYRz9kMNFLULd3+DnYy7tikoKlvIU0oabS4cFI4vwli7+iIp?=
 =?us-ascii?Q?nrjqDgOouDaDN24YChcDV5uiANohEkL8saCuKxuP1LHOEtRs+n8IOvxolf9l?=
 =?us-ascii?Q?ln8XXFLuR4qQ87qBvunHKxz5TJn5dr4lybYHAEUuay63jMK0zRaJuka0ijPd?=
 =?us-ascii?Q?1768UaOhpdyxhHBYKf/fL0m2RD6YkL+5zyvb2Jpv+ZvQjMfLFN/t9ESPQUTq?=
 =?us-ascii?Q?tYxMJrI3uAZCyXaenPbRD3itxkIXj/Q3q5ii08e//aFBk7viWLOb99VhHdey?=
 =?us-ascii?Q?tuYBMBjU8kTLWLUwrThCMhRLSGT59Mjx0gN0hSBwL91lC4zGjI2kb6THL2NG?=
 =?us-ascii?Q?SFwSALvuEIeREi12bcN8haS5l8MQUQm7NrkaoLMyGEEcGa2REL+TAQWOs4CW?=
 =?us-ascii?Q?0Orc8FAPyneUyemzGnYsUTSVgJly50V8rX7TuwK6kp+u0ysdDVSLOmLWcnGa?=
 =?us-ascii?Q?aoZFFiRxAYbpsL7DFi8vDyBJ0oY/ckqMCHbgfilgsB/FGt0EKouDVPS0GIaZ?=
 =?us-ascii?Q?IobO24BnO825Iv476iJCsjxu2r4DhAgd+wjWsKdCF9YwuVVKwMoqoL9THUFN?=
 =?us-ascii?Q?3w4HNK0NwUSa5+JsX6uJoUJPZv2SllSVMA5lPsTSV0C4h3n+i3xpaICMU7SJ?=
 =?us-ascii?Q?4zLLm3m/shyHjsusNGhdpxOd2EOuVQtuX+rojchG7uEcpklEyxpMaqopn59n?=
 =?us-ascii?Q?buiXMWgRQmBzviEfmhJXH2SsdrO1UK71gutBT3xu7jucvCbTBFFszqPzVSzi?=
 =?us-ascii?Q?/AFDmGkz65XzHYoH8jDaJinA3OVLqcH2EyHh5PKqeaUgNrw+93jMRk7ucjeR?=
 =?us-ascii?Q?4yEAnjPLDpQHNA4udzdy777UxTDxUyfqVHdtKLQ4StS3ipRK/jxndII7MK98?=
 =?us-ascii?Q?NAKp6OtQlVUzvsFPvZuaFoFuP5OW0302/7OZa//Ao+gYX0x8sH4lXN5AQirF?=
 =?us-ascii?Q?rG7FRUg1PgAKfQFuksyXlG9sP2S4UtpUsbF+vyDcR/Wq8KrAeArZOgQZfjll?=
 =?us-ascii?Q?0A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <84DFA3128ED9F04599972B1B01725F1A@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5iXRwqCrZi4/+fOsRdvX9P/42uPDB01iPacmkwzks/h424g1jfWCrFnHSDp2EvtL3cLPnMM0cFHCbyRtlFoYJ4xdt5sUCjU4uef7qlXZcLE7R+LUX/B9vQoLCvQMNy+sPq1KB1Nqp36kUCNTacDOONUDv8qgJi/QgyQ8MrSTRvGMC7Lhp3VrqY+fqohmYpEOanPhWhKkcgbfPKH15hI7eYArxrTPXhYXLCnz4kbehDruAM0RpNaPI7D4xecrDxiWAG3jYSOjhKmtexPq4kwvT4jOVe7Kal1xNb3VEYlp5xfYPyBe8TOW9EucHl0jgGOixs1I6fExS0qmnTgWAKOM1kRWR68JgM0/qVPpsdrW7eR8mwy6zg2d5exvFjPS1XSlboejwS8psZmmkw7yI1+CGwK9S/9SbAMO+u/9AlN72q9IfhhjDErZVsVlc7dxY0AaLL3en9Era7t5nhoI2jzoYCXpUxIDSdY994HHo3H/praneL8q/+EzKQWmMgLLPRDOaoNq/hVELZBHELC/nwm4ikpzy8f7zJUmoMPaRJCjDYBWlkhmjvvEGXPDDIceGp6WfKJ5cRvfSf50j3LYAW1++dBCOXmtQqWf80ygfDlqCMD/AaHU560MIdTCsKxWmqyyngI/6Wts9eVjqAdanH/2UCv0XJSMOQBrXWwNovwYQ68buCnzndW20O4cpQlfL6ymUY7iIrmB54TMfaugN0cU/exK2jiEZ0bSRTejAzSg0FZWcxiE/v1a9S1VSbz2l5fin/RzcdtvstYuqdVmq2K+fazNQ22GdstBQlH13FxAvEpJJCgv5WjwYUpuFm0qNuCsa3T1fMnwMwJUouGcm3X0apPJryXg9f6NXCLpeE1ao9g=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6eebc336-bc8e-4bb3-e726-08db15ba0826
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 16:21:34.7299
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tCPM1HaP5tnjAitSCqgTgmVEtJ/iT+d0Hb/P54Mvb/Y2+iBW9i6NVOpzQZ1+ChYwRFKxXpOHJh/RR41iFWk0BQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6385
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-23_10,2023-02-23_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302230134
X-Proofpoint-GUID: WyoMh673DRYvNEZ11HUmmcNMUc1bskKK
X-Proofpoint-ORIG-GUID: WyoMh673DRYvNEZ11HUmmcNMUc1bskKK
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Feb 23, 2023, at 10:19 AM, J. Bruce Fields <bfields@fieldses.org> wrot=
e:
>=20
> On Wed, Feb 22, 2023 at 01:20:43PM -0500, Jeff Layton wrote:
>> The READMEs for v4.0 and v4.1 are inconsistent here. For v4.0, the "all"
>> flag is supposed to run all of the "standard" tests. For v4.1 "all" is
>> documented to run all of the tests, but it actually doesn't since not
>> every tests has "all" in its FLAGS: field.
>>=20
>> I move that we change this. If I say that I want to run "all", then I
>> really do want to run _all_ of the tests. Ensure that every test has the
>> "all" flag set.
>=20
> In some (all?) cases where the "all" flag was left off, it was
> intentional.
>=20
> We try not to flag spec-compliant servers as failing, because people are
> sometimes a little careless about "fixing" failures that in their
> particular case really shouldn't be fixed.  But sometimes it's still
> useful to have a test that goes somewhat beyond the spec.
>=20
> There might be other ways to handle that kind of test, but it would need
> some more thought.

We could use a different name for "all" since it doesn't actually
run /all/ tests. Jeff suggested "standard", which seems sensible.

Also, we could add test categories specifically for particular server
implementations, if that's interesting to folks.


> --b.
>=20
>> Signed-off-by: Jeff Layton <jlayton@kernel.org>
>> ---
>> nfs4.1/testmod.py | 2 ++
>> 1 file changed, 2 insertions(+)
>>=20
>> If this is unacceptable, then an alternative could be to add a new
>> (similarly special-cased) "everything" flag.
>>=20
>> diff --git a/nfs4.1/testmod.py b/nfs4.1/testmod.py
>> index 11e759d673fd..7b3bac543084 100644
>> --- a/nfs4.1/testmod.py
>> +++ b/nfs4.1/testmod.py
>> @@ -386,6 +386,8 @@ def createtests(testdir):
>>     for t in tests:
>> ##         if not t.flags_list:
>> ##             raise RuntimeError("%s has no flags" % t.fullname)
>> +        if "all" not in t.flags_list:
>> +            t.flags_list.append("all")
>>         for f in t.flags_list:
>>             if f not in flag_dict:
>>                 flag_dict[f] =3D bit
>> --=20
>> 2.39.2

--
Chuck Lever