Message-ID: <ac05071a4a9dee6f249945d23e37812aa350fcc5.camel@kernel.org>
Subject: Re: [PATCH] NFSD: Protect against filesystem freezing
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc:     jack@suse.de, flole@flole.de
Date:   Mon, 06 Mar 2023 17:57:53 -0500
In-Reply-To: <167811742782.1909.380332356774647144.stgit@bazille.1015granger.net>
References: <167811742782.1909.380332356774647144.stgit@bazille.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-03-06 at 10:43 -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>=20
> Flole observes this WARNING on occasion:
>=20
> [1210423.486503] WARNING: CPU: 8 PID: 1524732 at fs/ext4/ext4_jbd2.c:75 e=
xt4_journal_check_start+0x68/0xb0
>=20
> Reported-by: <flole@flole.de>
> Suggested-by: Jan Kara <jack@suse.cz>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D217123
> Fixes: 73da852e3831 ("nfsd: use vfs_iter_read/write")
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  fs/nfsd/vfs.c |    2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 21d5209f6e04..ba34a31a7c70 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1104,7 +1104,9 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_f=
h *fhp, struct nfsd_file *nf,
>  	since =3D READ_ONCE(file->f_wb_err);
>  	if (verf)
>  		nfsd_copy_write_verifier(verf, nn);
> +	file_start_write(file);
>  	host_err =3D vfs_iter_write(file, &iter, &pos, flags);
> +	file_end_write(file);
>  	if (host_err < 0) {
>  		nfsd_reset_write_verifier(nn);
>  		trace_nfsd_writeverf_reset(nn, rqstp, host_err);
>=20
>=20

Reviewed-by: Jeff Layton <jlayton@kernel.org>