Message-ID: <cf2ad1349a19b472653c500cc7e287843a0cb8c7.camel@kernel.org>
Subject: Re: [PATCH v1 0/3] rq_pages bounds checking
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc:     viro@zeniv.linux.org.uk, dcritch@redhat.com, d.lesca@solinos.it
Date:   Sat, 18 Mar 2023 06:04:01 -0400
In-Reply-To: <167909365790.1672.13118429954916842449.stgit@klimt.1015granger.net>
References: <167909365790.1672.13118429954916842449.stgit@klimt.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-03-17 at 19:01 -0400, Chuck Lever wrote:
> A slightly modified take on Jeff's earlier patches, tested with
> both NFSv3 and NFSv4.1 via simple fault injection in
> svc_rqst_replace_page().
>=20
> In general I'm in favor of more rq_pages bounds checking by
> replacing direct modification of the rq_respages and rq_next_page
> fields with accessor functions.
>=20
> ---
>=20
> Chuck Lever (2):
>       SUNRPC: add bounds checking to svc_rqst_replace_page
>       NFSD: Watch for rq_pages bounds checking errors in nfsd_splice_acto=
r()
>=20
> Jeff Layton (1):
>       nfsd: don't replace page in rq_pages if it's a continuation of last=
 page
>=20
>=20
>  fs/nfsd/vfs.c                 | 15 +++++++++++++--
>  include/linux/sunrpc/svc.h    |  2 +-
>  include/trace/events/sunrpc.h | 25 +++++++++++++++++++++++++
>  net/sunrpc/svc.c              | 15 ++++++++++++++-
>  4 files changed, 53 insertions(+), 4 deletions(-)
>=20
> --
> Chuck Lever
>=20

Looks good, Chuck, thanks. You can add this to the last two:

Reviewed-by: Jeff Layton <jlayton@kernel.org>