Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6067486rwl; Wed, 22 Mar 2023 06:12:47 -0700 (PDT) X-Google-Smtp-Source: AK7set+lOQJtpWnL1S/9mZ7krkYY4dHF+Az+3JWMPnJr2JCGrycRsRRqzMV4H+KY/jTPuyGnlBmz X-Received: by 2002:a05:6a20:7a04:b0:da:adbf:7b96 with SMTP id t4-20020a056a207a0400b000daadbf7b96mr4440432pzh.21.1679490766736; Wed, 22 Mar 2023 06:12:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679490766; cv=none; d=google.com; s=arc-20160816; b=Q55AM2zD02YDAWE4clExzIGZyZiTFFY/T2baqlN8PLUZdqYXaAaPpQ54SD4ds1tbC3 nbcH6MWDb1yFsoQcr1dfAGF0m3eSZjkyCd7ngtmTFv5agLytpfnRMFv4EAWHU5QliiLe Aj1VMBgiIWDhLfbRTVzlTYeTiJpizoB533/S5ZTzAeMErqkpjDf32D2zlPxzQB+Li7cX HW6aWJnxQZ4/vYC5NXsN0N1HMYBRbs2wlmbllH4O5pIwdxf3DxExjMx9f42XV/RsEaA3 /T9BdDB1+02MBMZ/K2LW9iCUQNMH6OFhnR7by4DmiWSY7R8kQle5EmcYc2WbtNqETQ1b 9IiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=OgqnJyMoSlwpApjnjq5FXvCo3gtvaNVn/rTRRodDgl4=; b=kxCYrfRqSNZlzjHEjqkR5Gb2p1TAQJy7tdWXo+7/74T4OGRn8dRgyT69j5IWdOinbH f+x4eSy7Lfkv1NsNUwksG8ge228DhcwA17bijXbMm8iTatxN6j9sDGHTpE0mbNC7D6So mJ8qsgJQtb8fiS2a65Sl6XqJ34t2UZNgJ5jRVc6XMt8li8ERnXSMB/E2KjDqe/bbfaDr 1MAjXLxZbOK3z48oSqVmWuTuvpp28xj3QWqOq/hcTEzLLFdhQjZRfdnObqcfegchFTSH QBmqDEKbVvZPPNX2v0SzU/6f4C+IbRZZZPYt0VyRblGS22Va6Nk9xB/utMenrsaopOMA kuMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Q8k3OA2o; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a656086000000b00502e5477334si16162951pgu.687.2023.03.22.06.12.28; Wed, 22 Mar 2023 06:12:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Q8k3OA2o; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbjCVNLC (ORCPT + 99 others); Wed, 22 Mar 2023 09:11:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230039AbjCVNLB (ORCPT ); Wed, 22 Mar 2023 09:11:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 060C862304 for ; Wed, 22 Mar 2023 06:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679490614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgqnJyMoSlwpApjnjq5FXvCo3gtvaNVn/rTRRodDgl4=; b=Q8k3OA2oOru21+s3zAJPwysnoxTOnm51eqH37ZnMPDak2uRQ7fHGYFSy/g6JD6tmX8vrO4 xMlezEdhwgxQr/0FblMzClHJ7suD+oYEjYFwwAQS0arpc0u0zrrT0Ky426MMY9nOiDBKnq KWa/DyVAfA9XRU7GsWJVZaNC0kZ/UrQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-369-x_WLiTFRNCqXFBDIY2WLhQ-1; Wed, 22 Mar 2023 09:10:10 -0400 X-MC-Unique: x_WLiTFRNCqXFBDIY2WLhQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E1D2886467; Wed, 22 Mar 2023 13:10:09 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5195642C827; Wed, 22 Mar 2023 13:10:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <9C741BDB-31B0-460C-8FE7-F1C9B49002D5@hammerspace.com> References: <9C741BDB-31B0-460C-8FE7-F1C9B49002D5@hammerspace.com> <8F8B62FD-0F16-4383-BB34-97E850DAA7AF@hammerspace.com> <3DFBF27C-A62B-4AFE-87FD-3DF53FC39E8E@hammerspace.com> <20230316152618.711970-1-dhowells@redhat.com> <20230316152618.711970-28-dhowells@redhat.com> <754534.1678983891@warthog.procyon.org.uk> <809995.1678990010@warthog.procyon.org.uk> To: Trond Myklebust Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Viro , Christoph Hellwig , Jens Axboe , Jeffrey Layton , Christian Brauner , Linus Torvalds , "netdev@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Anna Schumaker , Charles Edward Lever , "linux-nfs@vger.kernel.org" Subject: Re: [RFC PATCH 27/28] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3243439.1679490606.1@warthog.procyon.org.uk> Date: Wed, 22 Mar 2023 13:10:06 +0000 Message-ID: <3243440.1679490606@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Trond Myklebust wrote: > Add an enum iter_type for ITER_ITER ? :-) Actually, that might not be such a bad idea, now that I've pondered on it some more. Give it an array of iterators and add a flag to each iterator to say if it can be spliced from or not. Once ITER_PIPE is killed off, advancing and reverting over it should be pretty straightforward - though each iterator would also need to keep track of how big it started off as in order that it can be reverted over. David