Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Frank Filz" <ffilzlnx@mindspring.com>
To:     "'NeilBrown'" <neilb@suse.de>,
        "'Bruce Fields'" <bfields@fieldses.org>,
        "'Jeff Layton'" <jlayton@kernel.org>
Cc:     "'Linux NFS Mailing List'" <linux-nfs@vger.kernel.org>
References: <167996453785.8106.14290228013263156210@noble.neil.brown.name>
In-Reply-To: <167996453785.8106.14290228013263156210@noble.neil.brown.name>
Subject: RE: [PATCH pynfs] rpc.py: Don't try to subscript an exception.
Date:   Tue, 28 Mar 2023 08:25:27 -0700
Message-ID: <011501d96189$86f2e760$94d8b620$@mindspring.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGzsPtoPu+eDxk3wRxvo/A2s6C0fK9bsOMg
Content-Language: en-us
Precedence: bulk

Thanks. I have this patch in my repo and keep not getting around to =
submitting it.

Frank

> -----Original Message-----
> From: NeilBrown [mailto:neilb@suse.de]
> Sent: Monday, March 27, 2023 5:49 PM
> To: Bruce Fields <bfields@fieldses.org>; Jeff Layton =
<jlayton@kernel.org>
> Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
> Subject: [PATCH pynfs] rpc.py: Don't try to subscript an exception.
>=20
>=20
> As far as I can tell python3 has never supported subscripting of =
exceptions.
> So don't try to...
>=20
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>  nfs4.0/lib/rpc/rpc.py | 2 +-
>  rpc/rpc.py            | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/nfs4.0/lib/rpc/rpc.py b/nfs4.0/lib/rpc/rpc.py index
> 24a7fc72eff0..585db3551f73 100644
> --- a/nfs4.0/lib/rpc/rpc.py
> +++ b/nfs4.0/lib/rpc/rpc.py
> @@ -227,7 +227,7 @@ class RPCClient(object):
>                  sock.bind(('', port))
>                  return
>              except socket.error as why:
> -                if why[0] =3D=3D errno.EADDRINUSE:
> +                if why.errno =3D=3D errno.EADDRINUSE:
>                      port +=3D 1
>                  else:
>                      print("Could not use low port") diff --git =
a/rpc/rpc.py b/rpc/rpc.py
> index 1fe285aa2b5b..814de4e08bc9 100644
> --- a/rpc/rpc.py
> +++ b/rpc/rpc.py
> @@ -846,7 +846,7 @@ class ConnectionHandler(object):
>                  s.bind(('', using))
>                  return
>              except socket.error as why:
> -                if why[0] =3D=3D errno.EADDRINUSE:
> +                if why.errno =3D=3D errno.EADDRINUSE:
>                      using +=3D 1
>                      if port < 1024 <=3D using:
>                          # If we ask for a secure port, make sure we =
don't
> --
> 2.40.0