Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1717961rwl; Thu, 30 Mar 2023 00:04:15 -0700 (PDT) X-Google-Smtp-Source: AKy350ZIAZ/Sb2Xj4xUyiy3zkZ2lmUc8Qq5GZaM0wr0GK7iNFPJnqefMluWSVkUI8cwzHuUlHdq0 X-Received: by 2002:a17:90b:1b48:b0:23d:2532:ae34 with SMTP id nv8-20020a17090b1b4800b0023d2532ae34mr4939768pjb.2.1680159855047; Thu, 30 Mar 2023 00:04:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680159854; cv=none; d=google.com; s=arc-20160816; b=jrkE2Snc6O452u/pJ43uWpbymYYjBnetrqbJdXzcub2pWPpL0AykpbiKvAkOnq44bt 56lmQZ38uCcikf+BmyqfC0AfPn0h/rPqSLK/OIzjnTOpNKEb5uf3y3nTTJlSZnDnGLqf b8//Jw3M8/XKC8rt25beS1LFbmza8ZLPmg/QBWw2Oumr4AWVqPWS3nDvCYSfmhg5hmYh PdrhLUimWy9oSPRYIg5U7T0wSOeu5rsplqEaeV3CsMOAIWRCC3VZMLG0UnlZ1CqPNM8l NXzYKen4pXhMkH3/3/Q7IaH+QJ/9kZbt9j24V6kWWsBRH9yXy+PpYlibm1qNRdNwfnMx TDKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6kJM+mtrKs5CDZD9th9QE/lzvjLKq6OXQ5UTa/RCjQQ=; b=SwitrlIcaYz0cQmMPRuipUfryxzIIdDYLPUYPcjqED8dhXgfliGGRCIV+gXC52F6k5 33WjbULLAenVVI7VX2ewJodFE0V38iVo5ogsHmFgr9m8vXG24YcfWl9mK6n6arNO91+U zxzzILHC6BxWnhJdLviMEy2uY85IiCsIJffnH1U3CSLTgT1HhJpUpZAy+i29YeFrG/q8 oPk2U3Y6gX+OWxpoTHCaw3muFeh/ME7WWWEh3v86+igMlIBDRqRrDK2vHo5Z3R+FO9w3 N5+TYAdCbpiRE40nC10F3t0yvXlijqjOkRMsHDZFmlysBmPJK1e3G2XrS4Zt/ayZa5EY +AeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pzvXgy54; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a17090a49c800b0023fc0a57969si531989pjm.108.2023.03.30.00.03.52; Thu, 30 Mar 2023 00:04:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pzvXgy54; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbjC3G5Q (ORCPT + 99 others); Thu, 30 Mar 2023 02:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbjC3G5O (ORCPT ); Thu, 30 Mar 2023 02:57:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A1B465B7; Wed, 29 Mar 2023 23:57:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C8CD7B82600; Thu, 30 Mar 2023 06:57:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38B54C433EF; Thu, 30 Mar 2023 06:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680159429; bh=dRxto1nKOBv47Hgtnxtl36FhSOrP9QavSk0iDsliXGk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pzvXgy54cpqTFF1OzYug+6fWtlmk7w3vi8ZPTWfSO5aqM06+zhuEpJowQ4PjFF576 BvvZYWv4gPtoKeg36pw9+5G9LXf/2i6liGdcDKLpkaaWlfPXxTO16yCYSEegweYl1S Nqxg1bd79bYgaINS/UY+6GgDNIH9fWcrPw1dGjBhhzEOFLJyB2Y9eu2Ytqpgch4SFY kPBhCm/I5QvXEO4EzCUQyIWrLLZGx64O8DVocq/91Ou/U8yhXkdv2aqoV2bhY+sVod hOHG5LjD3aYLuZda3gtkvLlcieDjJlAW6uzZYm/U/EkiaB1NQ2clhNSLNWxT08k6MU uK4SXFjwKIIYQ== Date: Thu, 30 Mar 2023 08:57:03 +0200 From: Christian Brauner To: Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Christian Brauner Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2] nfs: use vfs setgid helper Message-ID: <20230330-nifty-radiator-fffd92d2b2fa@brauner> X-Developer-Signature: v=1; a=openpgp-sha256; l=837; i=brauner@kernel.org; h=from:subject:message-id; bh=yNyLgGjEDjRE400I25HPN4HDcYoV0hPW9uuPEycb/yU=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaSoGlX/vN1e7ViiwuXzxm2/t8SSXb8+9tufFT+R15Jna13v npzRUcLCIMbFICumyOLQbhIut5ynYrNRpgbMHFYmkCEMXJwCMJF/Kxj+6a2wrU24n5jM1WEy97dLWP 2mA/IPuIrDjkTblU49lTrFg+G7+4klAXcPcLgHGB77fp0xTFtavO3344W/n9/VETrV684HAA== X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 References: <20230313-fs-nfs-setgid-v2-1-9a59f436cfc0@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230313-fs-nfs-setgid-v2-1-9a59f436cfc0@kernel.org> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, 14 Mar 2023 12:51:10 +0100, Christian Brauner wrote: > We've aligned setgid behavior over multiple kernel releases. The details > can be found in the following two merge messages: > cf619f891971 ("Merge tag 'fs.ovl.setgid.v6.2') > 426b4ca2d6a5 ("Merge tag 'fs.setgid.v6.0') > Consistent setgid stripping behavior is now encapsulated in the > setattr_should_drop_sgid() helper which is used by all filesystems that > strip setgid bits outside of vfs proper. Switch nfs to rely on this > helper as well. Without this patch the setgid stripping tests in > xfstests will fail. > > [...] So I've picked this up now, tree: git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git branch: fs.misc [1/1] nfs: use vfs setgid helper commit: 4f704d9a8352f5c0a8fcdb6213b934630342bd44 Thanks! Christian