Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1876182rwl; Thu, 30 Mar 2023 02:46:16 -0700 (PDT) X-Google-Smtp-Source: AKy350aBoBOBX7v9r7rlBIGhjLQawhb0cVWONCDoMCDDMLL5UTVtZu1xGk700U03ABJ/o/Elpacg X-Received: by 2002:a17:906:aad0:b0:932:365a:969a with SMTP id kt16-20020a170906aad000b00932365a969amr24087752ejb.8.1680169576653; Thu, 30 Mar 2023 02:46:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680169576; cv=none; d=google.com; s=arc-20160816; b=UqZ9XqcYbCJvDwrKBvss5mhYZQLMwWx0rCbXh6A7I3YGZOm9F990v3lTqmuv5D93gP Ml0dfKAUNPJYohN84fZMjasETZtIJyrmXWFN3wzKNIV7pFGmL9kRH8niI3V/lDaXAAem pla1L0k3PROdGdX7AngnZmolOc8ntaHCLvPUIc93JuarZGsfmyVz1Z7frk1jPZY6fQCQ FJmO04j1ZxXCTDzYYVyejMQTVzGJLgiJGV2E9fiElHD245LbvrHTSdDfIga//GC+oYBA CDY1NWKKpC46wu5x1Q7Rfiygtg0Kd4zS8rXxNVNAQzGg3j6t8XGL5rFtfIKj9uDIOx8j c/CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=mdeKPljJ04L5Zu/e3M2HbmrNI2/PIT36ixWTFqAG+bc=; b=FqycAyviJyS2p8BN+bQzzsjM9GgDwkW0L9jN9SLUbeC2kNsCBSiSjhgzytsDhKGWuY YWp3ciBuP1NWF8Z7n8YsuZMiKZ2tlxDjfqMlgFFv/82nKAvtS9dIni9pgID6Gr1zQvbu uoGuCszqu9pYfkEkxRgrOAmhA9osMWFnpz0dRCKERn+owkaPcKAcF3rMrw1NEc2hKF3t wD3Jf0J+hdpXV6TdI/Duy31C20BCeO+TWWGTAlXbaemT/fduPWKCcJk9YQRQ9DYACv3j PjwRSMi5kIVbxMzr/spMG1kh/12pisFinLfp22RwSI0Adgs8L+yX5hd4dHVAUQVjRbkI nvBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NARIvNOz; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v9-20020a170906338900b0093346a7ad4esi28974592eja.1005.2023.03.30.02.45.47; Thu, 30 Mar 2023 02:46:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NARIvNOz; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbjC3JmY (ORCPT + 99 others); Thu, 30 Mar 2023 05:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjC3JmW (ORCPT ); Thu, 30 Mar 2023 05:42:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B96317AB4 for ; Thu, 30 Mar 2023 02:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680169291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mdeKPljJ04L5Zu/e3M2HbmrNI2/PIT36ixWTFqAG+bc=; b=NARIvNOztsRzqg3UGR8KcVVu1ntw4cKRq1LfV0hwMM1x/Def0KxJo+TJnWdu85hUA9s2uJ lX94Dy6aMg/79UFGtbufZDhPAb6+zXpgNz5DNBs3LeA6A1EAmP6L+m4acIFB1LKlzVckEf f+tkqWyna3fHiuwN0cnPLE5DcWujcW8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-29-iTWDHOayP72Oh1RXlrE68w-1; Thu, 30 Mar 2023 05:41:21 -0400 X-MC-Unique: iTWDHOayP72Oh1RXlrE68w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3986185A792; Thu, 30 Mar 2023 09:41:19 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id D4032492C3E; Thu, 30 Mar 2023 09:41:17 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> References: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-41-dhowells@redhat.com> To: Chuck Lever III Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Linus Torvalds , "open list:NETWORKING [GENERAL]" , linux-fsdevel , Linux Kernel Mailing List , Linux Memory Management List , Trond Myklebust , Anna Schumaker , Linux NFS Mailing List Subject: Re: [RFC PATCH v2 40/48] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <778589.1680169277.1@warthog.procyon.org.uk> Date: Thu, 30 Mar 2023 10:41:17 +0100 Message-ID: <778590.1680169277@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Chuck Lever III wrote: > > + if (ret > 0) > > + *sentp = ret; Should that be: *sentp = ret - sizeof(marker); David