Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Chuck Lever III" <chuck.lever@oracle.com>
Cc:     "Dai Ngo" <dai.ngo@oracle.com>,
        "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSD: callback request does not use correct credential
 for AUTH_SYS
In-reply-to: <CF4DFCD5-332D-4147-AA8A-F81FAB96AFA4@oracle.com>
References: <1680380528-22306-1-git-send-email-dai.ngo@oracle.com>,
 <CF4DFCD5-332D-4147-AA8A-F81FAB96AFA4@oracle.com>
Date:   Mon, 03 Apr 2023 09:53:15 +1000
Message-id: <168047959550.14629.15820193625931684256@noble.neil.brown.name>
Precedence: bulk

On Mon, 03 Apr 2023, Chuck Lever III wrote:
>=20
> > On Apr 1, 2023, at 4:22 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
> >=20
> > Currently callback request does not use the credential specified in
> > CREATE_SESSION if the security flavor for the back channel is AUTH_SYS.
> >=20
> > Problem was discovered by pynfs 4.1 DELEG5 and DELEG7 test with error:
> > DELEG5   st_delegation.testCBSecParms     : FAILURE
> >           expected callback with uid, gid =3D=3D 17, 19, got 0, 0
> >=20
> > Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>=20
> Does
>=20
> Fixes: 8276c902bbe9 ("SUNRPC: remove uid and gid from struct auth_cred")
>=20
> sound OK to everyone?

Yes, that looks right to me.  Thanks.

NeilBrown

>=20
>=20
> > ---
> > fs/nfsd/nfs4callback.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> > index 2a815f5a52c4..4039ffcf90ba 100644
> > --- a/fs/nfsd/nfs4callback.c
> > +++ b/fs/nfsd/nfs4callback.c
> > @@ -946,8 +946,8 @@ static const struct cred *get_backchannel_cred(struct=
 nfs4_client *clp, struct r
> > if (!kcred)
> > return NULL;
> >=20
> > - kcred->uid =3D ses->se_cb_sec.uid;
> > - kcred->gid =3D ses->se_cb_sec.gid;
> > + kcred->fsuid =3D ses->se_cb_sec.uid;
> > + kcred->fsgid =3D ses->se_cb_sec.gid;
> > return kcred;
> > }
> > }
> > --=20
> > 2.9.5
> >=20
>=20
> --
> Chuck Lever
>=20
>=20
>=20