Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3661346d-da08-927e-fd76-20bdf6587c11@redhat.com>
Date:   Wed, 5 Apr 2023 12:28:54 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] [nfs/nfs-utils] rpcdebug: avoid buffer underflow if
 read() returns 0
Content-Language: en-US
To:     Zhi Li <yieli@redhat.com>, linux-nfs@vger.kernel.org
References: <20230309062025.731671-1-yieli@redhat.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20230309062025.731671-1-yieli@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/9/23 1:20 AM, Zhi Li wrote:
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2176740
> 
> Signed-off-by: Zhi Li <yieli@redhat.com>
Committed... (tag: nfs-utils-2-6-3-rc7)

steved.
> ---
>   tools/rpcdebug/rpcdebug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
> index 68206cc5..ec05179e 100644
> --- a/tools/rpcdebug/rpcdebug.c
> +++ b/tools/rpcdebug/rpcdebug.c
> @@ -257,7 +257,7 @@ get_flags(char *module)
>   		perror(filename);
>   		exit(1);
>   	}
> -	if ((len = read(sysfd, buffer, sizeof(buffer))) < 0) {
> +	if ((len = read(sysfd, buffer, sizeof(buffer))) <= 0) {
>   		perror("read");
>   		exit(1);
>   	}