Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Apr 2023 14:50:44 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     Steve Dickson <steved@redhat.com>
Cc:     linux-nfs <linux-nfs@vger.kernel.org>, david <david@sigma-star.at>,
        david oberhollenzer <david.oberhollenzer@sigma-star.at>,
        luis turcitu <luis.turcitu@appsbroker.com>,
        david young <david.young@appsbroker.com>,
        trond myklebust <trond.myklebust@hammerspace.com>,
        anna schumaker <anna.schumaker@netapp.com>,
        chris chilvers <chris.chilvers@appsbroker.com>
Message-ID: <487745654.155712.1681822244964.JavaMail.zimbra@nod.at>
In-Reply-To: <c43a2268-3a12-2eeb-9cb2-6b01f5a225ef@redhat.com>
References: <20230404111308.23465-1-richard@nod.at> <c43a2268-3a12-2eeb-9cb2-6b01f5a225ef@redhat.com>
Subject: Re: [PATCH 0/2 v2 RESEND] nfs-utils: Improving NFS re-export wrt.
 crossmnt
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: nfs-utils: Improving NFS re-export wrt. crossmnt
Thread-Index: Rjlx6436CLEYg43551XLZfeZdbBvTw==
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "Steve Dickson" <steved@redhat.com>
> My apologies for taking so long to get to this!

No problem. :-)

> These patch does not apply cleanly on Chuck's TLS patches,
> not something you could have voided and the fix
> is minor...  But!
> 
> Then the first patch does not compile without
> the second patch due to a missing header file.
> 
> When the second patch is applied the compile
> breaks in exportd code:
>    make[2]: *** No rule to make target
> '../support/reexport/libreexport.a', needed by 'exportd'.  Stop.
> 
> The first patch is way to big for debugging and reading... IMO.
> 
> Maybe the exportd, exportfs, and mount changes be put
> in their own patches and maybe the reexport command
> can be separated out from the rest of support/ changes
> although that might be more difficult.
> 
> Not clear how you can break up the second patch other
> than moving reexport_backend.h into the first patch
> so it compiles...
> 
> I just committed Chuck's TLS patch (tag: nfs-utils-2-6-3-rc8)
> So if you could rebase your patches to the head of my repo
> that would great, with the above changes.

I just rebased the whole series and spitted into multiple patches.
Every single patch builds now, sorry for that.
 
> I'll be very motivate get these changes in for the
> upcoming virtual bakeathon starting a week from
> Monday (Apr 24). The detail are here [1]...
> 
> I'm hopeful you will be attending and setting a server
> for us to test against.

I'll try hard to attend! :-)

Thanks,
//richard