Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3de8618e1b8d5c06fc1c14cfb4ab687ca63714f.camel@kernel.org>
Subject: Re: [PATCH v2] NFSD: Fix problem of COMMIT and NFS4ERR_DELAY in
 infinite loop
From:   Jeff Layton <jlayton@kernel.org>
To:     Dai Ngo <dai.ngo@oracle.com>, chuck.lever@oracle.com
Cc:     linux-nfs@vger.kernel.org
Date:   Wed, 19 Apr 2023 14:03:00 -0400
In-Reply-To: <1681926798-13866-1-git-send-email-dai.ngo@oracle.com>
References: <1681926798-13866-1-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-04-19 at 10:53 -0700, Dai Ngo wrote:
> The following request sequence to the same file causes the NFS client and
> server getting into an infinite loop with COMMIT and NFS4ERR_DELAY:
>=20
> OPEN
> REMOVE
> WRITE
> COMMIT
>=20
> Problem reported by recall11, recall12, recall14, recall20, recall22,
> recall40, recall42, recall48, recall50 of nfstest suite.
>=20
> This patch restores the handling of race condition in nfsd_file_do_acquir=
e
> with unlink to that prior of the regression.
>=20
> Fixes: ac3a2585f018 ("nfsd: rework refcounting in filecache")
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
>  fs/nfsd/filecache.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> V2: rebase with nfsd-next
>=20
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index f40d8f3b35a4..ee9c923192e0 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -1099,8 +1099,6 @@ nfsd_file_do_acquire(struct svc_rqst *rqstp, struct=
 svc_fh *fhp,
>  	 * then unhash.
>  	 */
>  	if (status !=3D nfs_ok || inode->i_nlink =3D=3D 0)
> -		status =3D nfserr_jukebox;
> -	if (status !=3D nfs_ok)
>  		nfsd_file_unhash(nf);
>  	clear_and_wake_up_bit(NFSD_FILE_PENDING, &nf->nf_flags);
>  	if (status =3D=3D nfs_ok)

Reviewed-by: Jeff Layton <jlayton@kernel.org>