Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>, Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2] NFSD: Fix problem of COMMIT and NFS4ERR_DELAY in
 infinite loop
Thread-Topic: [PATCH v2] NFSD: Fix problem of COMMIT and NFS4ERR_DELAY in
 infinite loop
Thread-Index: AQHZcufaZPKSt4/vs0yxHY08n3/2BK8y7IsAgAAQHAA=
Date:   Wed, 19 Apr 2023 19:00:51 +0000
Message-ID: <9DEF3C9A-9B8B-49C2-83A1-4F3E3E4CB725@oracle.com>
References: <1681926798-13866-1-git-send-email-dai.ngo@oracle.com>
 <b3de8618e1b8d5c06fc1c14cfb4ab687ca63714f.camel@kernel.org>
In-Reply-To: <b3de8618e1b8d5c06fc1c14cfb4ab687ca63714f.camel@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DggA2SE914ZkL/1tWYq0i5j9LHSMvYSw+2/nknlSv0SirRPFeCJFcs3+ZJ/0?=
 =?us-ascii?Q?UIv8AnPs2uHaO0zrMSgmyMFt/wN556TBngciERhzXr/7b5ZRcdf/yD7FoZAd?=
 =?us-ascii?Q?MBoVH9MgtQ0YRtBdurL8NYnE6YPGhs0F+EARpRpC96+BXidl6uWekbSjqVp0?=
 =?us-ascii?Q?bpTEpYh9eanoKIPCn2NZzQCrUm+Uzi/Vm0SW92IYcozdsry7rV/YRsgRrWLD?=
 =?us-ascii?Q?+vUWuLGPCVBKdlNZPw7/wMd767lV6eppy8ccvsAUdD+4i9vrpFcptUE1UaPT?=
 =?us-ascii?Q?jfTHYX/+uZMHT+L78+nspJ72gfoJNQj/brL7BiRaFur3swIJQCL50JAs/zGD?=
 =?us-ascii?Q?zgImuppuAAfFiGJSYlJGk3nF1JAa1Nvo0VtddwNsDJsqMYKmgu6i8XebLUr9?=
 =?us-ascii?Q?Rv4Z17hX+rl9WwE/VoF5SMZdmkv2eCqFyMGdrpV2txPDmIdkpiWKMeOhX68o?=
 =?us-ascii?Q?AboGQ7Yd2mFBTXH8SfJ7uLdZ2p3GcHHfscn/Nza0MDYiIToTb+6dMyxjms8K?=
 =?us-ascii?Q?sI4v+WZQHId/hwx3Yg9ex+wvFfLXMIC/Jim5Zc962OeIrPDgrOG6YOe9NISw?=
 =?us-ascii?Q?HFe/k0RHG3SkDm/Y7V1+ocaOSlHbNvHMuZhGed1apTzfpO85rcdxpw76FFF4?=
 =?us-ascii?Q?ipVHlwRbSV7xjX2uclBxy8o57krEYE4jp/q/ZwrLrZwIAUFRJPPD5tD/mp/D?=
 =?us-ascii?Q?jpRJxTWe7PqAUckl8n0/V2R2dwSZRSHb5OZZlBZMi9MtpbIRgSsp9bCrqc0z?=
 =?us-ascii?Q?/3top6LITHwwwwzeyKq9eKt6L1QmtlF84I5R91rlXczqT1JNfoZdVbDcMXZ4?=
 =?us-ascii?Q?I/2o7jIeb45/Yh8gZCyT5l85ljh3bvO2yMAaoIOlbBNeLKzCAN2IOUqjedQA?=
 =?us-ascii?Q?4ghpMYkCDC3rlqhDLMJzb+ui8YX8r6eGEzl8XFZjhiWxM0dqoCG2pbn8WzRk?=
 =?us-ascii?Q?HsgUg4QGNjVfDl4vzIIoViuyM8y17TAIDvyZagKYzGRaaOtLT6839CJwePPR?=
 =?us-ascii?Q?2vmNn65VgESNsIeroVHfWe4lZ/cnujubxnUJhAI3RzU0iNiCUYTh3fmNqbOU?=
 =?us-ascii?Q?oZ/S4v94Ztx3uV7FCVEu/R4IFgQ0nlnnQ+wi2JEItOhDM9yAf/Ex77h3uw28?=
 =?us-ascii?Q?G9irwfhu6yHheIU0vaV1Y0ZZiPZfAVN7X0iJ6vpOvtNttdS2oR1TL3kccFY5?=
 =?us-ascii?Q?6VhK96XqcOOyZhla+K5yTqn8ru1Setm7+u8laZlsEBqlHEh2Hv/R+PHNyclj?=
 =?us-ascii?Q?RA5LAJETtNsKMbnuYwy5/nXzJL2whps6U4BMTlK5zh/9ifuzFKfXxeouMVrg?=
 =?us-ascii?Q?8y0VgeDj3nj+QnAsTKwl11186jyieneaN8jJpmHsHwdTu/aQ6+1CwC+Hx40R?=
 =?us-ascii?Q?L+Zfd9XXCaBo4omJ6CTvhWSc1JarG226P/61MWum45rJjXvjYcQ/hdqvYhKL?=
 =?us-ascii?Q?9YHWRW9vvvPZ83f0u4ERGW5Vwc0+8ViLCk9syJ32RLOmwH5azO3u/yzr3D8V?=
 =?us-ascii?Q?OwKQ054ju4Uyoc9BiR26HlC6dY8hIxv67uQcTfBgI1Z128z14WtbDj/JKIpV?=
 =?us-ascii?Q?Giayjw8kYpwXl1+f4msL3qZcyGqWyNbUfaO8M0LF2nzoRxwMXDeCMUnddQ/k?=
 =?us-ascii?Q?/A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FD4CB74DF324654B99CAE273EBA787D7@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /OJhjm7OcuvU+BkcDfDMT7HXVc7IsH94aqXu7uvgvDVX4FaTWhfk2zpNTZqHttWcD5Z7P0/SoCe7BIUn7xMzt6P68ipreCO6pCydp8HdTWJUwhTia+cAUqjM6bVGzJnrHDPvy8wqRCiTUkT8p54ypTyXEjMo8hsmBWtHAyaXoeLuWTVBIJPM/a4ULE0zXvo7MSiR+WEk2u6QLG19guQasRC7Ez/XekyAFe5V43MSJGAkgQ+cQ/Hfn1+fAHuPUkv7O81gfvUudms2AQP47bgspji8dWfOqMpjcUCq32E8Ogk4wQu+ngs/fLrKVnbDH3x44bNMMVPqoKhr69lTzEifPij3M+Mnia6I6RqDR9jFxWMzVxwY7VQmBqM409o/1T7mcenU7wb4/4o8h5I4ftzmswpqMQa7hlPV53M/3IBrekTlKDcIoiW0CRf2d5YlGX3tXnrjWIIiGt5m7tcIPZgqEuScCzNsXxSshtXCreKrRuvAq/vsQaP24BQM+Zj8kZdrvYOz5UTLWI3Pfc5b4trS5+P0mrAx/Qc1OdnSsZ0lHoaxYNdVyckIZVP3RHTE6lABsZWJAZfWNobvAdKuhO/H5N3sLqfV2/iA10GlzfYkTdnI1WTURlEI3ifOPDU/EAVEVqrF7171m/7Q1dk+vbVX0qC+Rt7czKJwdfBERfxLwtAv3MIYYffe97rXAqnr67i45eA9uQeQxtMLg8oTQ8UV8JTInAGT9vONvdLUYJi6vZsIe1BuUCslqtcNuU14yE2ptKrpAWdhCNBSyS2h/c7NTTBYqQdEjNu4G38j/EXY5o0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7e99fc5-ba6f-4086-27ea-08db4108656c
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2023 19:00:51.9607
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JtMhH/Mi6ghy+LuedwLeQ375bHsysscWkuCNBuindUz1SmsxDj9JFMKcQZ2VavmwGgw6w3j07eySl+WHnzFD2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5580
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-19_13,2023-04-18_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 bulkscore=0
 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304190167
X-Proofpoint-GUID: V-QZKVi0bwMnvWwqTA3r6IWsmpP4U2kw
X-Proofpoint-ORIG-GUID: V-QZKVi0bwMnvWwqTA3r6IWsmpP4U2kw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Apr 19, 2023, at 2:03 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> On Wed, 2023-04-19 at 10:53 -0700, Dai Ngo wrote:
>> The following request sequence to the same file causes the NFS client an=
d
>> server getting into an infinite loop with COMMIT and NFS4ERR_DELAY:
>>=20
>> OPEN
>> REMOVE
>> WRITE
>> COMMIT
>>=20
>> Problem reported by recall11, recall12, recall14, recall20, recall22,
>> recall40, recall42, recall48, recall50 of nfstest suite.
>>=20
>> This patch restores the handling of race condition in nfsd_file_do_acqui=
re
>> with unlink to that prior of the regression.
>>=20
>> Fixes: ac3a2585f018 ("nfsd: rework refcounting in filecache")
>> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>> ---
>> fs/nfsd/filecache.c | 2 --
>> 1 file changed, 2 deletions(-)
>>=20
>> V2: rebase with nfsd-next
>>=20
>> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
>> index f40d8f3b35a4..ee9c923192e0 100644
>> --- a/fs/nfsd/filecache.c
>> +++ b/fs/nfsd/filecache.c
>> @@ -1099,8 +1099,6 @@ nfsd_file_do_acquire(struct svc_rqst *rqstp, struc=
t svc_fh *fhp,
>>  * then unhash.
>>  */
>> if (status !=3D nfs_ok || inode->i_nlink =3D=3D 0)
>> - status =3D nfserr_jukebox;
>> - if (status !=3D nfs_ok)
>> nfsd_file_unhash(nf);
>> clear_and_wake_up_bit(NFSD_FILE_PENDING, &nf->nf_flags);
>> if (status =3D=3D nfs_ok)
>=20
> Reviewed-by: Jeff Layton <jlayton@kernel.org>

Thanks, applied to nfsd-next.


--
Chuck Lever