Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Benjamin Coddington" <bcodding@redhat.com>
Cc:     "Trond Myklebust" <trond.myklebust@hammerspace.com>,
        "Anna Schumaker" <anna@kernel.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Cleanup unused rpc_clnt variable
In-reply-to: <7b299fff0277489fd6f8a12d377fb3edc5fb3a80.1682007300.git.bcodding@redhat.com>
References: <7b299fff0277489fd6f8a12d377fb3edc5fb3a80.1682007300.git.bcodding@redhat.com>
Date:   Fri, 21 Apr 2023 07:51:49 +1000
Message-id: <168202750930.24821.8678139655016357466@noble.neil.brown.name>
Precedence: bulk

On Fri, 21 Apr 2023, Benjamin Coddington wrote:
> The root rpc_clnt is not used here, clean it up.

True.  The actions on rpc_clnt happen in nfs4_run_state_manager, not
here.  So this is not needed.  Thanks.

>=20
> Fixes: 4dc73c679114 ("NFSv4: keep state manager thread active if swap is en=
abled")
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>

Reviewed-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown


> ---
>  fs/nfs/nfs4state.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> index 2a0ca5c7f082..f8afd75e520d 100644
> --- a/fs/nfs/nfs4state.c
> +++ b/fs/nfs/nfs4state.c
> @@ -1205,10 +1205,6 @@ void nfs4_schedule_state_manager(struct nfs_client *=
clp)
>  {
>  	struct task_struct *task;
>  	char buf[INET6_ADDRSTRLEN + sizeof("-manager") + 1];
> -	struct rpc_clnt *cl =3D clp->cl_rpcclient;
> -
> -	while (cl !=3D cl->cl_parent)
> -		cl =3D cl->cl_parent;
> =20
>  	set_bit(NFS4CLNT_RUN_MANAGER, &clp->cl_state);
>  	if (test_and_set_bit(NFS4CLNT_MANAGER_AVAILABLE, &clp->cl_state) !=3D 0) {
> --=20
> 2.39.2
>=20
>=20