Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1682096307.git.bcodding@redhat.com>
In-Reply-To: <cover.1682096307.git.bcodding@redhat.com>
From:   Anna Schumaker <schumaker.anna@gmail.com>
Date:   Fri, 21 Apr 2023 13:37:45 -0400
Message-ID: <CAFX2JfnhRv53kSFs5s+QqwVmU2pQShWL_jQSTztMMFvv79=04A@mail.gmail.com>
Subject: Re: [PATCH 0/9 RFC v2] NFS sysfs scaffolding
To:     Benjamin Coddington <bcodding@redhat.com>
Cc:     linux-nfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ben,

On Fri, Apr 21, 2023 at 1:10=E2=80=AFPM Benjamin Coddington <bcodding@redha=
t.com> wrote:
>
> Here's another round of sysfs entries for each nfs_server, this time with=
 a
> single use-case: a "shutdown" toggle that causes the basic rpc_clnt(s) to
> immediately fail tasks with -EIO.  It works well for the non pNFS cases t=
o
> allow an unmount of a filesystem when the NFS server has gone away.
>
> I'm posting to gain potential NACKing, or to be redirected, or to serve a=
s
> fodder for discussion at LSF.
>
> I'm thinking I'd like to toggle v4.2 things like READ_PLUS in here next, =
or
> other module-level options that maybe would be useful per-mount.

I have a patch built on your v1 posting that implements this. I can
rebase on v2 (well, I guess it'll be v3 now) if you want to see it!

Anna

>
> Benjamin Coddington (9):
>   NFS: rename nfs_client_kset to nfs_kset
>   NFS: rename nfs_client_kobj to nfs_net_kobj
>   NFS: add superblock sysfs entries
>   NFS: Add sysfs links to sunrpc clients for nfs_clients
>   NFS: add a sysfs link to the lockd rpc_client
>   NFS: add a sysfs link to the acl rpc_client
>   NFS: add sysfs shutdown knob
>   NFS: Cleanup unused rpc_clnt variable
>   NFSv4: Clean up some shutdown loops
>
>  fs/lockd/clntlock.c         |   6 ++
>  fs/nfs/client.c             |  21 +++++
>  fs/nfs/nfs3client.c         |   4 +
>  fs/nfs/nfs4client.c         |   2 +
>  fs/nfs/nfs4proc.c           |   2 +-
>  fs/nfs/nfs4state.c          |   5 +-
>  fs/nfs/super.c              |   6 +-
>  fs/nfs/sysfs.c              | 148 +++++++++++++++++++++++++++++++++---
>  fs/nfs/sysfs.h              |   9 ++-
>  include/linux/lockd/bind.h  |   2 +
>  include/linux/nfs_fs_sb.h   |   3 +
>  include/linux/sunrpc/clnt.h |  11 ++-
>  net/sunrpc/clnt.c           |   5 ++
>  net/sunrpc/sysfs.h          |   7 --
>  14 files changed, 204 insertions(+), 27 deletions(-)
>
> --
> 2.39.2
>