Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Chuck Lever <cel@kernel.org>, Bernard Metzler <BMT@zurich.ibm.com>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC] RDMA/core: Store zero GIDs in some cases
Thread-Topic: [PATCH RFC] RDMA/core: Store zero GIDs in some cases
Thread-Index: AQHZeSvPGmUIQ02sEEOITmW0YGNWva9Au3SAgAAAroA=
Date:   Fri, 28 Apr 2023 13:42:24 +0000
Message-ID: <34E28C03-5D1A-4DAA-9B5B-D453F8C256BD@oracle.com>
References: <168261567323.5727.12145565111706096503.stgit@oracle-102.nfsv4bat.org>
 <ZEvMo4qkj9NSLXTA@ziepe.ca>
In-Reply-To: <ZEvMo4qkj9NSLXTA@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yTPUSnK2FDCQ86eE2n4TJRPCF0ZRAJGS1vAzJVQWFduVojtuYfijmHN671mn?=
 =?us-ascii?Q?H7uUe810OrCBiJbMFkexm4MuPrtOeu95dJYKBpyo0KM8Tg/bDyiH+mjKZJNn?=
 =?us-ascii?Q?SooxQPD7yi6iIUjwWaYJqI0aF7lhDtQpM9d3c47tZz9KZgSN6Zt9XiabFgp+?=
 =?us-ascii?Q?U0tMEhgetAEF2zCAGsEBaaxyvue9pjVLskQhv5sXvhbKg9m0HE7AXpZveday?=
 =?us-ascii?Q?nu9PUiFA4Lti7vfJhLO5uBeF8TwnUBedsg8FVjJOBF/rtk5n3ofkxG/WEi0y?=
 =?us-ascii?Q?uwIUAoTAbH/eDyw50o0NMEk0xR9IK8WMLuAXko6109a7TymYRbWQvkL63hEQ?=
 =?us-ascii?Q?TtzOw+vQ3E51/tNfxhStfhD8n283B6CFIvao+S063baXIVMIHeXQyz5jR1XK?=
 =?us-ascii?Q?4Ueb72LEaKztWXWYq6t2asbcf9HGRMpALqybSdDUZAGZdnmeYlltuUJ2ztOE?=
 =?us-ascii?Q?vy8YosUak+XhvlKnSaqTtWUhK6T99DHfX+OL22kRHRrrXcexl4b8lbjUBMyw?=
 =?us-ascii?Q?2oJfKCG/EzLpHUt9Un+dG0CUa5cFcpNnBMinDItnT2WGZ9xW+ZT4HsyulCp2?=
 =?us-ascii?Q?LLNo6wNjSTMgkn86w3RL+O8eVoZmNukS8rtPWvSuaVXlU+Cs7t5dCllUghFI?=
 =?us-ascii?Q?K7NLdtbtlRYVrUDzh4QrdwqEZlZ6r02qcMNkusKNeoDhe3gk9XxHcx/mXkoy?=
 =?us-ascii?Q?4e1ZiMetBCn2xMBe7LxW8TQ/L9P4Pcr24W4rPo6Ek4Gf7yPoWbgwKCKsDx4g?=
 =?us-ascii?Q?6dEyom8c/q0zaQQQnXNke13FohIMedSIZqCNdz9iq9F0d2PMacIQekT+61iM?=
 =?us-ascii?Q?32SF1HSjsE3P6GuJX4CdpebxFdEKq7DuwImEwm1fVexP8IZIt29fQxJtP7VM?=
 =?us-ascii?Q?MIquneH9/umMZltJ9sfFa/lCNHBbGsS7ojdeuZlChVZsdSEsqixuHVgoexFg?=
 =?us-ascii?Q?448r5JJX7X9fJgz6OrbCDuTsSx5a0HtRRUE+smhUhW2GmmOA0OmKda5Xy+hp?=
 =?us-ascii?Q?ytB2C+exIyGf91nREvEBbMhjUkDr9YmTGHCK3CpcfxX3rt2w5QXOfwByxV0/?=
 =?us-ascii?Q?Q8+brAsUU7vKEvDFQJ7ZQ1z+fAr3q7HFpd8krVIf7ds2/2Qc6ah89tkUwCSQ?=
 =?us-ascii?Q?XNj32Gn9UWq/9blU9t5WBsBHJMK87BMjcuvJCfK4XOutnQFzrEB69ohAYe3+?=
 =?us-ascii?Q?EbZ30PzEBVHTnZdkI90qW1vpiRJLX9zGvNrcqqQw0HWXO8nXvNj7iZSdbsf3?=
 =?us-ascii?Q?P1YGqaBMfF2trdbd5XcFhsrluT6eVP1OXvjqMAAy/M+hPHR7yK7GFLCQEQNp?=
 =?us-ascii?Q?VH9tANA36ByNU0RBYwSnaNCYi+blKuSyuVRkNPP43i2o2jlqxMHNQdRbAl/F?=
 =?us-ascii?Q?YpwQyhuooAeXZhitcoM/ZrKiM1cW7/U/llbI5pl9obCCM09+jE3nEOVgZbcJ?=
 =?us-ascii?Q?e0Du/t9dVvZ+jIjBcsO6M58XV1CsCpyGraDxWM0Mr5aTNwUXyKjBGTcj7kBM?=
 =?us-ascii?Q?ckazdUg3TxeqxamqRWPIb3PgLgCtS4SaPjOiI1rtxPQ4wYbK5AVw1dwMQ4GG?=
 =?us-ascii?Q?AdSrTMa65/cf0av3BUqjHICashbc8hdUmA8txgIvNEtB1fOpprRs29HXfj9X?=
 =?us-ascii?Q?fQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F0552437F1B5934293A81A6901FD2A81@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: aAiBxscZh+j8AA/9bnge/dJmPqKZrDdEzeJAACpX6wW3bHG2VpKgOjKicDTlYaFqmeHoS4KHGsTbdWLXAYpA2+TZvrsUM0PICv63VfVlavg3RlFIPStJ2wf/XAa2h8X0jwGd4UNJoLwG9Qq8OpEFlq9q0rUe9obZW6Iq6hgOi3IoF7EO3jMVSV1YNoXaFAuTGxEQVmhrlZgNTJnxkKXqkO6ErTjHwpV9Dfx298DDglOrQg9r9PUBOcnTpE50cAJCqXNspFoJkFjehbo31vXiIHKOGOOSNQLCMrAI6K3FJsy93Xvic0Ehx7Rfigr5Nhl9bm9mrGRHrsJBHtzHd7KPrxg7qefw15SbhSJg4Vka30dg1Ffsv9z7Xoq5pXnjIKwwJ7X5ILTSVaDWduLGmf/pkILAkdMIRlHs6XO0tVWFILAKSwEA6bVJplccJBVnFkayQPT/2bYhNLtxWrk3ZfxFxTqp/bIBaAPnwBA3vhCm2FSKrMzrIWvMRzJ2f+yS7eCYYLiKnwhu8HvgGeLK8fhShabLD5QMw0rBdgJwhUxhodaYwaUisCjUMX/OOP1DjQGWNj4dCPYb2YFqr6iw1zEqy9rFNTJFtnpwp9ADHHzfWhQOV6D5fwyO1HydPeET5uaWpSwhtHPZfjRZPiW43Ajz7XC8gDR4T9C/uqp/e2Df9+vOiIj+q2xsiT70ksJ50V+GwMF0ZmogsVSvLRwqwFSlBsHDcacwSR+VR7leWPrZgHK8YtbHW5t2wczAveAhTkReS0gyTj27dLlEd2D1D9Y5zSWKumZ2m6keKQCC2p0gV42DGpvMutjcYlusi/1zBCwzeXnlv5l5f3l80FrEONvnr4DevCxzFkm1rTiD6bO/qms=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa4fa17a-578b-4825-118f-08db47ee65f7
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 13:42:24.1170
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cYE3k4ER52z+VWkAMTd/mDVfdYpCFSVeTgQtgmNiBm/tYJ9OHf1VKHHDOMKusGED5ondATU1zK3mwCAImqAOwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR10MB7638
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-28_04,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304280111
X-Proofpoint-GUID: uYykEimchCLLet_Bj2Xj4KGIUrmirAAt
X-Proofpoint-ORIG-GUID: uYykEimchCLLet_Bj2Xj4KGIUrmirAAt
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Apr 28, 2023, at 9:39 AM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
>=20
> On Thu, Apr 27, 2023 at 01:14:43PM -0400, Chuck Lever wrote:
>> From: Bernard Metzler <bmt@zurich.ibm.com>
>>=20
>> Tunnel devices have zero GIDs, so skip the zero GID check when
>> setting up soft iWARP over a tunnel device.
>=20
> Huh? Why? How does that make any sense?

Read it as a cry for help.

The scenario is attempting to set up a soft iWARP device
with a slave that is a tunnel device. The set up seems to
work, but when connecting, the ULP gets an ADDR_ERROR
because the setup did not add an entry to the GID table.

--
Chuck Lever