Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Chuck Lever <cel@kernel.org>, Bernard Metzler <BMT@zurich.ibm.com>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC] RDMA/core: Store zero GIDs in some cases
Thread-Topic: [PATCH RFC] RDMA/core: Store zero GIDs in some cases
Thread-Index: AQHZeSvPGmUIQ02sEEOITmW0YGNWva9Au3SAgAAAroCAAAGCgIAAAxqA
Date:   Fri, 28 Apr 2023 13:58:53 +0000
Message-ID: <36CE272E-15F4-40B3-83E8-98BCFE55CA20@oracle.com>
References: <168261567323.5727.12145565111706096503.stgit@oracle-102.nfsv4bat.org>
 <ZEvMo4qkj9NSLXTA@ziepe.ca> <34E28C03-5D1A-4DAA-9B5B-D453F8C256BD@oracle.com>
 <ZEvOec75yMrin/hB@ziepe.ca>
In-Reply-To: <ZEvOec75yMrin/hB@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4f93OCR/fwxYgIh8vjgt5ksiIQe2dOuLxKFYtwr4cArNuL4kzVtzMTcDWvMO?=
 =?us-ascii?Q?WfrQOXWebkRIh74/Au+UKXAGxK5k5N+AWzMkolzG1Pngzg1A00XnzB5cBAiv?=
 =?us-ascii?Q?mJ9b9PGbTTgY5kptVUllM55Tjkg0QatZfsA5EtGOrr7yLoALYAaA/PgxwNmL?=
 =?us-ascii?Q?kUdriucdYVdDHG0XDzX/arfCkN2jS0yyehahcAhJoGna3LG3R0VI5s0b+mwc?=
 =?us-ascii?Q?3OxzQaFCB+odgZBQ9ocpr/u+uRkTDIVTa/evMwlaqb24YOPrFiNqfPTEgk0d?=
 =?us-ascii?Q?LtHxhvIrR6/4NmoPGqUr7jBZ9k9hSekGAZuCLRXrBN3RkWaofJDROZg2c75N?=
 =?us-ascii?Q?e81BLBKkqe6ybx0WIfXTN38Q2IpzqIiaSoCXmQPqYB5M9v+6a2H7cx18EV7O?=
 =?us-ascii?Q?TwtC/hmWQ6KmXlqqowUx9KSy05qOOyhPd6+a3sr1gcf0Emst38Hv+kjwOm7K?=
 =?us-ascii?Q?yCPlnLp5l/vEpeShSSgTAcKIAyG7sYx/dohz1ED/3CdHKx+NtFd+M69fMuam?=
 =?us-ascii?Q?zGkPotC3oL7+1PNlPKm1G9zjMLNm97rBEHAXtlzYv2ZNmWDuzsYYHAe9FSiF?=
 =?us-ascii?Q?5fQE/pSCgbQAutUtMVtBZG85PQHJRM+lssYJ+LUbB9MHWNZqu2xX//nagXbj?=
 =?us-ascii?Q?/p2Fa45AicKaLljNuo/+Ro0fxk6TvdHSc7c5QyFrm/aStnG8eg5fNW01YHJ4?=
 =?us-ascii?Q?tc9ZxPIxP5zr394kDioOAi7NCEjPtx9fc8bRu4xyi2k0MWaoJw9ur08rNb2B?=
 =?us-ascii?Q?93nN3LAGs1cPC/WhKmSVyg3LzDrJy1oD/6pf1Vag/m5TYl4tw8fPTtP8ZZOE?=
 =?us-ascii?Q?bukG8MhptYbM7UsXQiC50kRVmHuYUIY6Tc57Bnz+DlAe6SZ5or71UvxzAuAU?=
 =?us-ascii?Q?UqhZmJ6OU57wJm6HOGXywfGwywWnGgy8hq+cWKoWP1f5qu62jD6Y5pJKojOV?=
 =?us-ascii?Q?Wz09lyv33ImopdBXZ9UQ9gjEPBQoYWE81hOP3OEryKHGyXHA04/iBOnpToWE?=
 =?us-ascii?Q?irHFmA89cKurYzrNnm9Aysjfomyze+9VJ1F43vVM7hLtZVpZpxb3rBFx/0zM?=
 =?us-ascii?Q?YpoaW9CoRk0HpfPXocdl7tOQbLTW1UGzZbFUEi/C6Tkmc9Oavuow7GS+OC8G?=
 =?us-ascii?Q?0wdJf2V1ib7pyWQamSj6F0mU+eqS5eodv8OfA8i1DN4E3FQq1aNONFK7TIcq?=
 =?us-ascii?Q?goILVUNtm0eDNt6XqKYnHAlO0+ueBfFftNLjnDmUnuw4d9Aw8fLAtnGx79EU?=
 =?us-ascii?Q?R+dOVf3lLwIaBoKxXHK3TUW/X2FBZWwmTDwBs+7Eaf+fcJPkr5iRHgVeg/9a?=
 =?us-ascii?Q?0BxOu5ig+7so6uQ+JYErF45KcR99/3fkwSXFQEE+8beXxmINPfqs+23R+osI?=
 =?us-ascii?Q?aUPuxoMBnRo1p6MmN+So7ry1+JSbyEE5wPRRs8c8r1nZ2fx24Q3G4pvl/QqK?=
 =?us-ascii?Q?ke36A1NBRQP88+5INvyhP9Bp6hOv/fpBztFge+RDLy03ndlmN+GfcPtzqMz0?=
 =?us-ascii?Q?9kdDYbwserucjJcrl6qnBOLO9QXYZiKL3BNr7igWz52+aos0e6V98BFBnA1s?=
 =?us-ascii?Q?2FXU+HxfAZcBKM4YX0wtakSZPPYKQlWa287Ii8DYiI6Tw6CrUoTZhtsWrEzY?=
 =?us-ascii?Q?vA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3A3D6154C88B4B40A2EB1E0010720894@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: toWvQFQE5RPGrUP/Zbj2gQ8jWocZULOfCR0viyUy11PKevssf6xsjk+trL0kkfOrnjEaJDrzwkGn0424+NZHq/UY8KlPHqKLJiXtx1khatu4lzWjUt/1N0WEvaNYESuj/zBoXFbCaaaudpsZYPvznE9wqDn2XqVi3S2FVIgSCRGpiN1WKZiCB9A2ZeFa+Y2wfUFxW9BpB7XiJPeJYngY6YoeTn58uJgizHY3oH7rNVc0flQG2tuKa9Qvr6dycCw94jlaL0gf0PrASACZYZ589bgHKzaH46Mq3kPPsMqJWW2gBqcrHbuQqwSOBc/IDe5M4HAtdswFAd8MdOjq9PebD2kkY9K6xzk0KqL7BqWR96lVmpOQPUnICT1xS8GO8wdkJSdTIf+1H3PJKpQS4J2s+7kxKCkfzXZEc5G65aiWvKombxQZNf6Gar9Ii8XHa6OJOOa45IOoDhj8oCYEudAPEPo2NUr7J8uRUbawSeVfENeJPv2yNngTHnEobvN7lwiHIk9xZTazvIj5RG91dVQh+LZGmBssqlgMesytAhtF2WxN7hVhaHim6qqn5rUKYmb8vZSOL7b7OT+GJyydZJrwt+NLvg94yy/uVT6WFueWa2qxzv7Cwl8a2F+TkLq5P6AJfNqoCnT1xGdzLl9j7YVv9CeqBfuIB/UfR38NlJ1LlY/BvzV825ZsoETUdlVlVrtJbYgMaFUQMfbpCwu0Jksgn1WuIV77+1wfWiKKSz9qvLDnLLM8Irokdr/r2cYtY/e8do1YpfJP0Lee7E9WcKGFGXBt6awsdg31FIHywnb5q5lgAYjGcxG+yfWppRn91ybuO4vk88WYhWBG4rjJMquhfwPYOSGgVUde2rCSmWTdBvw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3117764d-e4a1-434d-4754-08db47f0b3a1
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2023 13:58:53.4324
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GqebOaREePbn6Uh1T3trDeka0xT7vZcwKvvdDVmaHoRNspEc9vyj0A+1tCcJn80pDyhHdwE61yy3J1bp9h7pjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7192
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-28_04,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304280114
X-Proofpoint-GUID: Mgk2ksfOE77GRhS1N8w3TFZT7yzjy7Vo
X-Proofpoint-ORIG-GUID: Mgk2ksfOE77GRhS1N8w3TFZT7yzjy7Vo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Apr 28, 2023, at 9:47 AM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
>=20
> On Fri, Apr 28, 2023 at 01:42:24PM +0000, Chuck Lever III wrote:
>>=20
>>=20
>>> On Apr 28, 2023, at 9:39 AM, Jason Gunthorpe <jgg@ziepe.ca> wrote:
>>>=20
>>> On Thu, Apr 27, 2023 at 01:14:43PM -0400, Chuck Lever wrote:
>>>> From: Bernard Metzler <bmt@zurich.ibm.com>
>>>>=20
>>>> Tunnel devices have zero GIDs, so skip the zero GID check when
>>>> setting up soft iWARP over a tunnel device.
>>>=20
>>> Huh? Why? How does that make any sense?
>>=20
>> Read it as a cry for help.
>>=20
>> The scenario is attempting to set up a soft iWARP device
>> with a slave that is a tunnel device. The set up seems to
>> work, but when connecting, the ULP gets an ADDR_ERROR
>> because the setup did not add an entry to the GID table.
>=20
> Don't assign a 0 IP to the tunnel?

That's a little cryptic... can you expand?

Right now I have a Tailscale VPN device with assigned IP
addresses:

3: tailscale0: <POINTOPOINT,MULTICAST,NOARP,UP,LOWER_UP> mtu 1280 qdisc fq_=
codel state UNKNOWN group default qlen 500
    link/none      inet 100.64.0.16/32 scope global tailscale0
       valid_lft forever preferred_lft forever
    inet6 fd7a:115c:a1e0::10/128 scope global         valid_lft forever pre=
ferred_lft forever
    inet6 fe80::725c:1b6d:60ed:fce4/64 scope link stable-privacy         va=
lid_lft forever preferred_lft forever

And after that i/f is UP, I've done this:

 $ sudo rdma link add siw0 type siw netdev tailscale0

With the patch I sent, I can do NFS/RDMA via soft iWARP through
the tunnel. I'm not at all claiming that's a good fix, but only
that this scenario is supposed to work, but currently doesn't.


--
Chuck Lever