Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f1b5a29c393e2f6b23420bfc94beceff1be69ae7.camel@kernel.org>
Subject: Re: [PATCH] lockd: define nlm_port_min,max with CONFIG_SYSCTL
From:   Jeff Layton <jlayton@kernel.org>
To:     Tom Rix <trix@redhat.com>, chuck.lever@oracle.com,
        trond.myklebust@hammerspace.com, anna@kernel.org
Cc:     linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 02 May 2023 14:16:50 -0400
In-Reply-To: <20230502180713.2930022-1-trix@redhat.com>
References: <20230502180713.2930022-1-trix@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1 (3.48.1-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-05-02 at 14:07 -0400, Tom Rix wrote:
> gcc with W=3D1 and ! CONFIG_SYSCTL
> fs/lockd/svc.c:80:51: error: =E2=80=98nlm_port_max=E2=80=99 defined but n=
ot used [-Werror=3Dunused-const-variable=3D]
>    80 | static const int                nlm_port_min =3D 0, nlm_port_max =
=3D 65535;
>       |                                                   ^~~~~~~~~~~~
> fs/lockd/svc.c:80:33: error: =E2=80=98nlm_port_min=E2=80=99 defined but n=
ot used [-Werror=3Dunused-const-variable=3D]
>    80 | static const int                nlm_port_min =3D 0, nlm_port_max =
=3D 65535;
>       |                                 ^~~~~~~~~~~~
>=20
> The only use of these variables is when CONFIG_SYSCTL
> is defined, so their definition should be likewise conditional.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  fs/lockd/svc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index bb94949bc223..04ba95b83d16 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -77,9 +77,9 @@ static const unsigned long	nlm_grace_period_min =3D 0;
>  static const unsigned long	nlm_grace_period_max =3D 240;
>  static const unsigned long	nlm_timeout_min =3D 3;
>  static const unsigned long	nlm_timeout_max =3D 20;
> -static const int		nlm_port_min =3D 0, nlm_port_max =3D 65535;
> =20
>  #ifdef CONFIG_SYSCTL
> +static const int		nlm_port_min =3D 0, nlm_port_max =3D 65535;
>  static struct ctl_table_header * nlm_sysctl_table;
>  #endif
> =20

Reviewed-by: Jeff Layton <jlayton@kernel.org>