Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 May 2023 16:01:47 +0200
From:   Cyril Hrubis <chrubis@suse.cz>
To:     Petr Vorel <pvorel@suse.cz>
Cc:     ltp@lists.linux.it, NeilBrown <neilb@suse.de>,
        linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH v5 5/5] nfs: Run on btrfs, ext4, xfs
Message-ID: <ZFO6ywouPkmNKtkr@yuki>
References: <20230504131414.3826283-1-pvorel@suse.cz>
 <20230504131414.3826283-6-pvorel@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230504131414.3826283-6-pvorel@suse.cz>
Precedence: bulk

Hi!
>  nfs_get_remote_path()
> @@ -210,6 +213,7 @@ nfs_cleanup()
>  		grep -q "$local_dir" /proc/mounts && umount $local_dir
>  		n=$(( n + 1 ))
>  	done
> +	sleep 2
>  
>  	n=0
>  	for i in $VERSION; do
> @@ -219,12 +223,15 @@ nfs_cleanup()
>  		if tst_net_use_netns; then
>  			if test -d $remote_dir; then
>  				exportfs -u *:$remote_dir
> +				sleep 1
>  				rm -rf $remote_dir
>  			fi
>  		else
>  			tst_rhost_run -c "test -d $remote_dir && exportfs -u *:$remote_dir"
> +			sleep 1
>  			tst_rhost_run -c "test -d $remote_dir && rm -rf $remote_dir"
>  		fi
> +
>  		n=$(( n + 1 ))
>  	done

Generally I'm not happy about the sleeps in the code, the main problem
is that the test still may fail in a case that something was slower than
usuall and we decided to proceed after we slept for a pre-defined
interval. Ideally these should be replaced with a active waiting, i.e.
loop that checks some condition 10 times in a second or so. Hoewever I'm
okay with getting this in so that we manage to have these tests in
before the release and fixing it later on.

-- 
Cyril Hrubis
chrubis@suse.cz