Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230421182738.901701-1-anna@kernel.org> <B1DC5ECE-ECA8-4282-92EB-7272D091AC87@redhat.com>
In-Reply-To: <B1DC5ECE-ECA8-4282-92EB-7272D091AC87@redhat.com>
From:   Anna Schumaker <anna@kernel.org>
Date:   Thu, 4 May 2023 16:51:36 -0400
Message-ID: <CAFX2Jf=rcZfTRXNOoiZj91=pTWQEPrkq8VqBHY3AyC7rBe8sew@mail.gmail.com>
Subject: Re: [RFC PATCH] NFS: add a sysfs file for enabling & disabling nfs features
To:     Benjamin Coddington <bcodding@redhat.com>
Cc:     linux-nfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 4, 2023 at 8:56=E2=80=AFAM Benjamin Coddington <bcodding@redhat=
.com> wrote:
>
> On 21 Apr 2023, at 14:27, Anna Schumaker wrote:
>
> > From: Anna Schumaker <Anna.Schumaker@Netapp.com>
> >
> > And add some basic checking so we only enable features that are present
> > in a given NFS version.
> >
> > Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> > ---
>
> This is great, I like how you've kept the +/- notation similar to knfsd
> supported versions.
>
> Another way to do this would be an attribute file per capability, setting=
 it
> to 0 or 1 which is more inline with sysfs usage.
>
> I think if we do use this, we ought to leave readdir plus out of it becau=
se
> there's already a mount option for it.  Readdir plus can be turned on and
> off with a remount already.  The issue for me would be how to work out wh=
at
> the behavior should be when we have a mount that has "nordirplus" and the=
n
> someone tries to toggle it via sysfs.

That makes sense!
>
> Any other thoughts?

I guess if we remove the readdir plus option, then we could make it so
this file only shows up on v4.2 mounts.
>
> I'll add this patch to my future postings of sysfs work.

Do you want a v2 without the readdir plus line, and with the v4.2 restricti=
on?

Anna

>
> Ben
>