Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 5 May 2023 12:44:58 +0800
From:   Zorro Lang <zlang@redhat.com>
To:     Anna Schumaker <anna@kernel.org>
Cc:     linux-nfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] nfs/002: Add a test for xattr ctime updates
Message-ID: <20230505044458.wrvhvamrkcuqin3z@zlang-mailbox>
References: <20230504204847.405037-1-anna@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230504204847.405037-1-anna@kernel.org>
Precedence: bulk

On Thu, May 04, 2023 at 04:48:47PM -0400, Anna Schumaker wrote:
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
> 
> The NFS client wasn't updating ctime after a setxattr request. This is a
> test written while fixing the bug.
> 
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> ---
>  tests/nfs/002     | 39 +++++++++++++++++++++++++++++++++++++++
>  tests/nfs/002.out |  2 ++
>  2 files changed, 41 insertions(+)
>  create mode 100755 tests/nfs/002
>  create mode 100644 tests/nfs/002.out
> 
> diff --git a/tests/nfs/002 b/tests/nfs/002
> new file mode 100755
> index 000000000000..5bfedef6c57d
> --- /dev/null
> +++ b/tests/nfs/002
> @@ -0,0 +1,39 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2023 Netapp Inc., All Rights Reserved.
> +#
> +# FS QA Test 002
> +#
> +# Test a bug whene the NFS client wasn't sending a post-op GETATTR to the
> +# server after setting an xattr, resulting in `stat` reporting a stale ctime.
> +#
> +. ./common/preamble
> +_begin_fstest auto quick attr
> +
> +# Import common functions
> +. ./common/filter
> +. ./common/attr
> +
> +# real QA test starts here
> +_supported_fs nfs

Great, a new nfs test case!

> +_require_test_nfs_version 4.2

But I'm wondering if this case can be a generic test case, due to the operations
in this case are common (need xattr and ctime support), don't depend on
any nfs specific features/operations.

Not sure why nfs4.2 is necessary, can it be removed or replaced ?

Thanks,
Zorro

> +_require_attrs
> +
> +touch $TEST_DIR/testfile
> +
> +before_ctime=$(stat -c %z $TEST_DIR/testfile)
> +$SETFATTR_PROG -n user.foobar -v 123 $TEST_DIR/testfile
> +after_ctime=$(stat -c %z $TEST_DIR/testfile)
> +
> +test "$before_ctime" != "$after_ctime" || echo "Expected ctime to change."
> +
> +
> +before_ctime=$after_ctime
> +$SETFATTR_PROG -x user.foobar $TEST_DIR/testfile
> +after_ctime=$(stat -c %z $TEST_DIR/testfile)
> +
> +test "$before_ctime" != "$after_ctime" || echo "Expected ctime to change."
> +
> +echo "Silence is golden"
> +status=0
> +exit
> diff --git a/tests/nfs/002.out b/tests/nfs/002.out
> new file mode 100644
> index 000000000000..61705c7cc203
> --- /dev/null
> +++ b/tests/nfs/002.out
> @@ -0,0 +1,2 @@
> +QA output created by 002
> +Silence is golden
> -- 
> 2.40.1
>