Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp713443rwr; Fri, 5 May 2023 04:05:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4cPsHsAQodmeJ6QtlCSxYaKZz8AX3WTkEj69Zw//i3JFHE6bu4lTI/Oo8OzL//zrhFgLQp X-Received: by 2002:a05:6a20:4413:b0:f2:4d44:3560 with SMTP id ce19-20020a056a20441300b000f24d443560mr1408042pzb.19.1683284714473; Fri, 05 May 2023 04:05:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683284714; cv=none; d=google.com; s=arc-20160816; b=LppSxF7+DoEyLSIhSZ087kT8EJntxrRjUIpE+HomlVzvS6DLyRl7ukfExvHkaDfVGV p8dTTUOH3wzMjzJE/EHMMeeZvSwwjQOIUcHNLwtOrkuNX1GEEUHzspG+sQh9feOpouix 7mXNVaRaem0hOl6Box0y7TITkILPqJNl9y+xW68V6Rx+9fvt/KxJRxi5qnBM1gOaN8eE YjUalSWrX9NJKhWrAcn3ztfEPO7gFvUTnyNzA1eaLFLY1LOolUnntiL1Rge9nuToMUB0 E4O8SD0sM9ASh0XKiEpyXWn8MtKd2zYNS92vzE0qLm/w0mAoxrie68mB31olgMn4kJUy TleQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=5mcKZoU9sFVN/fiGmifVNNWu7VXyrMMMjFsjIqNI7M0=; b=a56Wk4pk5W/VWhkCXItDVWNlu360yU7GVYpSJq6MbgB3/ZGZ94LozQnmEWbZw74mNj tsZww4I894uUD3AZFNO0/uskDOS09+YSWZel/05o3zNQ2NCNXqiPdEZFiI76geQJvuAA v+ym7DGkuxETiQ+EfgtHrd1a8mYaybNeWKOKP2J9dVEBSwNRqCGOZcAd24nfQUqT3YUb XKllyP0BINmY+CHp5qv4z81E1qxhsVZilKLzmLCResrdzehZr6Qt9kvyZbiyvaz8yI9O sBQA4N3R1oLjt1K5pEL1q62/Es8pei8fmT8IGC3EUjnMpYpQxHYSiLJXz9hWVEQejhgN TMXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="V/lgxkh7"; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b="W/wRj+Kw"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k24-20020a63f018000000b0052868a865d1si1613175pgh.272.2023.05.05.04.04.48; Fri, 05 May 2023 04:05:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="V/lgxkh7"; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b="W/wRj+Kw"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231577AbjEEKol (ORCPT + 99 others); Fri, 5 May 2023 06:44:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230411AbjEEKol (ORCPT ); Fri, 5 May 2023 06:44:41 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B72BE41 for ; Fri, 5 May 2023 03:44:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1020C1F8C1; Fri, 5 May 2023 10:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1683283479; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5mcKZoU9sFVN/fiGmifVNNWu7VXyrMMMjFsjIqNI7M0=; b=V/lgxkh71tCBx8d3VztqKsVW+DAbzVyutGyv3pKTXT2SsCj49g0hOHPvRkzODw3l6g/O43 CqMaSeDOiRgSi1yZkxaLkSECsefjY0r3SkDMNpEpRknzdw4gyUulX3U+C7HLcSk7SZAC09 +s2DzkmDjWI4BfFUSzVyJdDcr4q9W+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1683283479; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5mcKZoU9sFVN/fiGmifVNNWu7VXyrMMMjFsjIqNI7M0=; b=W/wRj+Kw6VsTxZWh4QehT+gp8LgsgwEAjP1bU3vo/vmqGqmjBjyMeBhL+3+y1I5f2/mQ2F gYYnyLCJRzXAdvCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 53E7F13513; Fri, 5 May 2023 10:44:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8/lRDRbeVGRWAgAAMHmgww (envelope-from ); Fri, 05 May 2023 10:44:38 +0000 Date: Fri, 5 May 2023 12:44:36 +0200 From: Petr Vorel To: Cyril Hrubis Cc: ltp@lists.linux.it, NeilBrown , linux-nfs@vger.kernel.org, Jeff Layton Subject: Re: [PATCH v5 1/5] nfs_lib.sh: Cleanup local and remote directories setup Message-ID: <20230505104436.GA31237@pevik> Reply-To: Petr Vorel References: <20230504131414.3826283-1-pvorel@suse.cz> <20230504131414.3826283-2-pvorel@suse.cz> <20230504211634.GA4244@pevik> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Cyril, > Hi! > > > It's a bit puzzling why we have two identical functions with a different > > > name... > > It's a preparation for TST_ALL_FILESYSTEMS=1 where the location changes. > > I can squash this into that commit where it changes. > That is the missing bit. No need to squash maybe just note that the > directory will change in the last commit of the patchset. +1 (I intended and obviously forgot). Kind regards, Petr