Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp3919921rwr; Sun, 7 May 2023 23:21:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qE+LlmiIMM+AJz4ndm+kw7vI42vDXoCgEnnF7twcSpGDwEQJ9pe3O5GJAc/yVeJ5d3Cyd X-Received: by 2002:a05:6a20:6a22:b0:f2:bb3f:3b3e with SMTP id p34-20020a056a206a2200b000f2bb3f3b3emr12468707pzk.38.1683526911387; Sun, 07 May 2023 23:21:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683526911; cv=none; d=google.com; s=arc-20160816; b=aKwE4A0R9c7IxArA686Ec33DgB/7Z6ZuSf1clk4Ok0NSgcQkP7WVvXlBcR/AXMGqSl 44TGCQPKkhuXWDKYlZmwgipFnjQ9zB1f7tzsbtzCoyxT8lOlxlN5qzHYSK0q84MIDlqg iPxcheV0PPpJGmkKcKARgG4M2C20EBy41+K4Nn/XKZitde12r9n5otkYhoAv2wiobZO1 zCE3H9V+GvN8qkzjIUH76fIQybsgl7B5G3qPhW0LdM2/p0XiSV6I7cf0zE3E+C6wGY0b evMqG9BYrxpbIqRzVfpH5sJaD4goqn9Q5UZAZ8NQr8MjUK+BnEqQTW3fE7LDVJE5PPza Q5cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature :dkim-signature; bh=Ve1c6/jYtA0PHTK5NzLGxLdTU53SFWk5zk+igbF0mic=; b=QB9+mEYg7fyjZppWtkICWzOKMKy+LCu6gb4f6K/8stejLLTYETKgeoi27okuZwMVdN zqFlL99l5jwRHTUBImY6bv8mHh395seN3RyvchFgphw0aFPaMWsgjrrfY8j2KZ26WPxQ hSnsiihLI7Hi9mW9JAn9H9flPbNsmGaFEd+VQrc9n/OqFxwJu9ml0ZRzDKZy5SBjcOwD uDFFmMEahNcMZwQyWIUgJsQYaZaFf/OdW3f5fKUG0joREEl0kBag8poKJZpC5d8cfDrz e/RhjtRO0Z5o1Ymmlwqs6jSh5PhhT68Fskv1u7r60zGSRYq2ubRfD39/F68yCLDKs/Ub 0hbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=SIZpo5jU; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s27-20020a63925b000000b0052132a8e4e3si7309403pgn.510.2023.05.07.23.21.27; Sun, 07 May 2023 23:21:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=SIZpo5jU; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbjEHGUV (ORCPT + 99 others); Mon, 8 May 2023 02:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232546AbjEHGUU (ORCPT ); Mon, 8 May 2023 02:20:20 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 471BA1FEA for ; Sun, 7 May 2023 23:20:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D80371FD9F; Mon, 8 May 2023 06:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683526817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ve1c6/jYtA0PHTK5NzLGxLdTU53SFWk5zk+igbF0mic=; b=SIZpo5jUA2/V6xwbht0g2ca3BVLV9aDS/oATfX14spICoBTrs66V5lO0L1bBkK5VSy5soD 8oIOStgBDziGa2K7cXfm5hQJ/MaZEQ7C+xpYevo5A0MUVBMfZeAfJgbAj3Qai63WM55dGI 0o4BvhG0BQ8RbjpAxxUjnuCVaQk6Z5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683526817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ve1c6/jYtA0PHTK5NzLGxLdTU53SFWk5zk+igbF0mic=; b=2NBtVLUqIJA8tmHxE0YkXTZg2iQSvhy+be4CFrCT9qrFVcu6H4s+/lZ3Sll7tPXLtrtm6C ayrjvsAiIT3LK+AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A054F13499; Mon, 8 May 2023 06:20:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D0wzFaCUWGRMGAAAMHmgww (envelope-from ); Mon, 08 May 2023 06:20:16 +0000 Subject: [PATCH 0/2] Minor improvements for fsidd in nfs-utils From: NeilBrown To: Steve Dickson , Richard Weinberger Cc: linux-nfs@vger.kernel.org Date: Mon, 08 May 2023 16:19:11 +1000 Message-ID: <168352657591.17279.393573102599959056.stgit@noble.brown> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org nfs-utils in openSUSE was recently updated to a version with fsidd and a routine security audit was performed. No real security issues were found but a couple of oddities were highlighted. The follow two patches propose ways to clean up these oddities. NeilBrown --- NeilBrown (2): fsidd: don't use assert() on expr with side-effect. fsidd: provide better default socket name. support/reexport/fsidd.c | 38 +++++++++++++++++++++---------------- support/reexport/reexport.c | 3 +++ support/reexport/reexport.h | 2 +- 3 files changed, 26 insertions(+), 17 deletions(-) -- Signature