Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 21:40:53 +0800
From:   Zorro Lang <zlang@redhat.com>
To:     Anna Schumaker <anna@kernel.org>
Cc:     linux-nfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH v2] generic/728: Add a test for xattr ctime updates
Message-ID: <20230511134053.pbz46ny6de7rqb6p@zlang-mailbox>
References: <20230505172427.94963-1-anna@kernel.org>
 <20230510124511.wcgy63menqywvt34@zlang-mailbox>
 <CAFX2Jf=ma0cFAST9_Bfbekxa_2M8JC2TgwLLEDw-1QDK9SbZ1w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFX2Jf=ma0cFAST9_Bfbekxa_2M8JC2TgwLLEDw-1QDK9SbZ1w@mail.gmail.com>
Precedence: bulk

On Wed, May 10, 2023 at 12:13:59PM -0400, Anna Schumaker wrote:
> On Wed, May 10, 2023 at 8:45 AM Zorro Lang <zlang@redhat.com> wrote:
> >
> > On Fri, May 05, 2023 at 01:24:27PM -0400, Anna Schumaker wrote:
> > > From: Anna Schumaker <Anna.Schumaker@Netapp.com>
> > >
> > > The NFS client wasn't updating ctime after a setxattr request. This is a
> > > test written while fixing the bug.
> > >
> > > Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> > >
> > > ---
> > > v2:
> > >  - Move test to generic/
> > >  - Address comments from the mailing list
> > > ---
> > >  tests/generic/728     | 42 ++++++++++++++++++++++++++++++++++++++++++
> > >  tests/generic/728.out |  2 ++
> > >  2 files changed, 44 insertions(+)
> > >  create mode 100755 tests/generic/728
> > >  create mode 100644 tests/generic/728.out
> > >
> > > diff --git a/tests/generic/728 b/tests/generic/728
> > > new file mode 100755
> > > index 000000000000..ab2414c151db
> > > --- /dev/null
> > > +++ b/tests/generic/728
> > > @@ -0,0 +1,42 @@
> > > +#! /bin/bash
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +# Copyright (c) 2023 Netapp Inc., All Rights Reserved.
> > > +#
> > > +# FS QA Test 728
> > > +#
> > > +# Test a bug where the NFS client wasn't sending a post-op GETATTR to the
> > > +# server after setting an xattr, resulting in `stat` reporting a stale ctime.
> > > +#
> > > +. ./common/preamble
> > > +_begin_fstest auto quick attr
> > > +
> > > +# Import common functions
> > > +. ./common/attr
> > > +
> > > +# real QA test starts here
> > > +_supported_fs generic
> > > +_require_test
> > > +_require_attrs
> > > +
> > > +rm -rf $TEST_DIR/testfile
> > > +touch $TEST_DIR/testfile
> > > +
> > > +
> > > +_check_xattr_op()
> > > +{
> > > +  what=$1
> > > +  shift 1
> > > +
> > > +  before_ctime=$(stat -c %z $TEST_DIR/testfile)
> > > +  $SETFATTR_PROG $* $TEST_DIR/testfile
> >
> > Hi Anna,
> >
> > If there's not objection from you, I'll add below codes at here, and merge
> > this case in next fstests release:
> 
> Yeah, no objection from me. Sorry I haven't had a chance to get around
> to the change this week, I've been doing LSF.

Oh, no push, hope you enjoy that!

> 
> >
> > +       # There might be filesystem's timestamp granularity, so sleep 2 seconds
> > +       # for most filesystems can capture a different timestamp across a
> > +       # setxattr operation
> > +       sleep 2s
> >
> > BTW, is there a known git commit which fix the issue of this case trying to
> > test?
> 
> Not yet, but there will be soon. Those patches are still in review and
> might need minor fixups. Can the git commit be added once they're
> ready?

Sure. Someone would like to add that later (don't forget:), someone else would
like to write the commit id as "xxxxxxxxx", then replace it after the patch get
merged. Both ways are good to me.

If you prefer the former, I can merge this V2 with above change. Or I can wait
the V3 from you.

Thanks,
Zorro

> 
> Anna
> 
> >
> > Thanks,
> > Zorro
> >
> > > +  after_ctime=$(stat -c %z $TEST_DIR/testfile)
> > > +
> > > +  test "$before_ctime" != "$after_ctime" || echo "Expected ctime to change after $what."
> > > +}
> > > +
> > > +_check_xattr_op setxattr -n user.foobar -v 123
> > > +_check_xattr_op removexattr -x user.foobar
> > > +
> > > +echo "Silence is golden"
> > > +status=0
> > > +exit
> > > diff --git a/tests/generic/728.out b/tests/generic/728.out
> > > new file mode 100644
> > > index 000000000000..ab39f45fe5da
> > > --- /dev/null
> > > +++ b/tests/generic/728.out
> > > @@ -0,0 +1,2 @@
> > > +QA output created by 728
> > > +Silence is golden
> > > --
> > > 2.40.1
> > >
> >
>