Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9914d172-986f-7c86-fe03-4378e64383f1@redhat.com>
Date:   Thu, 11 May 2023 15:39:04 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 0/2] Minor improvements for fsidd in nfs-utils
Content-Language: en-US
To:     NeilBrown <neilb@suse.de>, Richard Weinberger <richard@nod.at>
Cc:     linux-nfs@vger.kernel.org
References: <168352657591.17279.393573102599959056.stgit@noble.brown>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <168352657591.17279.393573102599959056.stgit@noble.brown>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/8/23 2:19 AM, NeilBrown wrote:
> nfs-utils in openSUSE was recently updated to a version with fsidd and a
> routine security audit was performed.  No real security issues were
> found but a couple of oddities were highlighted.  The follow two patches
> propose ways to clean up these oddities.
> 
> NeilBrown
> 
> 
> ---
> 
> NeilBrown (2):
>        fsidd: don't use assert() on expr with side-effect.
>        fsidd: provide better default socket name.
> 
> 
>   support/reexport/fsidd.c    | 38 +++++++++++++++++++++----------------
>   support/reexport/reexport.c |  3 +++
>   support/reexport/reexport.h |  2 +-
>   3 files changed, 26 insertions(+), 17 deletions(-)
> 
> --
> Signature
> 
Committed... (tag: nfs-utils-2-6-4-rc1)

steved