Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f7c668bd-9c04-39e2-6b35-54a131b85f34@redhat.com>
Date:   Thu, 11 May 2023 15:39:38 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] libevent and libsqlite3 checked when nfsv4 is disabled
Content-Language: en-US
To:     Wiktor Jaskulski <wikjas97@gmail.com>, linux-nfs@vger.kernel.org
Cc:     wjaskulski <wjaskulski@adva.com>
References: <20230510115637.29271-1-wjaskulski@adva.com>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20230510115637.29271-1-wjaskulski@adva.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/10/23 7:56 AM, Wiktor Jaskulski wrote:
> From: wjaskulski <wjaskulski@adva.com>
> 
> Even if nfsv4 is disabled component fsidd has libevent and libsqlite3 as dependencies.
> 
> Problems with compilation and error logs can be found at:
> https://github.com/gentoo/gentoo/pull/30789
> https://bugs.gentoo.org/904718
> 
> Signed-off-by: Wiktor Jaskulski <wjaskulski@adva.com>
Committed... (tag: nfs-utils-2-6-4-rc1)

steved
> ---
>   configure.ac | 38 +++++++++++++++-----------------------
>   1 file changed, 15 insertions(+), 23 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4ade528d..519cacbf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -335,42 +335,34 @@ AC_CHECK_HEADER(rpc/rpc.h, ,
>                   AC_MSG_ERROR([Header file rpc/rpc.h not found - maybe try building with --enable-tirpc]))
>   CPPFLAGS="${nfsutils_save_CPPFLAGS}"
>   
> +dnl check for libevent libraries and headers
> +AC_LIBEVENT
> +
> +dnl Check for sqlite3
> +AC_SQLITE3_VERS
> +
> +case $libsqlite3_cv_is_recent in
> +yes) ;;
> +unknown)
> +   dnl do not fail when cross-compiling
> +   AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> +*)
> +   AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
> +esac
> +
>   if test "$enable_nfsv4" = yes; then
> -  dnl check for libevent libraries and headers
> -  AC_LIBEVENT
>   
>     dnl check for the keyutils libraries and headers
>     AC_KEYUTILS
>   
> -  dnl Check for sqlite3
> -  AC_SQLITE3_VERS
> -
>     if test "$enable_nfsdcld" = "yes"; then
>   	AC_CHECK_HEADERS([libgen.h sys/inotify.h], ,
>   		AC_MSG_ERROR([Cannot find header needed for nfsdcld]))
> -
> -    case $libsqlite3_cv_is_recent in
> -    yes) ;;
> -    unknown)
> -      dnl do not fail when cross-compiling
> -      AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> -    *)
> -      AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;;
> -    esac
>     fi
>   
>     if test "$enable_nfsdcltrack" = "yes"; then
>   	AC_CHECK_HEADERS([libgen.h sys/inotify.h], ,
>   		AC_MSG_ERROR([Cannot find header needed for nfsdcltrack]))
> -
> -    case $libsqlite3_cv_is_recent in
> -    yes) ;;
> -    unknown)
> -      dnl do not fail when cross-compiling
> -      AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> -    *)
> -      AC_MSG_ERROR([nfsdcltrack requires sqlite-devel]) ;;
> -    esac
>     fi
>   
>   else