Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230515024044.2677124-1-azeemshaikh38@gmail.com> <338aa895e02c795329c980cee67463faef0fc57e.camel@kernel.org>
In-Reply-To: <338aa895e02c795329c980cee67463faef0fc57e.camel@kernel.org>
From:   Azeem Shaikh <azeemshaikh38@gmail.com>
Date:   Mon, 15 May 2023 10:30:57 -0400
Message-ID: <CADmuW3V_J+5ikfArEmj8_a9HYpX57rON6BE9fV5bXsix+XtqxQ@mail.gmail.com>
Subject: Re: [PATCH v3] NFSD: Remove open coding of string copy
To:     Jeff Layton <jlayton@kernel.org>
Cc:     Chuck Lever <chuck.lever@oracle.com>,
        linux-hardening@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 15, 2023 at 7:21=E2=80=AFAM Jeff Layton <jlayton@kernel.org> wr=
ote:
>
> On Mon, 2023-05-15 at 02:40 +0000, Azeem Shaikh wrote:
> > Instead of open coding a __dynamic_array(), use the __string() and
> > __assign_str() helper macros that exist for this kind of use case.
> >
> > Part of an effort to remove deprecated strlcpy() [1] completely from th=
e
> > kernel[2].
> >
> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strl=
cpy
> > [2] https://github.com/KSPP/linux/issues/89
> >
> > Fixes: 3c92fba557c6 ("NFSD: Enhance the nfsd_cb_setup tracepoint")
> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> > ---

v1 and v2 links for posterity.
v1: https://lore.kernel.org/all/20230510220952.3507366-1-azeemshaikh38@gmai=
l.com/
v2: https://lore.kernel.org/all/20230512145356.396567-1-azeemshaikh38@gmail=
.com/

> Reviewed-by: Jeff Layton <jlayton@kernel.org>

Thanks!