Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cad818127d6df4ebcc6e837def684ad381de83fe.camel@kernel.org>
Subject: Re: [PATCH 0/4] Socket creation observability
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc:     Chuck Lever <chuck.lever@oracle.com>
Date:   Mon, 15 May 2023 12:56:54 -0400
In-Reply-To: <168415745478.9504.1882537002036193828.stgit@manet.1015granger.net>
References: <168415745478.9504.1882537002036193828.stgit@manet.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1 (3.48.1-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-05-15 at 09:32 -0400, Chuck Lever wrote:
> This series updates observability around socket creation and
> destruction to help troubleshoot issues such as:
>=20
> https://lore.kernel.org/linux-nfs/65AFD2EF-E5D3-4461-B23A-D294486D5F65@or=
acle.com/T/#t
>=20
> I plan to apply these to nfsd-next.
>=20
> ---
>=20
> Chuck Lever (4):
>       SUNRPC: Fix an incorrect comment
>       SUNRPC: Remove dprintk() in svc_handle_xprt()
>       SUNRPC: Improve observability in svc_tcp_accept()
>       SUNRPC: Trace struct svc_sock lifetime events
>=20
>=20
>  include/trace/events/sunrpc.h | 39 ++++++++++++++++++++++++-----------
>  net/sunrpc/svc_xprt.c         |  3 ---
>  net/sunrpc/svcsock.c          | 15 ++++++--------
>  3 files changed, 33 insertions(+), 24 deletions(-)
>=20
> --
> Chuck Lever
>=20

These all look fine to me. I had one nit about a conditional tracepoint,
but your call on whether you want to respin it that way.

Reviewed-by: Jeff Layton <jlayton@kernel.org>