Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Chuck Lever <cel@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/4] Socket creation observability
Thread-Topic: [PATCH 0/4] Socket creation observability
Thread-Index: AQHZhzG71ldMfHI4BkuQ0pvalUd1Fq9bjh0AgAAUnAA=
Date:   Mon, 15 May 2023 18:10:50 +0000
Message-ID: <011A0193-FC9E-4073-935B-69E4F9349214@oracle.com>
References: <168415745478.9504.1882537002036193828.stgit@manet.1015granger.net>
 <cad818127d6df4ebcc6e837def684ad381de83fe.camel@kernel.org>
In-Reply-To: <cad818127d6df4ebcc6e837def684ad381de83fe.camel@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AOo6+NfRnI1qOkCvzTbwjZtTMUjLvyCdRZ5nMH6sd2TRnnjO9y/4KvmNovdN?=
 =?us-ascii?Q?RVohrO3MvTtsS0PVOq3J1ohOO94ZXvJy53ahcQqmtikoJB1yoTL3tspUCcgr?=
 =?us-ascii?Q?3J2R6t6zP1cYrsytRWy5vAeaa7ontRO77N7G1VQmKCqm2XI+3TmQO6RRgRAX?=
 =?us-ascii?Q?DS41W54IwlME4A7Ettl5Db07ZHRhgGK5/XjtGP74l3p9Gkiy6acTAdw+hTDK?=
 =?us-ascii?Q?3z2PEaIot7G/CjUU8YOmB5O6icbWbd1qc8PciH5Z7GrWd+DryN1ecBnDiDot?=
 =?us-ascii?Q?aGRIMKBF+Zx9gqzJGr92j/9upfkd6C0sb+Iwdhmt1d35/RFagfCuQgFfXd0+?=
 =?us-ascii?Q?vyvZph8Lh8+HbR6Egr18V9dFMDPlkLtiFvCHMCU5rxBEiuL+Lrftcv/a4AlY?=
 =?us-ascii?Q?2Vg2tdWA4DOCtGj9z8MSt1mSD7vVllmJ512Vq+oMYV1mdw8hxqP++jNLfXel?=
 =?us-ascii?Q?T438q8ikXeXR8LbGTBSEnflNuf3zvUSy6o5VEb8wkM/AeGItI2HHlvRO/qeJ?=
 =?us-ascii?Q?v911CDZtE9BNPQRnGCwO6QFxpKg9XGY9eTjg/G6IIIE1yg4VDod/TbfQPwoM?=
 =?us-ascii?Q?Hzs7oLomQVsTTVp6rsNs2TMrAdQpYYLgUjSrg8C8QNenJuzC2S3b5dteB6OW?=
 =?us-ascii?Q?+D3siMD7CKx3wKaxp5aRRtuz1jRKT0TyoQ/vA4PIA9MG+1+lub9nnX+N96VK?=
 =?us-ascii?Q?nEdtVHejKGHFzx8Lzgi8L46RL9fHjdh9MwTltwfNeKRoo336Npri+9BmLikJ?=
 =?us-ascii?Q?hCSEF+B9KCNWyIMit6chUUmc//FCY2OD96F3OafzRRmE+ibCkFM/GWEDtHLN?=
 =?us-ascii?Q?0948bjgTnifa29EgFkfhtVaQTfGVxik7NR2zwuc0hoGAiGQdb5aliCd6A4ef?=
 =?us-ascii?Q?3/skCNnETOE1FBGVVEB6DSpRo8NoOjzsjWDRhEKngKfSF2ItYK/zGR/Lmr+j?=
 =?us-ascii?Q?tGZxB68ncWJ7ME17LsPr7cbVnuVZBgVqQUgbg73+qaX6UopkOdI1BKGPneFf?=
 =?us-ascii?Q?3LbXvTmU4HedYsvf/nZZfFwWqUuq60/ota2O3Sp66T1W75ZiMtDFDj39aqzI?=
 =?us-ascii?Q?33F8+85hjm+3FU5yWFERI0krqSK+lPteHbHOEJlwf8/q9n1INy4LjONq4gk3?=
 =?us-ascii?Q?0Av77X6ARMbAgC9qy3+wDRVjcbQgxmqbCtsG2gorCOpKfr35qoEn4Ghuvb1X?=
 =?us-ascii?Q?kfsb5bjthIMbWiqa9Hxh124A+vfqMBGUMUMD3pdkwKjXzloz/FG55qevZpOC?=
 =?us-ascii?Q?D4PGAWNiDO64ndtgfVrrG0yVYeCC2UpRbvFNssUNYxuOSLiwM21xzpX+Nuqd?=
 =?us-ascii?Q?po0N01pW5DPny5F473IsdiJM9L+0u3/8fhAqOH2c8QBcLlOmRikov67PaBLC?=
 =?us-ascii?Q?7CWU4+FAIdbqDhpxJ8NwbtJSqovcmtCob5X+WtcnKurO1oEbWHOCASoCU1/6?=
 =?us-ascii?Q?1trZDIbxvq61yRM78KOdM7Wolk7MSD0i6681u/JtBLZscfkLMYOgfYNowjba?=
 =?us-ascii?Q?BPx6AParUH+HZ/Eix2BLP3AouKIlZgO0Rt5Oi8I1llDjq9pZbQjrwm5QPkbV?=
 =?us-ascii?Q?bhxNGr9hwIdrJ0EMcUmiUQQnH/dfbayyY9B9Jxk2Prt6nmWjko0ksyPu3MyT?=
 =?us-ascii?Q?ew=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EB27EE97AD12794D9E8031AF4E4B3978@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: OWUJ02QrIY/O5rtkd+L0yB3PiWze7hi1yPcQppDUCgC4avpBnJBmEHm+ecaDCqHadrcjC86+54R5xjQ2QAVieEOVhVexCYdxdAlzp43t3SE8e0ncdUYsWRXBfuPF45mJKQ0HRsrinZ4Hkgk8mUYOrMtEfTmlM0IodrTLs1qI1vengsOCC/uSFtYoBsr+QR6OUjr6qOwmG0eV/yWSIGfogZHJxNqULdbWEetOJ59dWAmwNmdKVY4BjaSQPESyOw+7xXdDsrX5CNWHffIcmU1wyuULAZH2/Dg3XiJ/z8z79RZerjGIATZ5qf3dasw6KchJbFz377ORV0W/f2s9MEPSmig4pSG4f2lrPnQqeEP6qOXJ6QPCgwgkrNFhNRNJCwG4VEdvytduj6gUZDGAX38U6FoyRPIDDReamdfGIzO8pBt7QQPK5omcyAqsxBJF1fzPLe++o4Q83CrciIkykykpGOqRnjvPMVF4eDWzpy0Zc8kMe1leaPBOGOGPcIdS9KH7RnP/K9lqz1SttCLiK8Bv9aQg/kn7CZyjW1nN9V02tTgR3y9BrgO4wAVOpoZN81boPhi04Fy/eALlCklv8BBLPbc9AeVUeTSPAzQvfVhMaGQx+cujp4umg9/GeSyFZDFBGfDFjuCVQYkmjzuTULywBdi7EWY+2/T2Nzoa2CtmXuJwIDO+7en3lYIEO0uAWWjKl93ctNW1nr4bDEt/SE76F9dqGeIbOcftJSmxAk+fPnndNOEDrjmV9QcN98DmNDtmELdOECdJMComH75tRKeGEv8J9fpiaK8OlQgcntR+pnY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9caef46d-55e1-40af-a5c3-08db556fb725
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2023 18:10:50.4861
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9KJ0j9lZhBEvQNV3e8TN7OtuGISs1jNOrP5Num1VIJjmnaugdIBNv9uR7UDQRRFuiaJI84pQFafHVFwj5QmY7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4413
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-15_16,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 mlxlogscore=999 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2304280000 definitions=main-2305150153
X-Proofpoint-GUID: aTe0r0LLJP9jH8qmoLkyWoHujhfLQcc7
X-Proofpoint-ORIG-GUID: aTe0r0LLJP9jH8qmoLkyWoHujhfLQcc7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On May 15, 2023, at 12:56 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> On Mon, 2023-05-15 at 09:32 -0400, Chuck Lever wrote:
>> This series updates observability around socket creation and
>> destruction to help troubleshoot issues such as:
>>=20
>> https://lore.kernel.org/linux-nfs/65AFD2EF-E5D3-4461-B23A-D294486D5F65@o=
racle.com/T/#t
>>=20
>> I plan to apply these to nfsd-next.
>>=20
>> ---
>>=20
>> Chuck Lever (4):
>>      SUNRPC: Fix an incorrect comment
>>      SUNRPC: Remove dprintk() in svc_handle_xprt()
>>      SUNRPC: Improve observability in svc_tcp_accept()
>>      SUNRPC: Trace struct svc_sock lifetime events
>>=20
>>=20
>> include/trace/events/sunrpc.h | 39 ++++++++++++++++++++++++-----------
>> net/sunrpc/svc_xprt.c         |  3 ---
>> net/sunrpc/svcsock.c          | 15 ++++++--------
>> 3 files changed, 33 insertions(+), 24 deletions(-)
>>=20
>> --
>> Chuck Lever
>>=20
>=20
> These all look fine to me. I had one nit about a conditional tracepoint,
> but your call on whether you want to respin it that way.

Great minds, and all that... I had considered it, but decided
it wasn't worth bothering. I appreciate your time and comments!


> Reviewed-by: Jeff Layton <jlayton@kernel.org>

--
Chuck Lever