Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Jiri Slaby <jirislaby@kernel.org>,
        Steve Dickson <SteveD@redhat.com>,
        Chuck Lever <cel@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Neil Brown <neilb@suse.de>,
        Alexander Ahring Oder Aring <aahringo@redhat.com>
Subject: Re: [PATCH v1 26/27] SUNRPC: Set rq_accept_statp inside ->accept
 methods
Thread-Topic: [PATCH v1 26/27] SUNRPC: Set rq_accept_statp inside ->accept
 methods
Thread-Index: AQHZI37QRUQ4TvDJik2GwoQT/5RlW69HhAGAgAA1uwCAFlcegIAAAJUAgAAhZ4CAAACugA==
Date:   Tue, 16 May 2023 21:27:55 +0000
Message-ID: <4C3DA96B-1FAA-4B80-A344-582BF213BCA8@oracle.com>
References: <167319499150.7490.2294168831574653380.stgit@bazille.1015granger.net>
 <167319546521.7490.43383592461162363.stgit@bazille.1015granger.net>
 <3e34a2dc-7d72-b719-248f-e78361db8a5b@kernel.org>
 <4AB1ED03-57C8-42C1-9A04-6C224E98EDCC@oracle.com>
 <569be8e6eff7af373e6baaf2170edb8a8c52f262.camel@kernel.org>
 <0DEDF045-8C95-463D-B5E7-D2A3DF3230FC@oracle.com>
 <08b1fc12a271688c908ad615c08f910c3ec19672.camel@kernel.org>
In-Reply-To: <08b1fc12a271688c908ad615c08f910c3ec19672.camel@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P3v0X2oAyIQaCAtx8zmfoC85CIRarUXSPncQ0EM3eliRD9G9lHH/AmemA0mU?=
 =?us-ascii?Q?pal3roRd/8aa2gYxHz9tRvv7dOQa5K0hLGZkdyZgT38jo4PYV+pFtSAnsIm/?=
 =?us-ascii?Q?JcRObuJuy5EXcEOwKqwx11umWR+fAXbPOLj6/e4iNFPVypfCwo08BWwdJhaM?=
 =?us-ascii?Q?7dSgrmhyE98oKnIYEfIBWvR7pOTnT9tbz0RcDwOcinHJO7m6IjWNJl+5vhFf?=
 =?us-ascii?Q?fFU4Aa5Z5zSykqVwQRzofeA/f+lXPz0FpYavJO1dXqeCS4gqP8VLjqB2PJnR?=
 =?us-ascii?Q?Dhou0kxGNcrJ6AIunR3LwhKOwCKmshL3ApZoObR2MRfphj6CUry5ynnG2J1u?=
 =?us-ascii?Q?xjnXzYWTHjr1TwBD82QWILBuGCumneB7Pzn1Mny9jGo0MAEDyZqv6Jd/P/gU?=
 =?us-ascii?Q?6wpn1sHIcbAj5aXtYbK4+TnCbdUvZ9wXqLZA29BTnRT76l7GNygUO4CSPokY?=
 =?us-ascii?Q?B1txeUhuiAcueQbAGw2qAXKOJ4R59f5X7CV+0M/205UbC2Em9RXpOo2nh+c7?=
 =?us-ascii?Q?NyKrp+2LL0AKPCkKjLSyAWViC43ibf6whxe2J88xI3Su9/sHZb5TcfziPRm6?=
 =?us-ascii?Q?S/rLOFbDbsmO1xXgDmE5Yp2bEyN2njdSrknGcLol4rAYrUmjp+Mo+isB8H6C?=
 =?us-ascii?Q?UoxBp3PkS8fgfce835BMgpYTPc1rFutoIzAQysc1VaGTxI1Xi7BTDwLErQUa?=
 =?us-ascii?Q?5nGIFRSXkkJ9I2Fwy6yvMXUmN1VzuaTSH0pnXePfo7jiYLMY1tvcRT7GP0EF?=
 =?us-ascii?Q?qgXir/dm2A1L+KRxI2HhYgM8Nqi402CxqQDhRDBYY/LNRguPNVyKMt9B/q4C?=
 =?us-ascii?Q?USvXwQJosEjBIGvBe5n/5tLyvb7dmum94m/UmnhdpFwJ6h1YeSy/8PPMOG+B?=
 =?us-ascii?Q?G1wLodxaHi3EjHxgdIGfbqogb3geyJyymi0T+sKeSotaEsyiWBbk850qr6Ro?=
 =?us-ascii?Q?RhxtR6/CaER//Zrp+W5BPmJ5VfWI1jS0Avy8OwRrXdljpXm2cKnGI5M6nlRi?=
 =?us-ascii?Q?iAq3/xof9HPoyaJgx8oJB+Yw/z41qQBglkRk+Ov3+NvzZ4hA9zFvDliOJkJZ?=
 =?us-ascii?Q?ByB74z4nC+X+17eKbjVbNZrxb4Wmh/ikuWA0J9dE4Sku5129R+BuYP5eIkpc?=
 =?us-ascii?Q?po41uvoQ/rwlg8wxfx6ksbe+OKNqpvnH9QAwBlTbQ3mqJ+Mi9MYhOX4VBzkT?=
 =?us-ascii?Q?EWYEXRB9UzSsaXQDZ2GMrKDb/9crSfiDKu3xbP8LK9s7NMn6UR1Vh7/KUiJx?=
 =?us-ascii?Q?XP7p9DUjpJLehaSs606xNb5IV34PKLE87ShDxlviauBOf0I6PzSKKpxm7Yfg?=
 =?us-ascii?Q?KQK1eWbjrxNzYD+eBwKA373B/xvuQ4LMRgmTTsLWw3UOiDodKzVewPGsguuS?=
 =?us-ascii?Q?IVmlb3tYWAZWQI7PxxUbvO4GWfr/EP9ayYbJEXb0ErrL2deDiDK8reUSTOqz?=
 =?us-ascii?Q?qRnibxicbsMQXuFNwV9StXvwAEi/ONM2k78/X0Hw8qWP6ExDgOiGQ0sXuAbr?=
 =?us-ascii?Q?qu9tVkYm6jz41ZcNJY/mBpDg5EbPIY/eHCakBtlVUuGKhuGAkj8+XfmKrUlA?=
 =?us-ascii?Q?raolI8KVinylgCopZSuTaWYhVdZqOSHKDoI/I9wnw6QBAp0LHqzsRr4rqt+M?=
 =?us-ascii?Q?vQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <70EDABE91799EE43968F0B555FCD06D3@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IKJgva2EYGgVJa+qS9N1HGMx16UFdtN6MN17ggH6bYlDYwfkz0Bd513RsgmQqK8IvvKKhjYzd33U71m/46SvyrawFB5HobAXfZEBkAVUlqg7LIZt7U3xvqnt6FkmYCiKeg2QC0T1LSFMxiub2oiGjCI2Pr22eBASaJ/jz4eB1RV06VgHnGafcw4gY9YwNWtkz2AFT0Rs+cXd5KRKSG+kr6Fi3LYM1+AaATbjoHZ3g0jf2HiBgyUQlaFsFiC5CSCiXqEG+VSNO1sp9VpkwGum2WRwv9UaGDEuPlwuoJLEHE+HrmEBAl0cukMRPezxGGoXEm5VSBMimfD5Vipewbte8KqS12QRcfDKcXAshoi7mpm5nzbjfSd1Ur9tOksFEFJeekp7DbcKFWMiR5L9YNvt3HNdMuM4UTXhFRuMTuWYQbDs98cvgPjv3DxXulWpnge7/0/2mdVb5RR6DTNVNri7yu0qKpZlSCByzyc1iuBv6CRbg4X2Z5YMQfS6/fgvOBSJZtPm35gcVIa1LiPiMzOtxKeyZF7v8I1BLaT2kQFV6hmVG6LcJFx7HExJng3HdCVKPWcO+7n6wraHsuGgboXfupkg37+xFXEqHiUjtxu+TnwEv94Bz65n/oPCOzVh/TTsrPOHfdGjSobbjlqNGz16/zQrpGbmDrXhTEy37KkdKi7lFVsYHmY1qAHHsRAcSVBUBTpLs1B2VCTmw9BQPGJjEJh3F1x8R8ekj/xAvDeCET3TCHrAWHjhl6Qg+cmoMvDYE84Y5QWXY0nfLsuuYtxdT+M5F4OnxWasPlB16kMciOU8VMvLYFi3J0aM8iuk0Cx0bliq9kLeFy57f9Vbo35+Ew==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43213559-7bef-4372-b4b2-08db565469e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 21:27:55.6888
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lu8rStj1J1J7tzqJDwB0nTAaSEdjlIqyW4l4JveTxlOq9ezvfySuR3b7em9mugU+vEwY9LB8sBXO+T1h0+KObg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6269
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-16_12,2023-05-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2304280000 definitions=main-2305160182
X-Proofpoint-GUID: lkKtVBKwXyVSV5kVQRVhcp9nTCGo-1Ze
X-Proofpoint-ORIG-GUID: lkKtVBKwXyVSV5kVQRVhcp9nTCGo-1Ze
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On May 16, 2023, at 5:25 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> On Tue, 2023-05-16 at 19:25 +0000, Chuck Lever III wrote:
>>=20
>>> On May 16, 2023, at 3:23 PM, Jeff Layton <jlayton@kernel.org> wrote:
>>>=20
>>> On Tue, 2023-05-02 at 14:14 +0000, Chuck Lever III wrote:
>>>>=20
>>>>> On May 2, 2023, at 7:01 AM, Jiri Slaby <jirislaby@kernel.org> wrote:
>>>>>=20
>>>>> On 08. 01. 23, 17:31, Chuck Lever wrote:
>>>>>> From: Chuck Lever <chuck.lever@oracle.com>
>>>>>> To navigate around the space that svcauth_gss_accept() reserves
>>>>>> for the RPC payload body length and sequence number fields,
>>>>>> svcauth_gss_release() does a little dance with the reply's
>>>>>> accept_stat, moving the accept_stat value in the response buffer
>>>>>> down by two words.
>>>>>> Instead, let's have the ->accept() methods each set the proper
>>>>>> final location of the accept_stat to avoid having to move
>>>>>> things.
>>>>>=20
>>>>> Hi,
>>>>>=20
>>>>> I bisected to this (4bcf0343e8)
>>>>=20
>>>> Assuming you did the bisect on the NFS server's kernel?
>>>>=20
>>>>=20
>>>>> as it breaks nfs3-only servers in 6.3. I.e. /etc/nfs.conf containing:
>>>>> [nfsd]
>>>>> vers4=3Dno
>>>>=20
>>>> Note: Changing the settings in /etc/nfs.conf had no effect
>>>> on my server, so I effected the change by stopping the
>>>> server and poking values into /proc/fs/nfsd/versions by
>>>> hand.
>>>>=20
>>>> Steve?
>>>>=20
>>>>=20
>>>>> The client sees:
>>>>> mount("10.0.2.15:/tmp", "/mnt", "nfs", 0, "vers=3D4.2,addr=3D10.0.2.1=
5,clientad"...) =3D -1 EIO (Input/output error)
>>>>> write(2, "mount.nfs: mount system call fai"..., 45
>>>>> mount.nfs: mount system call failed for /mnt
>>>>>=20
>>>>> And the kernel says:
>>>>> nfs4_discover_server_trunking unhandled error -5. Exiting with error =
EIO
>>>>>=20
>>>>> I reported in downstream as:
>>>>> https://bugzilla.suse.com/show_bug.cgi?id=3D1210995
>>>>>=20
>>>>> It cannot be reverted cleanly on the top of 6.3.
>>>>>=20
>>>>> Any ideas?
>>>>=20
>>>> I can reproduce a similar problem. Network capture shows
>>>> that the server is responding with NFS4ERR_NOENT to the
>>>> EXCHANGE_ID operation, and the client kernel log says:
>>>>=20
>>>>> nfs4_discover_server_trunking unhandled error -121. Exiting with erro=
r EIO
>>>>=20
>>>> That's not the failure mode I expected given the commit
>>>> you bisected to, so it might not be the same problem you've
>>>> hit. I'll troubleshoot this and send a fix for testing.
>>>>=20
>>>=20
>>> Alex hit this problem in testing too, and I took a quick look.
>>>=20
>>> In the attached capture, the client should have gotten back a
>>> RPC_PROG_MISMATCH error, but the server has recorded an extra successfu=
l
>>> accept state before encoding the RPC_PROG_MISMATCH error, leading to a
>>> malformed reply.
>>>=20
>>> I think that the problem is that encoding the accept status too early
>>> means that we can't properly handle failures from the pg_init_request
>>> call.
>>>=20
>>> Chuck, any thoughts on how you'd like to handle this?
>>=20
>> With this:
>>=20
>> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?h=
=3Dnfsd-fixes&id=3D29cd2927fb914cc53b5ba4f67d2b74695c994ba4
>>=20
>> I plan to send the fix to Linus tomorrow.
>>=20
>>=20
>=20
> Oh! I hadn't seen that cross the list. Did I miss it?

https://lore.kernel.org/linux-nfs/8cd5d041-77c3-51dd-a960-7fd8ce1d1271@kern=
el.org/T/#t


--
Chuck Lever