Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c4b7915a-0bb7-178e-0258-fe24ee3359df@oracle.com>
Date:   Wed, 17 May 2023 13:04:59 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v3] generic/728: Add a test for xattr ctime updates
Content-Language: en-US
To:     Anna Schumaker <anna@kernel.org>, linux-nfs@vger.kernel.org,
        fstests@vger.kernel.org, zlang@redhat.com
References: <20230516141407.201674-1-anna@kernel.org>
From:   Anand Jain <anand.jain@oracle.com>
In-Reply-To: <20230516141407.201674-1-anna@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2lwbHNibTFBNWJMK3RlT29LNWp3cWtjSFhGelIyRlhjVlBuc2dmZTE4Ukdv?=
 =?utf-8?B?eEd0cWZZL2JmL0RZTFJ1RUlVaVJwbXVVTUlUL3V2Vkl2bUltOE8xT1M3OTRJ?=
 =?utf-8?B?LzBGZFkrbll6T2RjYUU0cEtWVGJ4U2o5LzU5UldlWEQrNzUyT3lneHFTQUVo?=
 =?utf-8?B?V1Q4endYWVlHYVppd0NtSi8rTGUzb1RrTzlrcm1GcTc3Z1REOC9Udkp0WWFZ?=
 =?utf-8?B?bDZCWmEwRXlQeVBQeWJDVnlCV2x0T09TeERIK3RBaGlRUWdZUXdqTHhTUk9R?=
 =?utf-8?B?WldtT0k0MlJSWUNmY1NCMVo0WGR3Nm93TUFRZjZKWm5TWDdTUjZUQlNSUVBT?=
 =?utf-8?B?c1VMangrczFYSDdIV1V5WlhiK091d0dqb1IvM3ZkY21LZnQwNUVadEQyRHRk?=
 =?utf-8?B?K1MyNllzSW0rYVFBZ3grZVZJbGhuMmxuRDJ5Q3hCMDdwL1JoWU94YXA4ZldD?=
 =?utf-8?B?YWwyRDFraVNBYnJwZU16eFpFVmdMcm5TVXE1OStVSFZpRStPai8rN2duT21S?=
 =?utf-8?B?Mk1mZlNNQytuMzRId1NpV09SNjY4K21ZalJlUGl3U1NzejNGc0J4Tit6Z1h1?=
 =?utf-8?B?VXh1bml1SVJXR1RxN2V5bVhIeWM5TTU0ak1LV3k1Rm4xTEE0R2VCcTRLTnYy?=
 =?utf-8?B?TDZ1N1prTTh2N3V4anJHRUVIZmlyNmtLeTZwN3JXODRwY29XRmhxa2lkVWxO?=
 =?utf-8?B?UDNGZnU1Nlg0cUgzM3o1QzV2WC9YckcyYVRGN2VVTVJtRzBtblFvZS9RNEd6?=
 =?utf-8?B?ZzRNelU0ZnpLUFVZbGNLWXV4RFNHaGJRaUpGU1ZVZ0ZnMlpzbmFFQ3RWT0dZ?=
 =?utf-8?B?R0xRYnIwak5vQ2poakVrUG1iYUZEbzBrWkIwNHVLUnVVZkExTHhjUW03SHZP?=
 =?utf-8?B?YUFYNmNOT21rT3JPSGxXL21nNXowOTVFbjNRZW9GYXI3YnVPdEFtRTdjSEox?=
 =?utf-8?B?M05rNlprY3R0MEo3emxOYm4vWXNjS2RBVWxDNStoL1QvQWMya2FxQXZ2b3o2?=
 =?utf-8?B?VDJNSU9VeEFtZDJGa3JteHV1WXN1WnFMc2h1ZWl0c3pmM1Z2QlZ3MDBDZ3hq?=
 =?utf-8?B?ZFhUazVmRVNHTHNoR3JSQmZqaGt0R0krMmsxelBxZTlPMTdwU3kyWkdtdk9O?=
 =?utf-8?B?ZURxVEkxUGxVdndVVVpEaCt3UVFSS3dKd1Q1T251SWJtRkJQMzd6RFBHeXhO?=
 =?utf-8?B?WWVrZksrTEVyVGVoMmp0Y1RnKy9DZFAzQ3d2OXliajRTaHE4RFUwUm1jb3Fh?=
 =?utf-8?B?ZDJYT0J6Lzk1em5VVEs3UlU5WXVYTkFVbm82Lzk3QlRHOXFDRDdsNzdjcks5?=
 =?utf-8?B?aTQrMGhYRTZYVzh0dC9mTndaS2tEbFZVNThRblpPMzJKMUFhNXdadUV1NUVU?=
 =?utf-8?B?M0h1R2tCREFxeTBlYlNOeTQvM3I4YkFmcVVkS2hHeG8zNi95S0hJbjFzU3Yv?=
 =?utf-8?B?T2NFM0hTR3ZnZnEzeVhQV09kc3BDNllSNkVldDhvaEN1YWl1UUlFL0ZwaHVy?=
 =?utf-8?B?SWFvYnlud0tCWlcxRHE0a093TENoMFNORDA2ZUhyMkFWMHN3Nkp4djhWWmdV?=
 =?utf-8?B?UjkwR3dxTGVsbDVnc0dNNU5PM1NaRUZpSE56b01Id1pNUTBseXZPelBKRHdR?=
 =?utf-8?B?dGxDUG1HdFVSdDNLbmtTblJKTUFKdkF1dDZyUjFoUHN1MXZ4YjVtN1Jhdk9Y?=
 =?utf-8?B?ZGd6aUxzM3hFc3JQV2NwUUo3dFZGRlhkSFZpbE9uTjUvUmkrNkpmdHRWaXdH?=
 =?utf-8?B?a3pPYlM0cmlTbDk4ZDFwcGZjNU15MXlZRFhCR0xaNFJ1bExvZGdsMXNZQTZT?=
 =?utf-8?B?TGlYYkZSYnFmVUVZOWIrZ0N4dm05QTA2aTJDUysyRTlkUVpJU0RJN1JROFlI?=
 =?utf-8?B?Q2ZQTzhrY25ORjFYMFl1TjRqSEdPaUN2a3JYb2lnaDRRRE5JR3l4YUd6NC9u?=
 =?utf-8?B?WHFQQkpMa2szYjhQcHVzNzIrcSs1YUQ5WFpNOFRiUFVxbHduTlhCcEtsTnho?=
 =?utf-8?B?WFMyekp5M0c3aXBtTUtZbDdOMlVRZGJNSGtFR0g3NXFqZENIZGRxZVJsMnNE?=
 =?utf-8?B?NGgzbm1EQUVXNk90WWlBSkx3bDEyQm9WUE1iTjllV1hSSE5ZQzVCYXJweW1I?=
 =?utf-8?Q?ySDnaQx1uLSOSrsdZV6YHsZqk?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Pu9xPns9G6era7memjOhCRfPT88pMuXO0LYZJFuoJu9Qw+djsypMzw80D5LBxL4Ov/Fk1dZqclmo48TKio/I/cil1I/f3Y5On8YdfCWduEVh3lUvpZtGoRDSe9SL0Z02gDPO0Lg6QhW9WxFVhqp3kkJTDqT8qzy1pkY9bVmaCsfT+XkFCWDxWHp5lS4rTjJ2gTZ6o26SjUeqTB0DrHsgyJUa6cUxj8ALJtu0VaEmC1z+90EJhJg5H70Jh0TDF1gu5LuazrqPNzh5RosNrSVvwS+OGXy7SzotjNRKnQX9Go9ngQYr+Dy78rkrbvBCLDdXktfB36fjwVpV0PAg8Vp8/Es+86zsgSmyEhZHJhGChl3UFHPSU2vQQDWSrVD4jdSp8hLULBbJAezSAYIpMm7nH2IKZ/QlMPm7Sej/hkeebg/U+CBQ+YWN1iD6N1LCOTbZVmAnLBbKwPd4Ar/g8UzqWqTUt+fewJtfW3Y+gNbl/EhbLCgsYLR8swqpx2NWBDKMOoog86FgtQW9ITXhXHfP31VmaryE6txCWbSMXwumR9IMFyNssPDFmJHlGgAAP7udyRNmDbgCwvXYdM9IyjWjg7PZRJmJXBuda4H8tVtI0lT9rtSAdNeg6VLJytWWQ9GA7H7QWxIBYyos6e6WHwwhDG1YUjJ99kScoZeKH5pl6wKdQS8Qt4eiwGKMsd//nz7xY4yP1H9CMjgAp2/n2FJHwLd+sdBzMCkAze4LvFFXJgEO4QxFY+eR5LB0HWugzLUKQbxNydbePx3yYJGg94LcmVdOfDQEvllhjXjoB09JGTSgyhyAbSxz60hIP73LM0mF
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5a27d05-29c1-45e6-0dcb-08db5694488d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5706.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 05:05:07.9261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1l/tW9wWNzs6XUBrd/AUFx+oZwDZEAwxghkkZ0ucNz1aKHt5a/M08kKUk1Gglb2R6wqcgZJhZWbgNWV+g+nNIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4568
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-16_14,2023-05-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305170042
X-Proofpoint-GUID: 8v1lq5Yg5Yab-dwKNIp3UggiXEur2Ou5
X-Proofpoint-ORIG-GUID: 8v1lq5Yg5Yab-dwKNIp3UggiXEur2Ou5
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On 16/5/23 22:14, Anna Schumaker wrote:
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
> 
> The NFS client wasn't updating ctime after a setxattr request. This is a
> test written while fixing the bug.

You can include the '_fixed_by_kernel_commit' field for hints
on unfixed kernels. With this and Darrick's suggestions, you
can add my RB.

  Reviewed-by: Anand Jain <anand.jain@oracle.com>