Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <653b33f74a4d9c1886db230b873146e388543739.camel@kernel.org>
Subject: Re: [PATCH RFC 00/12] client-side RPC-with-TLS
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <cel@kernel.org>, anna.schumaker@netapp.com,
        trondmy@hammerspace.com
Cc:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org,
        kernel-tls-handshake@lists.linux.dev
Date:   Thu, 18 May 2023 09:49:17 -0400
In-Reply-To: <168426587118.74246.214357450560967997.stgit@oracle-102.nfsv4bat.org>
References: <168426587118.74246.214357450560967997.stgit@oracle-102.nfsv4bat.org>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1 (3.48.1-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-05-16 at 15:38 -0400, Chuck Lever wrote:
> Now that TLS handshake support is available in the kernel, let's
> have a look at what is needed to support NFS in-transit confiden-
> tiality in the Linux NFS client.
>=20
> These apply to v6.4-rc2 (actually, net-next to be precise), but
> previously they've been tested at multiple NFS bake-a-thon events.
>=20
> ---
>=20
> Chuck Lever (12):
>       NFS: Improvements for fs_context-related tracepoints
>       SUNRPC: Plumb an API for setting transport layer security
>       SUNRPC: Trace the rpc_create_args
>       SUNRPC: Refactor rpc_call_null_helper()
>       SUNRPC: Add RPC client support for the RPC_AUTH_TLS auth flavor
>       SUNRPC: Ignore data_ready callbacks during TLS handshakes
>       SUNRPC: Capture CMSG metadata on client-side receive
>       SUNRPC: Add a connect worker function for TLS
>       SUNRPC: Add RPC-with-TLS support to xprtsock.c
>       SUNRPC: Add RPC-with-TLS tracepoints
>       NFS: Have struct nfs_client carry a TLS policy field
>       NFS: Add an "xprtsec=3D" NFS mount option
>=20
>=20
>  fs/nfs/client.c                 |   7 +
>  fs/nfs/fs_context.c             |  55 +++++
>  fs/nfs/internal.h               |   2 +
>  fs/nfs/nfs3client.c             |   1 +
>  fs/nfs/nfs4client.c             |  18 +-
>  fs/nfs/super.c                  |  12 ++
>  include/linux/nfs_fs_sb.h       |   3 +-
>  include/linux/sunrpc/auth.h     |   1 +
>  include/linux/sunrpc/clnt.h     |   2 +
>  include/linux/sunrpc/xprt.h     |  17 ++
>  include/linux/sunrpc/xprtsock.h |   3 +
>  include/trace/events/sunrpc.h   |  96 ++++++++-
>  net/sunrpc/Makefile             |   2 +-
>  net/sunrpc/auth.c               |   2 +-
>  net/sunrpc/auth_tls.c           | 120 +++++++++++
>  net/sunrpc/clnt.c               |  22 +-
>  net/sunrpc/xprtsock.c           | 343 +++++++++++++++++++++++++++++++-
>  17 files changed, 677 insertions(+), 29 deletions(-)
>  create mode 100644 net/sunrpc/auth_tls.c
>=20


These all look reasonable to me. For any that don't already have it, you
can add:

Reviewed-by: Jeff Layton <jlayton@kernel.org>

I'd really like to see these in linux-next soon, so that there is a
prayer of them making v6.5.

Thanks,
--=20
Jeff Layton <jlayton@kernel.org>