Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2260127rwd; Sun, 21 May 2023 17:07:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4DvV3kkT4XhzrbBja+pUvr5XwSZJaKmMEymQyxeCwxoviGy9BKxApQ67x4sA1bpaGfu/7F X-Received: by 2002:a17:903:11c7:b0:1ac:8717:d436 with SMTP id q7-20020a17090311c700b001ac8717d436mr10781942plh.60.1684714076862; Sun, 21 May 2023 17:07:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684714076; cv=none; d=google.com; s=arc-20160816; b=phxAcOndO8z8CPeEDY6YCEbVsuI5tsxge8PYczJkON0pcZgtZGiPRXRq4cm2ncq9nG sIr3hnWSPP6ygcNy/Q7qH0M7il5RN91uhyyOylRnj49stAjZqsLeUgf7u0g9ntOyCGaj p2ZLdcCdaQHosTYxVc7GCQljwgrfRsSo3Vq+6qte8Bd7Cy8xAID/fmWxJZiv44e4DE1y flIGenUex77t4RkHTf9PqIY5VcIaqkaH5Gnz5oA4WPu/SNxzqTXsKNaMU0WW2V/Zx2Ua miKqVTZD+nRMfD4vei6o07kaYUyGorJ9gNjEYGEOhBEFpNPDxDGlILqJ7frL0Ry5s4a2 XzRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=VKZkdHlo0vaovrHKUVt7LDP5fGNVxr3UGKfBoA9uSSo=; b=yPid2N3NiRDZCow0OsMt19sbv9rH+CUEFl4llvqc3h3vDIPLDkepC88r5PnTTly8ja saVj1IAt165A4esuxyUZ26+lQTBqO3SqwNT8Qwi45mkljFCA+ciOCZ2Znc97d9jjUHep 9GB7lWt56pLsUr32OKmCpjvfgx4aOIBZfEHW+8RjnZYkVPNWEnDWThqxgZy8BeAnARDt FsoXBTdDi9cly4Fp+vYp3fJkRneQyfB7zRJK6H4H6ReUFh+PadxrZ8xtv5a13Zd42pdi lDcMx7C8GbFHNAWkSbwjWT4JczxNwgRyhJev7TTTArGQK2yguUR6npyQ++cY5pvbst1I 6chQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jinVW+8e; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hi23-20020a17090b30d700b0024de6b5e2b5si5748595pjb.155.2023.05.21.17.07.41; Sun, 21 May 2023 17:07:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jinVW+8e; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbjEVAHj (ORCPT + 99 others); Sun, 21 May 2023 20:07:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjEVAHi (ORCPT ); Sun, 21 May 2023 20:07:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5EBED1; Sun, 21 May 2023 17:07:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 631896174C; Mon, 22 May 2023 00:07:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21004C433D2; Mon, 22 May 2023 00:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684714056; bh=logUhuMuaDvrFGp87a3eXuBZVgOPH38ZQeOk9oWMxhA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jinVW+8eNfBmMJvPLIRbSMrX3C+ysBP344vv+qMi84FjV2X+zzFwAh8xh+THsy/A8 f7n7CscOp9ldNzbMYKqQROCTt+AS2stpbpTN5qKl4tiJAwkxedNRln1tS95W+JHVfL MlrT+lXxAxiWe2UTwO7ndf3emdaYv3zxBJ5GihMIvhIezJ3AGMv4m3w3sorDMEvyPf FkNSWSW6DtqVfjWPCwUzSDgy0Ug7/6HBtXxZfFSyEx8EAJMuiEkELi3AT9cEPjV+k5 p0DQ1x6g3QKPp4NSjgQJvj1BT18DFRjljg71PKaVdhIQjyEcKo9DHNhzPm+akQ6HSZ HYHWZZRzzH9tA== Message-ID: <73104483-a4ae-b7e9-2383-c28714e9859b@kernel.org> Date: Mon, 22 May 2023 09:07:33 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 09/13] iomap: use kiocb_write_and_wait and kiocb_invalidate_pages Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-10-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-10-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 5/19/23 18:35, Christoph Hellwig wrote: > Use the common helpers for direct I/O page invalidation instead of > open coding the logic. This leads to a slight reordering of checks > in __iomap_dio_rw to keep the logic straight. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research