Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Dai Ngo <dai.ngo@oracle.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] locks: allow support for write delegation
Thread-Topic: [PATCH v5 3/3] locks: allow support for write delegation
Thread-Index: AQHZjQiIht0IszKu60KDnHp/yj6+RK9piRmAgAAAVAA=
Date:   Wed, 24 May 2023 15:09:44 +0000
Message-ID: <D8739068-BCAD-4E47-A2E2-1467F9DC32ED@oracle.com>
References: <1684799560-31663-1-git-send-email-dai.ngo@oracle.com>
 <1684799560-31663-4-git-send-email-dai.ngo@oracle.com>
 <32e880c5f66ce8a6f343c01416fcc8b791cc1302.camel@kernel.org>
In-Reply-To: <32e880c5f66ce8a6f343c01416fcc8b791cc1302.camel@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LyOZooXJlpCz4n6saDpisnV9jEmucsoL+Me/WptaH2J9Ebdgm5r6ix6oZbrM?=
 =?us-ascii?Q?iNiTWLwoEVKp/gVZjHyDvHOXq7RTkuIoLDPX97mpQgFuVjGvBPrUottWprvq?=
 =?us-ascii?Q?1OASuy5KrEz/Ys3V5ud3rWx3mRmw0/9bd5nXJ2i/5YNs2f+wxdygcTJ9//6u?=
 =?us-ascii?Q?GugH+U0t8SwYDlInFCBHijehwei6YfPPsSJagZi7sRT8LOENIosGqzc6FETn?=
 =?us-ascii?Q?hmr+U8/v848Wq1mPfEwYBVeUvCAZACxCBG9Sc4N5i7oLQS2+PTRwKMycKwyK?=
 =?us-ascii?Q?1FFKT9pC/23N1bpDhdfjZ0iheyZCYYVwfTFO3jyA9rQeLdsCtFm1C2tM0KtD?=
 =?us-ascii?Q?QnMccPAlq5C/Cm9GIN4Zp4CTsUH1zq9yX6c1gMXux/EozwIg0TQYte6UerjW?=
 =?us-ascii?Q?Z7p4kjpah2DF2rBe+UH5wgkGnH4sWz8cYZiswFaLEQrGxPSPn7QTu3Qc3P6k?=
 =?us-ascii?Q?tul0dVPHIlJ1CtxICzsOn12FJMNWshwTZjB1WTmzcWNKSo9a/gjiofs3/FuG?=
 =?us-ascii?Q?RRIWQ9OtRl842ncYe3d6SLSCDUp7FD62oVlDxRSZWT/67fPjiGDhw8oYZaoo?=
 =?us-ascii?Q?q8jufhrICnp9Q5R6fTC9iS//ZwsbVsWyYZLQuhOtB77/ITWmJBjtEgXjAA8M?=
 =?us-ascii?Q?K72NrT62oVCVW9iDxzAsgKVSMiJfcAh78kZjH6OwFSIPQ020QO6g6a+quE0J?=
 =?us-ascii?Q?1p7yVv2WlGhUs1Z9dVxz6bLIei9HNwmCm3X/YfJNAGdYYzeceAJyuIxd8K7K?=
 =?us-ascii?Q?lDzz4GksiaJrXW4FIZst+qTfHGY9sCbJReSNZYpEqTG6RQ1oHpOtULBE6EdL?=
 =?us-ascii?Q?5odiku97Xi0TrDI1yOD6n0dqs94ikpWTptfl9F6TpSUuOyf3iDcXEygSLDyX?=
 =?us-ascii?Q?HX3sR2eoew7bfsWQ3YwuBSA03yMdoJPirAu6MCw7cowXm1ZOrP14aZia7KRy?=
 =?us-ascii?Q?Z9C6cY/Zg3H9eUCVP+KBlk4WA9PvsMx7kNnbBDlXSgf257duiO4yymltqVUh?=
 =?us-ascii?Q?v2vGKj4FDmAwIM7Wt+S04WQblHnMS8aiQSq305cT7aZIJAfDc/GPPcqAnCA2?=
 =?us-ascii?Q?n5pjQ2xOxF8UG/J3ZI8VLqNJSS5hp7MjQg4ugMkmOaZh5C6e6WV24o4jpyLQ?=
 =?us-ascii?Q?FAekcSvtUwwnvbzsFLEJA6bjdpottA3hrwtqaNHsMqjvg87tzj9Y3pELeay1?=
 =?us-ascii?Q?a1/UT+045BZ4DwmPHKGaxnsXxvqOBkVHh/AwCZXe6tBejV+vnEwBtueYKA3g?=
 =?us-ascii?Q?M+ijZt+rV/ITq7uZK3NZV7eRRbowocHeZiM1EefECMz0ZUMd/0hX0RGLVIdv?=
 =?us-ascii?Q?0Z0UtArz/OxwQWjqzQMxfI9qVm/+PHOxIaQ0cM3HladSIejRYCgL3y9gb90o?=
 =?us-ascii?Q?iBScZ8aaYmHA9TDLCb95syrfy5kY6mvj6F2gAghRef429UT7WpkRcqDAcjhg?=
 =?us-ascii?Q?8knlgVOgol/ri3DbcElpXmVHd2fyH/qhLXSvKBmEyiCJakQp4UT3pgcnNL6E?=
 =?us-ascii?Q?NBxhVfBc4d8ELONxh5kY+vXM/jiRcWLml/FC7aJUpE6tX9HY7dzjAW5CANCX?=
 =?us-ascii?Q?P+rjvgkt0PvmoFP/kMXlAnAoO4pDx/NSizqSkxBpR2aKM81eBNcYQECDEKp1?=
 =?us-ascii?Q?Kw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9F9B0D8CAEB35E4E8A35658BB8EF050A@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 0R2ttkTztp28u4DoStfH3B8lUj1SYb1s2AE8MhNw9EsHPkpyYoJcsfP3hhQhhTOQXCY/WmLOX3zGytd/QBc3IUQkhU8BdaSty1/qDRq7ilI0tPFYvmfDQTnzblGsqA5nSY+uKC1FigmY6Onj8qOfFPnmdGtQrm9mzXRPHP0Y0T4aGTVVAZ4wJWfyrsVBTKnSWPH98kf9FF9oVNOmyZivx/h/sYTNerPcxctZiiSsweEJxSiMjHrpS5pWXYRm2m9pbqeSb2jhR3kA9iGe5TnidBKkxwVUkLfAuF9Hfvwc0W30AHmDR6fgTXqXeGQZpgswd2Cg5geVwH2fkdlZ7l3twdkK+fOIV3j5P2JowtzqgSBXId+1ADJiML7Vh8UWh9WxOdAoZihAtgtWbjDYdoEP/yry89d9Moyc9BiaNRc4Z5aHPv1OK/im95h6G843mQB/UMpRYyN3Kg3caWU2qn/fT7c9Bkgh3ELD3tlHhMy2/7QnXJ1td5EdyDXtl9C/cAyG0V3+ewGoglTIpvVU+iN+DRdyBdewIk6TwlYPHfL0RVVfntTMFMedAgJeeLSbsftg1tpTx1PXNe7AEzwRmdtAtD6UiQ4Jyo8T9bZOpx7ije0uybstmLVUU9C4msh8DLrN1iotKgbopxbkrXhcTxlVsU+1gO1eUVC3Y+nPs8G7PTX755mnSosapWsuv6Hl231rc0E8ZvT/WiOLNAdb0mVJYFRFC/RaZlOeEPdwvbuj19YkGbwKy8JhRriwMmivip2r+Cm8HJ2g/0PUNUtgenPuZSEODhq77qGlzkAbguRPc4M=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e2d5b29-7760-483e-56b7-08db5c68e84e
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 15:09:44.6592
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xVxnG8aCDm5XvCZ/HKx9dm+h05ZTe0heqw5/Bc9ExCqbDfZ7rh+zDX7IUMU0xRqN/GFm955WdsfKzp2cvp+2/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6056
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-24_10,2023-05-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305240124
X-Proofpoint-GUID: Ct40mKgXi6h4p1XbaPoVNbbZAmZ32YvZ
X-Proofpoint-ORIG-GUID: Ct40mKgXi6h4p1XbaPoVNbbZAmZ32YvZ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On May 24, 2023, at 11:08 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> On Mon, 2023-05-22 at 16:52 -0700, Dai Ngo wrote:
>> Remove the check for F_WRLCK in generic_add_lease to allow file_lock
>> to be used for write delegation.
>>=20
>> First consumer is NFSD.
>>=20
>> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>> ---
>> fs/locks.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>=20
>> diff --git a/fs/locks.c b/fs/locks.c
>> index df8b26a42524..08fb0b4fd4f8 100644
>> --- a/fs/locks.c
>> +++ b/fs/locks.c
>> @@ -1729,13 +1729,6 @@ generic_add_lease(struct file *filp, long arg, st=
ruct file_lock **flp, void **pr
>> if (is_deleg && !inode_trylock(inode))
>> return -EAGAIN;
>>=20
>> - if (is_deleg && arg =3D=3D F_WRLCK) {
>> - /* Write delegations are not currently supported: */
>> - inode_unlock(inode);
>> - WARN_ON_ONCE(1);
>> - return -EINVAL;
>> - }
>> -
>> percpu_down_read(&file_rwsem);
>> spin_lock(&ctx->flc_lock);
>> time_out_leases(inode, &dispose);
>=20
> I'd probably move this back to the first patch in the series.
>=20
> Reviewed-by: Jeff Layton <jlayton@kernel.org>

I asked him to move it to the end. Is it safe to take out this
check before write delegation is actually implemented?


--
Chuck Lever