Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 25 May 2023 12:19:13 +0200
From:   Jan Kara <jack@suse.cz>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
        Chuck Lever <chuck.lever@oracle.com>,
        linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] exportfs: check for error return value from
 exportfs_encode_*()
Message-ID: <20230525101913.vokjxsthhoxsz6xk@quack3>
References: <20230524154825.881414-1-amir73il@gmail.com>
 <61146b7311e44d89034bd09dee901254a4a6a60b.camel@kernel.org>
 <CAOQ4uxjY_KqETNDDXYBGgXvE_7JTWStSaYK2CEjfj_UUzmLbzQ@mail.gmail.com>
 <0a140464f921baf88a0295e91a43bbd92faa2f2c.camel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0a140464f921baf88a0295e91a43bbd92faa2f2c.camel@kernel.org>
Precedence: bulk

On Wed 24-05-23 13:36:11, Jeff Layton wrote:
> On Wed, 2023-05-24 at 20:24 +0300, Amir Goldstein wrote:
> > On Wed, May 24, 2023 at 8:05 PM Jeff Layton <jlayton@kernel.org> wrote:
...
> > 
> > Beyond the general idea, do you also ACK my fix to _fh_update()
> > above? I wasn't 100% sure about it.
> > 
> 
> That looks like the right way to handle _fh_update(). I think that
> should also make it also treat a value of 0 as an error, which seems
> like the right thing to do (even of no caller tries to do that today).
> 
> Reviewed-by: Jeff Layton <jlayton@kernel.org>

Thanks! I've added the patch into my tree.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR