Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dmitry Antipov <dmantipov@yandex.ru>
CC:     Jeff Layton <jlayton@kernel.org>, Tom Rix <trix@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] sunrpc: fix clang-17 warning
Thread-Topic: [PATCH] sunrpc: fix clang-17 warning
Thread-Index: AQHZlJYb6vjx06AMBkGvsuYKh+iggq92BGoA
Date:   Thu, 1 Jun 2023 14:38:58 +0000
Message-ID: <2D3D2D8E-4E7A-4B50-A1FF-486D7F6C26D4@oracle.com>
References: <20230601143332.255312-1-dmantipov@yandex.ru>
In-Reply-To: <20230601143332.255312-1-dmantipov@yandex.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9+/4ohGt7zFxGHoCVLC2PFVkHX+VgF1Kd5g0IuNZ6tBy5i4UZkwc9ilJfNdZ?=
 =?us-ascii?Q?j467i04SMA8gxH/l4WwPzJhCYr/AlOGq8eEvLWvdZvYOO6L9sORFI0iUx1Pp?=
 =?us-ascii?Q?KY528dOsnvGfvgoquDpngTTILHkTwaEj96q5ZfsIkbf7YtDiWHhZKYOEk1j4?=
 =?us-ascii?Q?XdgkCeYGE7VZC2MesqBtzyDY6uNdk8yfk6SUh/OlZ32ii7j5jjEy4qsCDdpT?=
 =?us-ascii?Q?L3zd0gMhyEoNNyCxiPKTADExNclL090DLRwyDdUUTbmaLfWGK3/v1TV6sG4f?=
 =?us-ascii?Q?RxdT3/WULiPUiVuK/OgRTkQHZSbQc+nc45IsR/ox1V0gNojJcB10XNyVjAmH?=
 =?us-ascii?Q?yJZ+b6mgeAK3COsS7+UGEzpWmUn1QADElvBwE6Trn6jPJtFp2mjCvF5abaTn?=
 =?us-ascii?Q?6WYE0Yz4EBHLdrWFh+nuYSHGjqTc0LaMI8L2vW5nlH6PBoibNNG5wqTU3d8i?=
 =?us-ascii?Q?gNGffZ9yl6FL+eaYpWvlObkc3cnNAWjNFMUvzjHIgD7RL7khkacoiT5Sj6Mi?=
 =?us-ascii?Q?bQSo6M5jd/ZLmwUM/4wvFJYUp5FLwaU1LtJxUk5NdG/JYShNsojc++xOHfx6?=
 =?us-ascii?Q?FyNtp9IGwbt71PSAaXvplvX0mL0fAOl09BZ8H+2/Q6Q7Td0vSgAmmk/HDJCd?=
 =?us-ascii?Q?Ywi66A02GwbY3seyVH8RUXl/nOowoudmt2i3fjgZhwBI2nLzMoqGqqXlIPzk?=
 =?us-ascii?Q?xVmRhkHE2dTfwlG0mhAWhT9SV1Y6Rns52WMtLniQZXVJtGsmSG+040r7pJXN?=
 =?us-ascii?Q?sbAaTiNk7XlbhZSaM4jFExeCk4Gsl4g5nkS6QIVwN7KxiQUV2cLEWxWbi0IR?=
 =?us-ascii?Q?eq0rA9VQGWpLAgDTNYnFiF+qSYCQ9xNZ3DJctp1xqmTPQb7GF/UjahyBN17d?=
 =?us-ascii?Q?YJTyrhcayNAny6sx/COlytG305eziGqeJWk4Z5pAenbCrGbDSezy1nVlLTQy?=
 =?us-ascii?Q?zDGx8B4BXSB0ByoLtE1xbyp9wfAwY43mG6Da+Fd57KH+XQSaF0QDwCcJOa59?=
 =?us-ascii?Q?wrBBNn7i8aDpIkWBE6ai1aXMtoLUdkyu7hfPW76bO4HXDgviJtb1at8iVGwA?=
 =?us-ascii?Q?VZwld0l9+iodcXicc6+5KoFnlCzS9VWw2zjUQXf1tDdHdlnBDTtDQ5Hj/VaS?=
 =?us-ascii?Q?2c6Og+Py1pEpA51VSmuHr0gOAxfD3eXGXo2U/hRy5ebdFfa8le/bbWrZGuv1?=
 =?us-ascii?Q?zW9KlkRebEr/G8enMmv6gorvPyMQMqq3CgLf08LIpI3iyl4oIZwaxZMS1elq?=
 =?us-ascii?Q?FHqJlnneUGk2IAPzjEdrj5CAY2V7lvGLFMnMKlO/+aAn70crHkxLKgteb06Y?=
 =?us-ascii?Q?9xObdOjJt3d9on9FqPXLIQZ1bhZOhO6HOS13BH0JbOEU8+fPccirZF1D4mm3?=
 =?us-ascii?Q?Fmhn04TILNzHBg8r6T4bDbrqTDwZEaDC4Qie6NbfCLrMFA+w21MhGQr9tizT?=
 =?us-ascii?Q?c21i2d+o82Ie7oWKbtiRoBkA92yYaLmjqVkfreuHcjPDyMjcaX2cxjcAnSs9?=
 =?us-ascii?Q?tTymfXuG8XSKYjHy1nMTk6OVqa9pfz239AzAYioergM94L0IRG5FE5iJVh18?=
 =?us-ascii?Q?bygGzVs0x8rVku4OdsX0aeCRPIYCNROKFo8HQPxxI7uek4fJZWtssU8LtZ4Z?=
 =?us-ascii?Q?qQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3C10D17724D72E448617FD47B2CCDD4A@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xiw6Kmo6/AKkgNrw3Oo/FSlhUheJ8rzugjl7GC9ERY22Cog3HEQISeDol+R7inN9vRdwzTuN2NBvw5cmjx8VVTL/97liuJX3C0Bd1tdSg1Nb7ELeEjk5Ho7STB8/aSB4epfQ8pQ7BUZhyt+a4vRdHmfguZItZZ/UuHdYv4C710ndYkSJvyleDCFlczTGluKIWOMgZgWkmhzL/SaGKyPg56MJyEya7pBL2kqH3u11KvxRg8HMyOog/fRrFCwZ8C1sgSg3j8/clUzLDZszVybAceL5JXFAYDfSP5yALxn4ecNTpmJ2uJaqSV9pFcip2XMN110D6AX3fGBJGYEaEh/cK3hpwBDHk+FFBRTywym2p8UuntULUXgPIS/vkvcGtRxqfWsGFRicgulaLo28hm7bHsS6gfDS+7dRF5AwjAOcDXTn4QigxNtKSmmnvHWIbgNGFcqKUOqddTfg6Nz8U2pf94d3iYj43Gj/t/VlyQwRl4awthaNZiu8hzgOKC7PCFAk0Ob1zPLB3bvflm6kxzVvmDroKuVIp5ZXQ4b21J3EbUqdOmQQmxuySU7d8Q+pAtGDqYjzRsKDtIGg7ecA5KVIfXOPmAQKVTeKPU3MmA2gce4Bdrnh8jk6cT4nGofhZ2b2ifa3CtvvMEsen41GcDgUcsY1KPpf4G5Uioh568jwesTtN+V48noXlXv/YsZ9070lyDQR5ZtIYkj+UcV6Bm+vVQ0+j7jVyOfnoTndaiPtKphc8AtuVLrLZikezE2biJ+M1T21r58RmMvsFjnXlqf31fWUlA2aWFf0dtpFz65RMjDepKVY66cNPofRVhFg2V/H5fjB+Gos15inGcADt111Ux1KJkKpIs5IGaxWnBZ8mseqUBUg+bjqOk72MEfuby9T
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f61414cc-4220-40a8-ab35-08db62adef2c
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2023 14:38:58.4050
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lmkYNN0EsVwUHCZ3dv/DgvL6q/76KZt7hXlSkudUz8K9MV6m6Npq2dtqcoEAil03ADJNBx5LyBOqdOjQhVfqMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6667
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 mlxlogscore=757
 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2306010129
X-Proofpoint-ORIG-GUID: Jtzq-UHpdMrrH-Yl7GiMGXA9uzKXQB-g
X-Proofpoint-GUID: Jtzq-UHpdMrrH-Yl7GiMGXA9uzKXQB-g
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

[ adding Dan Carpenter ]

> On Jun 1, 2023, at 10:33 AM, Dmitry Antipov <dmantipov@yandex.ru> wrote:
>=20
> Fix the following warning observed when building 64-bit (actually arm64)
> kernel with clang-17 (make LLVM=3D1 W=3D1):
>=20
> include/linux/sunrpc/xdr.h:779:10: warning: result of comparison of const=
ant
> 4611686018427387903 with expression of type '__u32' (aka 'unsigned int') =
is
> always false [-Wtautological-constant-out-of-range-compare]
>  779 |         if (len > SIZE_MAX / sizeof(*p))
>=20
> That is, an overflow check makes sense for 32-bit kernel only.
>=20
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> include/linux/sunrpc/xdr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/linux/sunrpc/xdr.h b/include/linux/sunrpc/xdr.h
> index 72014c9216fc..b2d5dc89cf7b 100644
> --- a/include/linux/sunrpc/xdr.h
> +++ b/include/linux/sunrpc/xdr.h
> @@ -776,7 +776,7 @@ xdr_stream_decode_uint32_array(struct xdr_stream *xdr=
,
>=20
> if (unlikely(xdr_stream_decode_u32(xdr, &len) < 0))
> return -EBADMSG;
> - if (len > SIZE_MAX / sizeof(*p))
> + if (unlikely(SIZE_MAX =3D=3D U32_MAX ? (len > U32_MAX / sizeof(*p)) : 0=
))
> return -EBADMSG;
> p =3D xdr_inline_decode(xdr, len * sizeof(*p));
> if (unlikely(!p))
> --=20
> 2.40.1
>=20

--
Chuck Lever