Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] NFSD: add encoding of op_recall flag for write
 delegation
Thread-Topic: [PATCH 1/1] NFSD: add encoding of op_recall flag for write
 delegation
Thread-Index: AQHZmNBl1jZeoclDdkSsnDrqx8vSea9/YBUA
Date:   Wed, 7 Jun 2023 14:03:49 +0000
Message-ID: <71B00613-DA0E-41DB-BDCF-14F866C73A37@oracle.com>
References: <1686094862-13108-1-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1686094862-13108-1-git-send-email-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J8GAydXK8hGifWVWke4s3JddXh76HezWR9Z0MY6KkCpLlyyWndSUauNBSB3i?=
 =?us-ascii?Q?rX7zcIiySLwD/AGpwHLxUQBBzresbG6KttXVBYhdBrMRF2hU6i2obJXxAJVl?=
 =?us-ascii?Q?XB/6hG1nwFmheRvlWPlGxnrQcuVml3RnJng55UXJ1pJ+AqMzWwf9CJpTphcs?=
 =?us-ascii?Q?rLZVlzLs5Rorwo99zrL/YSwfB6TR34iRemG6f0wFAXf0JT3Ras8VyIL3OrTZ?=
 =?us-ascii?Q?HRdN4KGzwy3rafOgBVu3Op3GgZddbNmun4qdgyYeiK49Wjqm84TzJ7XpQs5d?=
 =?us-ascii?Q?v+CuimKK296PLyIm0HkqTyKxT1vaNUmkNdZB/A/YikGwrG9US3Fku0JXSiTv?=
 =?us-ascii?Q?qLqp2J9a4OmT1Xs9LRfct7LTct3KAI2cYc761q65waZ/16v7FSd8HrYXvLVa?=
 =?us-ascii?Q?x1hfK3o03XcoQ1ZG355vviag8rItVgXJ1Y/ftxc7e4rZZatZatZYcrlyWhPd?=
 =?us-ascii?Q?8rqPZbA+XCWV35R8hk3Atl546lvROQZgcYQkZttj6niRlVkzW7lgymdPnCQ+?=
 =?us-ascii?Q?x5IGGVEqZaB+HMk8cBQ5x7xSLs1GkTaXalH7r7bap+gFGAUuRfK9XYzBlbIb?=
 =?us-ascii?Q?i4Qvf6KnnGqp7S0ePsjWBZqb8wH1KOhvD+Yf9VH7/NKWh1dQYxi+Ckis8RRy?=
 =?us-ascii?Q?WwO85cIGR1OukcmO+hioWIPKUoXMsVPKo6ajBN6hoawjHNUL8jJTIdQN7/f0?=
 =?us-ascii?Q?LLKF7F6wKNQ8v1SI/oYpiuLG1M6hDHh/mC/cqnVOFqkxIcD9RhslBKsM4TTF?=
 =?us-ascii?Q?rGiiLNkOC8AwfyF8KmrKv6TccsQ0QZ6jzdb8R3n9rsucc55wkGBJ4/A7jvEx?=
 =?us-ascii?Q?FRmMv977lkru6i7+ww6a/hQUqPhUjjTQmmv39OMrh62HqKEu0nNBRHk89W1U?=
 =?us-ascii?Q?EUUb80XWmTFmntKFuPqj2RUuestUu6fviqhcSYS08H/bvtiPG1CEXUTObXxU?=
 =?us-ascii?Q?Eg6wByF477nsryV9COfM46fEJA3V8cisI+HMYHvFqjwBbPeF4hG3sDfgQmaP?=
 =?us-ascii?Q?YRc2u1FJqM/H8hjZxPV83xlqWMbNjU44YKtBONaMgw5Ki1a01jD/HYjgyu6/?=
 =?us-ascii?Q?Jy0IFBZyyh4igUMi5a/or1KI2lggbUInPSSAZsl2flSow+2JugoDei9eXmqd?=
 =?us-ascii?Q?16SDf7H20R2DiYRdAJ2dkwJdHMwQ7jlY/IxyuE22MzxlzfUNvX8ie33LKh8h?=
 =?us-ascii?Q?otalCfgqOu4hsinbJfIX47aYQC2pfT1ziB+l7r1JhCscNRVe7qy/P3zVZyXG?=
 =?us-ascii?Q?Sq7J04A6JY94GgPvIaUIW2pYP5MaW7Owe3iRRJQoIKp6oIL17tymSrOxPP9O?=
 =?us-ascii?Q?qU4xxmG8Eqf5aZamJZ0udtJqXW9vY+bNgOm2KAKHkUIz7EZfstaRAAHqSPnD?=
 =?us-ascii?Q?hNB1OvfNTQhqJ7KCCaZ8ILZS2GvLXFhKTm0R7lg7ybNBTlE/TmOS3rtYvdyU?=
 =?us-ascii?Q?pQYRyNP6tz3m7bytt5MtLvntz+bUJWSIkxXlVJlrwM5BDllVdXxVYuZ9Zr2E?=
 =?us-ascii?Q?HUV+3dJy6I3glcJcinkkXPx4INix96flsDlHue0HOLhc08DlEEndV4PLL3Xw?=
 =?us-ascii?Q?pYWWO1WnbZceXsItRKXk21UezIZHydjxyMGbmNBxA69UqHitwVmPI1NPtmkf?=
 =?us-ascii?Q?ZA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D6BC7B3BFEF3984DB2B00364887F4FC4@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2FRyq8e5VKtBnwnYR0DkEV9QHQUkpR4nLQMlVPP6qIEMiAEPsLKsB68CheLV90U8hkClGM2H/HUZbLfv8441LlpQlGHqj/4rHIMxu9SIAA/hO0oLafjiUfjBfQf8aBkLSAhiWxVAQW3D7zy5VoJG02VTSjc+xZ8QmLthk/kOm96VaeuAuCRclS4Tiuua1kg7bU0fVVILMknpKy9NN3H4mZt/x8SPum5x/ryRmAxU23Y12MSklhqBkVylIDtBjO+ageVV31HfnsoXiaqyxc+cKWfJ9kaXaHGEPJn9czNXuMOX8X+Uu2JtFl9/gv5OZfNRwBcWuMAPkEu3gtH1ihIYShPebmkX6T4AOi2fGr8kica5HCZ/Kx8KMgOl53RHNufXwWIblzSS90ZTJdDHQsMFT59bSmL0yN0qpy2YZ5KM7JLfJbVDkA2VPwY4jlFsvrKaL645hXANOhVhD/4bsT2gNkucF/Lbt/RXqgzwfn2tZt0Hs6p96S2hTZHgyfav7/GuMa2Xl9JKWRTTE0+LeDP+0+wcS8pczPWOGk+2UiIBf4rgVSk062ZhSrePWf4aShLyv30AOtIN6hE0Xs9lb+dZ2g3t0AUUZ9/nwcRLwgUELtZiCenT3bspdurSCvRDMs8CyQn1bwhI9MM4hDAzcrRyZVRV345YTuaTXeWtwx2VD+YQehT5HyDhjZzb42/eL9g5+3FWjI/FjH2IzjdaVv7Bc+L7VtCR0CxKiAUx9fvPSVEDZ6oYRYI53JjnRVo4YpV7DcOACZMX/ycAr02ckM4kfzvMBww82XNGkrtxCMTf9Og=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4ac03ad-c16b-4a7d-a148-08db67600469
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2023 14:03:49.1568
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oYKiuoLyhk541TI2Qu9XUhwclItNFj0PeiUdPWPVZ3tlD7rnT3NXUz2jlKKDADSnFEsuiq47Lq0lkufAhEusdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7235
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-07_07,2023-06-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306070119
X-Proofpoint-GUID: U17ZblLfvjtK2KtcpYFeTK2qyd7JlDcA
X-Proofpoint-ORIG-GUID: U17ZblLfvjtK2KtcpYFeTK2qyd7JlDcA
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 6, 2023, at 7:41 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> Modified nfsd4_encode_open to encode the op_recall flag properly
> for OPEN result with write delegation granted.

This appears to have been broken for forever. I can't really nail
down a Fixes: commit, so I will add a Cc: stable.


> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 4590b893dbc8..d7e46b940cce 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -3975,7 +3975,7 @@ nfsd4_encode_open(struct nfsd4_compoundres *resp, _=
_be32 nfserr,
> p =3D xdr_reserve_space(xdr, 32);
> if (!p)
> return nfserr_resource;
> - *p++ =3D cpu_to_be32(0);
> + *p++ =3D cpu_to_be32(open->op_recall);
>=20
> /*
> * TODO: space_limit's in delegations
> --=20
> 2.9.5
>=20

--
Chuck Lever