Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66837f03e0f3499cab9786e26c4525109ec074db.camel@kernel.org>
Subject: Re: [PATCH 1/1] NFSD: add encoding of op_recall flag for write
 delegation
From:   Jeff Layton <jlayton@kernel.org>
To:     Dai Ngo <dai.ngo@oracle.com>, chuck.lever@oracle.com
Cc:     linux-nfs@vger.kernel.org
Date:   Wed, 07 Jun 2023 14:04:47 -0400
In-Reply-To: <1686094862-13108-1-git-send-email-dai.ngo@oracle.com>
References: <1686094862-13108-1-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-06-06 at 16:41 -0700, Dai Ngo wrote:
> Modified nfsd4_encode_open to encode the op_recall flag properly
> for OPEN result with write delegation granted.
>=20
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
>  fs/nfsd/nfs4xdr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 4590b893dbc8..d7e46b940cce 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -3975,7 +3975,7 @@ nfsd4_encode_open(struct nfsd4_compoundres *resp, _=
_be32 nfserr,
>  		p =3D xdr_reserve_space(xdr, 32);
>  		if (!p)
>  			return nfserr_resource;
> -		*p++ =3D cpu_to_be32(0);
> +		*p++ =3D cpu_to_be32(open->op_recall);
> =20
>  		/*
>  		 * TODO: space_limit's in delegations

Nice catch!

Reviewed-by: Jeff Layton <jlayton@kernel.org>